Patch Detail
Show a patch.
GET /api/1.1/patches/12972/?format=api
{ "id": 12972, "url": "https://patchwork.libcamera.org/api/1.1/patches/12972/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12972/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210715211459.19373-2-laurent.pinchart@ideasonboard.com>", "date": "2021-07-15T21:14:27", "name": "[libcamera-devel,v3,01/33] cam: options: Make KeyValueParser::usage() private", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f34077b1fc67cdd471cf9beaf2f37956883f4f74", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12972/mbox/", "series": [ { "id": 2242, "url": "https://patchwork.libcamera.org/api/1.1/series/2242/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2242", "date": "2021-07-15T21:14:26", "name": "Multi-camera support in the cam application", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2242/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12972/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12972/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1F8E6C3226\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 15 Jul 2021 21:15:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3532F68548;\n\tThu, 15 Jul 2021 23:15:08 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D69656852A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Jul 2021 23:15:04 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6C9EE56B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Jul 2021 23:15:04 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aMr10Ivn\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626383704;\n\tbh=SZc5X1SBE2MXZ6mozu/Ndinq4j+ms+BeGc+t/+h9EWM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=aMr10Ivn8k45piS+Xq6G7dBJcngkwvW8eggTj2fnSGIMZUtOpVxRafklAQShaax9u\n\tla7dypDzgfaph/+zddB2EY/5JdVlhtb3uiEWPRloq4wPzkWlnpaF9YVsRA28KcECyZ\n\tshCNCaMzb63l+CNtluBS2i8m2RPo0RJ7K7y6fj10=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 16 Jul 2021 00:14:27 +0300", "Message-Id": "<20210715211459.19373-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210715211459.19373-1-laurent.pinchart@ideasonboard.com>", "References": "<20210715211459.19373-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 01/33] cam: options: Make\n\tKeyValueParser::usage() private", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The KeyValueParser::usage() function is meant to be called from an\nOptionsParser or another KeyValueParser only. Make it private, and set\nthe OptionsParser class as a friend of the KeyValueParser class.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/cam/options.h | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/cam/options.h b/src/cam/options.h\nindex f02eeca2eef9..d0defb4bd665 100644\n--- a/src/cam/options.h\n+++ b/src/cam/options.h\n@@ -79,9 +79,11 @@ public:\n \t\t OptionArgument argument = ArgumentNone);\n \n \tvirtual Options parse(const char *arguments);\n+\n+private:\n+\tfriend class OptionsParser;\n \tvoid usage(int indent);\n \n-private:\n \tstd::map<std::string, Option> optionsMap_;\n };\n \n", "prefixes": [ "libcamera-devel", "v3", "01/33" ] }