Patch Detail
Show a patch.
GET /api/1.1/patches/12969/?format=api
{ "id": 12969, "url": "https://patchwork.libcamera.org/api/1.1/patches/12969/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12969/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210715204617.20140-1-vedantparanjape160201@gmail.com>", "date": "2021-07-15T20:46:16", "name": "[libcamera-devel,v3,1/2] libcamera: Fix the V4L2 pixel format for formats::XBGR8888", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c716ad04f873997b57a2fef177f3f4c678e78b98", "submitter": { "id": 85, "url": "https://patchwork.libcamera.org/api/1.1/people/85/?format=api", "name": "Vedant Paranjape", "email": "vedantparanjape160201@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12969/mbox/", "series": [ { "id": 2241, "url": "https://patchwork.libcamera.org/api/1.1/series/2241/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2241", "date": "2021-07-15T20:46:16", "name": "[libcamera-devel,v3,1/2] libcamera: Fix the V4L2 pixel format for formats::XBGR8888", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2241/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12969/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12969/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 92869C3225\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 15 Jul 2021 20:46:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0AAC468539;\n\tThu, 15 Jul 2021 22:46:45 +0200 (CEST)", "from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com\n\t[IPv6:2607:f8b0:4864:20::1029])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4BD4E6059F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Jul 2021 22:46:43 +0200 (CEST)", "by mail-pj1-x1029.google.com with SMTP id\n\td9-20020a17090ae289b0290172f971883bso7346397pjz.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Jul 2021 13:46:43 -0700 (PDT)", "from localhost.localdomain ([1.186.167.37])\n\tby smtp.googlemail.com with ESMTPSA id\n\tc12sm7545796pfl.27.2021.07.15.13.46.39\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 15 Jul 2021 13:46:41 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"oXrEPIZY\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=kQ3i2Qx61kPbBNSobc8acCysjHGsv1SIi5SzjCT28JY=;\n\tb=oXrEPIZYiYrc/0RuSbMlNeXuqhntLLz5Vkt/xJoo9LWzgsqEXafHqA6lrNMh7RalL1\n\tki1vVarp91VnHkXYAz6JRVr4OgxOoT2/AENJB77f1yas+qgnfSvN6/iykbe7+XMuZSse\n\txyslBle73r2JIZXNsVbznMncS91MIp4f/ISxVibTamWA1twmtnP1v9cY4K3F6TR3T2eo\n\teElEGQBQKtdP2O18a1OKm4CDSV6ssbYoeYSbD6aY9I9gYDhughGRnsvodlOdWEl4Za3W\n\tn7eLC5VveWXgUWO4gE9760XHDRGC8+LiSf7nYqBL6/PWOXPIFeGfBihnc2MhQ3IaRNAN\n\t4w6w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=kQ3i2Qx61kPbBNSobc8acCysjHGsv1SIi5SzjCT28JY=;\n\tb=KjcHLQtR50jlo3HYc+4GqchYNpCoysprF9qh364wdmJBjuscly2hVqJkaG6GAIvFF3\n\t1L30eu40R9YteeY8Oo/d3cPwLkHgYJ7dVRZ65Pagj65LDtkKpKN3mnMaTS4KKW9ebipK\n\tg+UrNRO6FaZb4mkj+msi2EJXumYdV+Q9LTGqpC3sXM3WcTjUofVbIOVriwa/CK1eRuUX\n\trwvo2jHDKYyoZk2pYbuZ282vbQIelSSic7PmYAy3VAFW0zDQAGPCNVvOPH4mZUiHJHeq\n\tDQ9yEBYrwqFBfEfPFjYTOrvsNAAR5ef25gBxjR5fDu+bRQAUP/0VNEc5/GFeE4Kg51dk\n\tYzAg==", "X-Gm-Message-State": "AOAM533X7BpDN+nPZcshBA32+VkunWLuuSPwHerqu4ZzhwEwfQ/iunjl\n\tUZgMurWxu55YP8PC5zxveMLAfkIDIwSoEBaNWrQ=", "X-Google-Smtp-Source": "ABdhPJwxLA3CRWNHG/K8GnaDXcwmSn7FV5lGDmTafcllEVy+/DzaWsYy4HT4HoX6U+i8oko9HEbcQQ==", "X-Received": "by 2002:a17:902:8d98:b029:129:18e5:8c31 with SMTP id\n\tv24-20020a1709028d98b029012918e58c31mr4770139plo.3.1626382001376; \n\tThu, 15 Jul 2021 13:46:41 -0700 (PDT)", "From": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 16 Jul 2021 02:16:16 +0530", "Message-Id": "<20210715204617.20140-1-vedantparanjape160201@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 1/2] libcamera: Fix the V4L2 pixel\n\tformat for formats::XBGR8888", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This patch fixes V4L2 pixel format for formats::XBGR8888 by updating\nthe existing matching to V4L2_PIX_FMT_RGBX32\n\nFixes: 4fd6bb33 (\"libcamera: Add support for XRGB8888 and XBGR8888\")\nSigned-off-by: Vedant Paranjape <vedantparanjape160201@gmail.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/formats.cpp | 2 +-\n src/libcamera/v4l2_pixelformat.cpp | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 59a34853..578ac4af 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -198,7 +198,7 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n \t{ formats::XBGR8888, {\n \t\t.name = \"XBGR8888\",\n \t\t.format = formats::XBGR8888,\n-\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_XRGB32),\n+\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_RGBX32),\n \t\t.bitsPerPixel = 32,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n \t\t.packed = false,\ndiff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\nindex 87d728fe..59a01e02 100644\n--- a/src/libcamera/v4l2_pixelformat.cpp\n+++ b/src/libcamera/v4l2_pixelformat.cpp\n@@ -52,7 +52,7 @@ const std::map<V4L2PixelFormat, PixelFormat> vpf2pf{\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB24), formats::BGR888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_BGR24), formats::RGB888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_XBGR32), formats::XRGB8888 },\n-\t{ V4L2PixelFormat(V4L2_PIX_FMT_XRGB32), formats::XBGR8888 },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBX32), formats::XBGR8888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBA32), formats::ABGR8888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_ABGR32), formats::ARGB8888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_ARGB32), formats::BGRA8888 },\n", "prefixes": [ "libcamera-devel", "v3", "1/2" ] }