Patch Detail
Show a patch.
GET /api/1.1/patches/1296/?format=api
{ "id": 1296, "url": "https://patchwork.libcamera.org/api/1.1/patches/1296/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1296/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190527001543.13593-4-niklas.soderlund@ragnatech.se>", "date": "2019-05-27T00:15:29", "name": "[libcamera-devel,03/17] libcamera: geometry: SizeRange: Extend with stepping information", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "da34b8662b5faa87a0cfbbf54d925f129fdef533", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1296/mbox/", "series": [ { "id": 328, "url": "https://patchwork.libcamera.org/api/1.1/series/328/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=328", "date": "2019-05-27T00:15:28", "name": "libcamera: Add support for format information and validation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/328/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1296/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1296/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B61B618F7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 May 2019 02:16:07 +0200 (CEST)", "from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 9d133a73-8014-11e9-8ab4-005056917a89;\n\tMon, 27 May 2019 02:16:03 +0200 (CEST)" ], "X-Halon-ID": "9d133a73-8014-11e9-8ab4-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 27 May 2019 02:15:29 +0200", "Message-Id": "<20190527001543.13593-4-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190527001543.13593-1-niklas.soderlund@ragnatech.se>", "References": "<20190527001543.13593-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 03/17] libcamera: geometry: SizeRange:\n\tExtend with stepping information", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 27 May 2019 00:16:08 -0000" }, "content": "The size range described might be subject to certain stepping\nlimitations. Make it possible to record this information.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n include/libcamera/geometry.h | 13 +++++++++++--\n src/libcamera/geometry.cpp | 37 ++++++++++++++++++++++++++++++++++++\n 2 files changed, 48 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\nindex ec5ed2bee196c82d..1c9267b14274cb5d 100644\n--- a/include/libcamera/geometry.h\n+++ b/include/libcamera/geometry.h\n@@ -73,18 +73,27 @@ struct SizeRange {\n \t}\n \n \tSizeRange(unsigned int width, unsigned int height)\n-\t\t: min(width, height), max(width, height)\n+\t\t: min(width, height), max(width, height), hStep(0), vStep(0)\n \t{\n \t}\n \n \tSizeRange(unsigned int minW, unsigned int minH,\n \t\t unsigned int maxW, unsigned int maxH)\n-\t\t: min(minW, minH), max(maxW, maxH)\n+\t\t: min(minW, minH), max(maxW, maxH), hStep(1), vStep(1)\n+\t{\n+\t}\n+\n+\tSizeRange(unsigned int minW, unsigned int minH,\n+\t\t unsigned int maxW, unsigned int maxH,\n+\t\t unsigned int hstep, unsigned int vstep)\n+\t\t: min(minW, minH), max(maxW, maxH), hStep(hstep), vStep(vstep)\n \t{\n \t}\n \n \tSize min;\n \tSize max;\n+\tunsigned int hStep;\n+\tunsigned int vStep;\n };\n \n bool operator==(const SizeRange &lhs, const SizeRange &rhs);\ndiff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\nindex cc25b816e6796ba1..e7f1bafd40e944f5 100644\n--- a/src/libcamera/geometry.cpp\n+++ b/src/libcamera/geometry.cpp\n@@ -189,6 +189,20 @@ bool operator<(const Size &lhs, const Size &rhs)\n * SizeRange describes a range of sizes included in the [min, max]\n * interval for both the width and the height. If the minimum and\n * maximum sizes are identical it represents a single size.\n+ *\n+ * The SizeRange may also contain a vertical and horizontal stepping.\n+ * The stepping values add additional constrains to the width and height\n+ * values described by the range.\n+ *\n+ *\twidth = min.width + min.hStep * x\n+ *\theight = min.height + min.vStep * y\n+ *\n+ *\tWhere:\n+ *\n+ *\twidth <= max.width\n+ *\theight < max.height\n+ *\n+ * For SizeRanges describing a single size the step values have no effect.\n */\n \n /**\n@@ -212,6 +226,19 @@ bool operator<(const Size &lhs, const Size &rhs)\n * \\param[in] maxH The maximum height\n */\n \n+/**\n+ * \\fn SizeRange::SizeRange(unsigned int minW, unsigned int minH,\n+ *\t\t\t unsigned int maxW, unsigned int maxH,\n+ *\t\t\t unsigned int hstep, unsigned int vstep)\n+ * \\brief Construct an initialized size range\n+ * \\param[in] minW The minimum width\n+ * \\param[in] minH The minimum height\n+ * \\param[in] maxW The maximum width\n+ * \\param[in] maxH The maximum height\n+ * \\param[in] hstep The horizontal step\n+ * \\param[in] vstep The vertical step\n+ */\n+\n /**\n * \\var SizeRange::min\n * \\brief The minimum size\n@@ -222,6 +249,16 @@ bool operator<(const Size &lhs, const Size &rhs)\n * \\brief The maximum size\n */\n \n+/**\n+ * \\var SizeRange::hStep\n+ * \\brief The horizontal step\n+ */\n+\n+/**\n+ * \\var SizeRange::vStep\n+ * \\brief The vertical step\n+ */\n+\n /**\n * \\brief Compare size ranges for equality\n * \\return True if the two size ranges are equal, false otherwise\n", "prefixes": [ "libcamera-devel", "03/17" ] }