Patch Detail
Show a patch.
GET /api/1.1/patches/12958/?format=api
{ "id": 12958, "url": "https://patchwork.libcamera.org/api/1.1/patches/12958/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12958/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210715101709.202034-1-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-07-15T10:17:09", "name": "[libcamera-devel] libipa: Correct OV5670 CameraSensorHelper gain values", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1b06baa56e687e13cfe00d334cf26a77a89629d4", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12958/mbox/", "series": [ { "id": 2234, "url": "https://patchwork.libcamera.org/api/1.1/series/2234/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2234", "date": "2021-07-15T10:17:09", "name": "[libcamera-devel] libipa: Correct OV5670 CameraSensorHelper gain values", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2234/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12958/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12958/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CC9C4C3225\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 15 Jul 2021 10:17:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 410B168523;\n\tThu, 15 Jul 2021 12:17:15 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 88E8C6059F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Jul 2021 12:17:13 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:fab7:64ae:4173:b5e8])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1A3C5340;\n\tThu, 15 Jul 2021 12:17:13 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"R2Xshyvs\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626344233;\n\tbh=23Yh9ml9d1VFFNgrH626hZq8vvYk/GZHE9S4PaVKJAw=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=R2XshyvsO/DVRG+rYYa9Y5W50kzZ73AbUcrqxGqLLF7jVMgXSAVh5ARjZH5qYtDJi\n\t6g33k0/BovcuJ9fhazAkUu4aU5UVYk5zfVd6KzCoCv9nxSbmAAA4bgg2lpPPVlti43\n\t+ogqQyeTthlKIo1OhhSdjBMzKbl0UgXkELGv4Rko=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 15 Jul 2021 12:17:09 +0200", "Message-Id": "<20210715101709.202034-1-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libipa: Correct OV5670 CameraSensorHelper\n\tgain values", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The datasheet states that the low 7 bits are fraction bits.\nreal_gain = GainCode/128\nFor example, 0x080 is 1x gain, 0x100 is 2x gain.\n\nIt means that we should have m0=1 and c1=128.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex 17e4f0b2..709835a8 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -300,7 +300,7 @@ class CameraSensorHelperOv5670 : public CameraSensorHelper\n public:\n \tCameraSensorHelperOv5670()\n \t{\n-\t\tanalogueGainConstants_ = { AnalogueGainLinear, 1, 0, 0, 256 };\n+\t\tanalogueGainConstants_ = { AnalogueGainLinear, 1, 0, 0, 128 };\n \t}\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"ov5670\", CameraSensorHelperOv5670)\n", "prefixes": [ "libcamera-devel" ] }