Patch Detail
Show a patch.
GET /api/1.1/patches/12954/?format=api
{ "id": 12954, "url": "https://patchwork.libcamera.org/api/1.1/patches/12954/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12954/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210714183857.2046425-9-nfraprado@collabora.com>", "date": "2021-07-14T18:38:55", "name": "[libcamera-devel,v6,08/10] lc-compliance: Check that requests complete successfully", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d8c98f5baab8c3c161365f6db1b21e01be71cea7", "submitter": { "id": 84, "url": "https://patchwork.libcamera.org/api/1.1/people/84/?format=api", "name": "Nícolas F. R. A. Prado", "email": "nfraprado@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12954/mbox/", "series": [ { "id": 2232, "url": "https://patchwork.libcamera.org/api/1.1/series/2232/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2232", "date": "2021-07-14T18:38:47", "name": "lc-compliance: Add test to queue more requests than hardware depth", "version": 6, "mbox": "https://patchwork.libcamera.org/series/2232/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12954/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12954/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B2309C3225\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 14 Jul 2021 18:39:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5120D68528;\n\tWed, 14 Jul 2021 20:39:25 +0200 (CEST)", "from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59D9368525\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 14 Jul 2021 20:39:24 +0200 (CEST)", "from localhost.localdomain (unknown\n\t[IPv6:2804:14c:1a9:2434:6553:ad0c:9d2a:24db])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nfraprado)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id C534F1F4322E;\n\tWed, 14 Jul 2021 19:39:22 +0100 (BST)" ], "From": "=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= <nfraprado@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 14 Jul 2021 15:38:55 -0300", "Message-Id": "<20210714183857.2046425-9-nfraprado@collabora.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20210714183857.2046425-1-nfraprado@collabora.com>", "References": "<20210714183857.2046425-1-nfraprado@collabora.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v6 08/10] lc-compliance: Check that\n\trequests complete successfully", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "kernel@collabora.com, =?utf-8?q?Andr=C3=A9_Almeida?=\n\t<andrealmeid@collabora.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When a request fails to queue it is completed but with its status set to\nRequestCancelled. Add a check in the requestComplete callback to make\nsure that the request was completed successfully.\n\nSigned-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>\n---\n\nNo changes in v6\n\nAdded in v5\n\n src/lc-compliance/simple_capture.cpp | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/src/lc-compliance/simple_capture.cpp b/src/lc-compliance/simple_capture.cpp\nindex d1e691abfec1..1883bbb524ac 100644\n--- a/src/lc-compliance/simple_capture.cpp\n+++ b/src/lc-compliance/simple_capture.cpp\n@@ -178,6 +178,7 @@ int SimpleCaptureBalanced::queueRequest(Request *request)\n \n void SimpleCaptureBalanced::requestComplete(Request *request)\n {\n+\tEXPECT_EQ(request->status(), Request::Status::RequestComplete) << \"Request didn't complete successfully\";\n \tif (captureCompleted())\n \t\treturn;\n \n@@ -213,6 +214,7 @@ void SimpleCaptureUnbalanced::capture(unsigned int numRequests)\n \n void SimpleCaptureUnbalanced::requestComplete(Request *request)\n {\n+\tEXPECT_EQ(request->status(), Request::Status::RequestComplete) << \"Request didn't complete successfully\";\n \tif (captureCompleted())\n \t\treturn;\n \n@@ -248,5 +250,6 @@ void SimpleCaptureOverflow::capture()\n \n void SimpleCaptureOverflow::requestComplete([[maybe_unused]] Request *request)\n {\n+\tEXPECT_EQ(request->status(), Request::Status::RequestComplete) << \"Request didn't complete successfully\";\n \tcaptureCompleted();\n }\n", "prefixes": [ "libcamera-devel", "v6", "08/10" ] }