Patch Detail
Show a patch.
GET /api/1.1/patches/12920/?format=api
{ "id": 12920, "url": "https://patchwork.libcamera.org/api/1.1/patches/12920/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12920/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210712215645.30478-8-laurent.pinchart@ideasonboard.com>", "date": "2021-07-12T21:56:22", "name": "[libcamera-devel,v2,07/30] cam: options: Disable copy for parsers", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "27868f3ea513986a64922b17306c7151c67de312", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12920/mbox/", "series": [ { "id": 2229, "url": "https://patchwork.libcamera.org/api/1.1/series/2229/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2229", "date": "2021-07-12T21:56:15", "name": "Multi-camera support in the cam application", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2229/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12920/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12920/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4071CC3226\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 12 Jul 2021 21:57:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B2D7968537;\n\tMon, 12 Jul 2021 23:57:44 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 24CBC68513\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 12 Jul 2021 23:57:38 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CCC993F1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 12 Jul 2021 23:57:37 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YdVB1PtR\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626127058;\n\tbh=oYV6JVyDxp7EFxRmXWOnlY6026MGPvJj1KvTaYunqVM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=YdVB1PtRCEw5Z+gI2oXhg48q5oYOy6exw+ZBRKg4qkPI7kud2KGl2x9FCLQjrx9VP\n\t4fZMZ9J+Z/YkPvmnvGBRip6J/DFjxq8mlwH5AswaDf34S/dxB1lfIfhDLDrrWe/jXL\n\th08QbwYGzcalp0Wi9ARuktyfH/AN2GjuO7hEa5Cg=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 13 Jul 2021 00:56:22 +0300", "Message-Id": "<20210712215645.30478-8-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210712215645.30478-1-laurent.pinchart@ideasonboard.com>", "References": "<20210712215645.30478-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 07/30] cam: options: Disable copy for\n\tparsers", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Copying the OptionsParser class would result in the optionsMap_ entries\npointing to Option entries of the original instance. As there's no use\ncase for copying the class, disable copying.\n\nDisable copying of KeyValueParser as well for consistency as there's no\nuse case either.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/cam/options.h | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/src/cam/options.h b/src/cam/options.h\nindex 01a5d36a63fb..4418e201bf1f 100644\n--- a/src/cam/options.h\n+++ b/src/cam/options.h\n@@ -68,6 +68,9 @@ public:\n \tvirtual Options parse(const char *arguments);\n \n private:\n+\tKeyValueParser(const KeyValueParser &) = delete;\n+\tKeyValueParser &operator=(const KeyValueParser &) = delete;\n+\n \tfriend class OptionsParser;\n \tvoid usage(int indent);\n \n@@ -95,6 +98,9 @@ public:\n \tvoid usage();\n \n private:\n+\tOptionsParser(const OptionsParser &) = delete;\n+\tOptionsParser &operator=(const OptionsParser &) = delete;\n+\n \tvoid usageOptions(const std::list<Option> &options, unsigned int indent);\n \n \tstd::list<Option> options_;\n", "prefixes": [ "libcamera-devel", "v2", "07/30" ] }