Patch Detail
Show a patch.
GET /api/1.1/patches/12884/?format=api
{ "id": 12884, "url": "https://patchwork.libcamera.org/api/1.1/patches/12884/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12884/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210709145825.2943443-2-naush@raspberrypi.com>", "date": "2021-07-09T14:58:18", "name": "[libcamera-devel,v6,1/8] ipa: raspberrypi: Make device_status.h C++ only header, and update comments", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9fc4c198c499d9ada202e2973a56da03a2b14301", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12884/mbox/", "series": [ { "id": 2223, "url": "https://patchwork.libcamera.org/api/1.1/series/2223/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2223", "date": "2021-07-09T14:58:17", "name": "ipa: raspberrypi: Allow long exposure modes for imx477.", "version": 6, "mbox": "https://patchwork.libcamera.org/series/2223/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12884/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12884/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 36652C3225\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 9 Jul 2021 14:58:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E53C36851B;\n\tFri, 9 Jul 2021 16:58:32 +0200 (CEST)", "from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com\n\t[IPv6:2a00:1450:4864:20::32d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF1A9684E7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 9 Jul 2021 16:58:30 +0200 (CEST)", "by mail-wm1-x32d.google.com with SMTP id\n\tt14-20020a05600c198eb029020c8aac53d4so26039070wmq.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 09 Jul 2021 07:58:30 -0700 (PDT)", "from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:35c2:26d3:e217:4410])\n\tby smtp.gmail.com with ESMTPSA id\n\tc2sm1480995wrn.28.2021.07.09.07.58.29\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 09 Jul 2021 07:58:29 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"CrxyJf3U\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=dNPy1AuK4kcuuK0B4jDCWxmKmOZ6QX0jJpC6NtzaGA4=;\n\tb=CrxyJf3U3yW2/kAhIuYrLYOgu2VsaEcUwOmfkyV/SGGgDzYfOosBdn8pGCUMKEfs5f\n\tJ0sQsYHSestTAQb1wb096leGQfpWPUDk5tVLAqry+ILxHmkgykMuDuX2EnjceX2Pjecb\n\tTzX5xcodyCwa7swVNREaS9Tutvb+Dz8gXZUIpz+bmeWVuJbqv3y+wbiQX11EULReRj6U\n\t1cfPCmxtutzpeaKw0Eez4WvNBv31I6BTI3QngtmORO5f4FqPPQ1vrBAWuMVJiaDwJmrt\n\tvFg0GesTjbcEUR95WrX78h9O03jlXKBnXPtIVlbQ3g6XeVUjrohVwproU8eukD5guFvA\n\to6CA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=dNPy1AuK4kcuuK0B4jDCWxmKmOZ6QX0jJpC6NtzaGA4=;\n\tb=MFe0ruC6KQLCk5Et93mI1EAVsAYNbgcflKyKQcZOoairC15RrbIE19BCFN5LfUnmNh\n\tJZKhy16OtSRXYQsunnI6KcXoOdcX6pBPqfl+uGivBBA2VD2MgjgFkX0FRP6j01LVHN6w\n\tq4YHeofby7HkURpVAy2qoSJ+GOBuklN8Gj5EXWC4lOYIQf2X7qORvjY/GTSSgDyT4zp/\n\taagixZOYuDE/4n2XEUtbbFxg5BN+D9QjbiL0RyjYPLI8tPq8q1v0kBXpaOADGj73b0JX\n\tSFkD/ZaZdxwlNJUd99z3Qk073xfv8+Y3JsPJdGlhy6OguEgrko+QaiFesAIkYMFtnuUd\n\tzHkQ==", "X-Gm-Message-State": "AOAM532/VG3ltIPEAlIOngLFWS0fFuZb9XB5SBwSK6fpblUo/hzwP4XB\n\t2ymAbbRX6U4P7YgrRDoTFLD6+PB6iyz+dQ==", "X-Google-Smtp-Source": "ABdhPJxcHpARqbVsoFLEvfPMH6XiJU8f5ltOZFAQ+t8Aga+hKVQIH9rhEbnuRwTaxg9B/PZce4Cs2w==", "X-Received": "by 2002:a7b:c258:: with SMTP id\n\tb24mr12645737wmj.122.1625842710397; \n\tFri, 09 Jul 2021 07:58:30 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 9 Jul 2021 15:58:18 +0100", "Message-Id": "<20210709145825.2943443-2-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210709145825.2943443-1-naush@raspberrypi.com>", "References": "<20210709145825.2943443-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v6 1/8] ipa: raspberrypi: Make\n\tdevice_status.h C++ only header, and update comments", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This header file is no longer C compatible, so remove the extern \"C\"\ndeclaration.\n\nReplace C++ style comments with C style based on libcamera guidelines.\n\nThere are no functional changes in this commit.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n .../raspberrypi/controller/device_status.h | 24 +++++++------------\n 1 file changed, 9 insertions(+), 15 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/controller/device_status.h b/src/ipa/raspberrypi/controller/device_status.h\nindex f74235248b12..733378dbfa27 100644\n--- a/src/ipa/raspberrypi/controller/device_status.h\n+++ b/src/ipa/raspberrypi/controller/device_status.h\n@@ -1,6 +1,6 @@\n /* SPDX-License-Identifier: BSD-2-Clause */\n /*\n- * Copyright (C) 2019, Raspberry Pi (Trading) Limited\n+ * Copyright (C) 2019-2021, Raspberry Pi (Trading) Limited\n *\n * device_status.h - device (image sensor) status\n */\n@@ -8,25 +8,19 @@\n \n #include <libcamera/base/utils.h>\n \n-// Definition of \"device metadata\" which stores things like shutter time and\n-// analogue gain that downstream control algorithms will want to know.\n-\n-#ifdef __cplusplus\n-extern \"C\" {\n-#endif\n+/*\n+ * Definition of \"device metadata\" which stores things like shutter time and\n+ * analogue gain that downstream control algorithms will want to know.\n+ */\n \n struct DeviceStatus {\n-\t// time shutter is open\n+\t/* time shutter is open */\n \tlibcamera::utils::Duration shutter_speed;\n \tdouble analogue_gain;\n-\t// 1.0/distance-in-metres, or 0 if unknown\n+\t/* 1.0/distance-in-metres, or 0 if unknown */\n \tdouble lens_position;\n-\t// 1/f so that brightness quadruples when this doubles, or 0 if unknown\n+\t/* 1/f so that brightness quadruples when this doubles, or 0 if unknown */\n \tdouble aperture;\n-\t// proportional to brightness with 0 = no flash, 1 = maximum flash\n+\t/* proportional to brightness with 0 = no flash, 1 = maximum flash */\n \tdouble flash_intensity;\n };\n-\n-#ifdef __cplusplus\n-}\n-#endif\n", "prefixes": [ "libcamera-devel", "v6", "1/8" ] }