Patch Detail
Show a patch.
GET /api/1.1/patches/12882/?format=api
{ "id": 12882, "url": "https://patchwork.libcamera.org/api/1.1/patches/12882/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12882/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210709114736.875760-2-umang.jain@ideasonboard.com>", "date": "2021-07-09T11:47:36", "name": "[libcamera-devel,2/2] libcamera: v4l2_videodevice: Clear cache_ in ~V4L2BufferCache()", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "62b0298cbc4f08eb1f6dc3bcf4f2029ac907ef38", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12882/mbox/", "series": [ { "id": 2222, "url": "https://patchwork.libcamera.org/api/1.1/series/2222/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2222", "date": "2021-07-09T11:47:35", "name": "[libcamera-devel,1/2] libcamera: v4l2_videodevice: Correctly populate V4L2BufferCache cache", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2222/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12882/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12882/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 56340BD794\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 9 Jul 2021 11:47:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1839768523;\n\tFri, 9 Jul 2021 13:47:56 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0AAF6605AC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 9 Jul 2021 13:47:55 +0200 (CEST)", "from perceval.ideasonboard.com (unknown\n\t[IPv6:2405:204:8084:161d:f4be:7125:3161:2a88])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 912B4E7;\n\tFri, 9 Jul 2021 13:47:53 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"acbaGXtN\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625831274;\n\tbh=/g8c85ckl7YKHh0iGfC+mQ9fhmr1YeyWUG/44ONo+tU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=acbaGXtNklngYCVi7jO+mJpatuFZjDinaT8REaMSJZQcfeLfPkT97wnH24iIAnT25\n\tQMmeiyl1AiGSNq6/ams5VKbYyrausIJr77Tyu7Ple8BAbDxYRHMCxZQDchfE+mAFNa\n\tCYz0gbOP3XNjICJrcnEU6YZ27LXe3oCCoqcIol3k=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 9 Jul 2021 17:17:36 +0530", "Message-Id": "<20210709114736.875760-2-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210709114736.875760-1-umang.jain@ideasonboard.com>", "References": "<20210709114736.875760-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/2] libcamera: v4l2_videodevice: Clear\n\tcache_ in ~V4L2BufferCache()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This shall help release any taken reference, just in case.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/libcamera/v4l2_videodevice.cpp | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex da2af6a1..1e33571c 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -190,6 +190,8 @@ V4L2BufferCache::~V4L2BufferCache()\n {\n \tif (missCounter_ > cache_.size())\n \t\tLOG(V4L2, Debug) << \"Cache misses: \" << missCounter_;\n+\n+\tcache_.clear();\n }\n \n /**\n", "prefixes": [ "libcamera-devel", "2/2" ] }