Patch Detail
Show a patch.
GET /api/1.1/patches/12879/?format=api
{ "id": 12879, "url": "https://patchwork.libcamera.org/api/1.1/patches/12879/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12879/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210709095638.2801713-8-naush@raspberrypi.com>", "date": "2021-07-09T09:56:38", "name": "[libcamera-devel,v5,8/8] ipa: raspberrypi: Make variable names consistent", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f31a50c0338dff5ce2c47fc852d5e1f000206f7f", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12879/mbox/", "series": [ { "id": 2220, "url": "https://patchwork.libcamera.org/api/1.1/series/2220/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2220", "date": "2021-07-09T09:56:31", "name": "[libcamera-devel,v5,1/8] ipa: raspberrypi: Make device_status.h C++ only header, and update comments", "version": 5, "mbox": "https://patchwork.libcamera.org/series/2220/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12879/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12879/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55EC2BD794\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 9 Jul 2021 09:56:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A1FC68526;\n\tFri, 9 Jul 2021 11:56:58 +0200 (CEST)", "from mail-wr1-x436.google.com (mail-wr1-x436.google.com\n\t[IPv6:2a00:1450:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 875166851F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 9 Jul 2021 11:56:54 +0200 (CEST)", "by mail-wr1-x436.google.com with SMTP id k4so5065026wrc.8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 09 Jul 2021 02:56:54 -0700 (PDT)", "from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:35c2:26d3:e217:4410])\n\tby smtp.gmail.com with ESMTPSA id\n\tb16sm1599014wrw.46.2021.07.09.02.56.53\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 09 Jul 2021 02:56:53 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"gqU6qDiR\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=XRqliTz93DSGGSQlWnMS4j2UEugn1xX6LG8wnraWzSo=;\n\tb=gqU6qDiRISaxcYhJz97vNrv7uk2z+Ircv2wB+sLUYJcfwb92aTLX+I85lr+XWA+lIY\n\tN6z3f6wKi2ETJN0tZ/H4R6tK8V1XfEziMakzJjgNkOjQMTsCLzbPrvxU1IvEvtdehnbB\n\txkJKr7xY1W12Nhphs79FwQxb9NMS05uIVPwBtEmpb3Q2Ll93q+lbTODjdruqveKMGC9n\n\t0I8xlha828fJP2RIBlMoia04j3aNXAVvtgtuQylhOu04G11t5EeQ3c1k63AQte5hoPmU\n\thFi1/gku8I1a9JWlSJRcZ8LAimMXW4eBbVvHlpkZuYq1ZYWD0YfCyu6owAE2siUtrS3U\n\tirww==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=XRqliTz93DSGGSQlWnMS4j2UEugn1xX6LG8wnraWzSo=;\n\tb=tDee+8ZS7FTpkSzluHFzSuZDdkzrSITBLV/4fdxG4qktjxS6Aod7fWARsje4IuoLHm\n\t3LmiAA3bZds9ssNSWXeh7rQtvTY713MeiblBpOa95iKOAG1axkILORD0qjtfYMdPUmGA\n\tq1TkHWmxSL9SB/H0FtXoHHtdvnT3BeBwIjkWXr2CW34OThkVjn67g7OO85r+bwEoqrMY\n\tbp0Y0QXWVYTfEM9XU6hXYCmDev3YBx7OJWlP9jvZpVYFIO4RH9ITEeJKpr+tQ2hWta10\n\tkrBIZCcG/7KqFEo2DuCOIMhpeVQC93vJi+ZK7oUMENaV5GdnQ0KN5xNrqtLupVYs9qBb\n\t4USw==", "X-Gm-Message-State": "AOAM5315D88cppwzvfLe8gNU+1eYYfGGXrDLxMiOzq20cUOqZsAHmdRj\n\tKfDM88Gyc75l/aSPC1zKRY+Iv0URbrDm6g==", "X-Google-Smtp-Source": "ABdhPJww0ry8sMh7P1mzcejttvoMqBNhidUdoK7OmcFOKYOg40HsqoMTnv6PNnsH2HA07sa5gAbarw==", "X-Received": "by 2002:adf:f848:: with SMTP id\n\td8mr33853855wrq.308.1625824614111; \n\tFri, 09 Jul 2021 02:56:54 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 9 Jul 2021 10:56:38 +0100", "Message-Id": "<20210709095638.2801713-8-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210709095638.2801713-1-naush@raspberrypi.com>", "References": "<20210709095638.2801713-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 8/8] ipa: raspberrypi: Make variable\n\tnames consistent", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "s/DefaultAnalogueGain/defaultAnalogueGain/\ns/DefaultExposureTime/defaultExposureTime/\n\nChange these for consistency with the other static const variables.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/raspberrypi/raspberrypi.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 8fb98a49da63..1dd7fd68c3e9 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -59,8 +59,8 @@ using namespace std::literals::chrono_literals;\n using utils::Duration;\n \n /* Configure the sensor with these values initially. */\n-constexpr double DefaultAnalogueGain = 1.0;\n-constexpr Duration DefaultExposureTime = 20.0ms;\n+constexpr double defaultAnalogueGain = 1.0;\n+constexpr Duration defaultExposureTime = 20.0ms;\n constexpr Duration defaultMinFrameDuration = 1.0s / 30.0;\n constexpr Duration defaultMaxFrameDuration = 250.0s;\n \n@@ -390,8 +390,8 @@ int IPARPi::configure(const IPACameraSensorInfo &sensorInfo,\n \t\t/* Supply initial values for gain and exposure. */\n \t\tControlList ctrls(sensorCtrls_);\n \t\tAgcStatus agcStatus;\n-\t\tagcStatus.shutter_time = DefaultExposureTime;\n-\t\tagcStatus.analogue_gain = DefaultAnalogueGain;\n+\t\tagcStatus.shutter_time = defaultExposureTime;\n+\t\tagcStatus.analogue_gain = defaultAnalogueGain;\n \t\tapplyAGC(&agcStatus, ctrls);\n \n \t\tASSERT(controls);\n", "prefixes": [ "libcamera-devel", "v5", "8/8" ] }