Patch Detail
Show a patch.
GET /api/1.1/patches/12873/?format=api
{ "id": 12873, "url": "https://patchwork.libcamera.org/api/1.1/patches/12873/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12873/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210709095638.2801713-2-naush@raspberrypi.com>", "date": "2021-07-09T09:56:32", "name": "[libcamera-devel,v5,2/8] ipa: raspberrypi: Add a constructor struct DeviceStatus", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b8bb7bfa6a8820aac23d3ce34356ecf3103f436f", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12873/mbox/", "series": [ { "id": 2220, "url": "https://patchwork.libcamera.org/api/1.1/series/2220/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2220", "date": "2021-07-09T09:56:31", "name": "[libcamera-devel,v5,1/8] ipa: raspberrypi: Make device_status.h C++ only header, and update comments", "version": 5, "mbox": "https://patchwork.libcamera.org/series/2220/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12873/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12873/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0DCB2BD794\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 9 Jul 2021 09:56:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BEF7F6852A;\n\tFri, 9 Jul 2021 11:56:51 +0200 (CEST)", "from mail-wr1-x430.google.com (mail-wr1-x430.google.com\n\t[IPv6:2a00:1450:4864:20::430])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 05F44684F3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 9 Jul 2021 11:56:50 +0200 (CEST)", "by mail-wr1-x430.google.com with SMTP id i8so11321555wrp.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 09 Jul 2021 02:56:50 -0700 (PDT)", "from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:35c2:26d3:e217:4410])\n\tby smtp.gmail.com with ESMTPSA id\n\tb16sm1599014wrw.46.2021.07.09.02.56.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 09 Jul 2021 02:56:49 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"WqD6P+9r\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=xKQKDlA/B6wWUNDaLbnwgPOltVgogbkgEw+x4QjCkLg=;\n\tb=WqD6P+9rdFO2LpCmSkvhWpOTht2iZz5JXTc/epY8xqvvqLP6r4IsZNH8sXXjVZpo6I\n\tPht5kJjM+atmdWPND/x8YVzmcdLfrRfpfP28ZOLJvqSUQykYzyNA3X81YgAFLRhaTlal\n\tELiLkEqE5bhr7efH0t0DFtyv43Xadyaj3vAY//sxRd4XsbOzM/a0H3+cVs7wtok3ItST\n\tMgnnzUXOvwQvPWUYVwJ8Z1m4aBKPPYWeosvPvUcMkxey3izHTNIjEIAIULbMBNr7UeYQ\n\t+ihAGkeIM0wmfcdL9WQCDRZm4NENcLmVD7JomPcFMK6ui9KHepJ0bQuxLa4uVXzutmFX\n\t6Opw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=xKQKDlA/B6wWUNDaLbnwgPOltVgogbkgEw+x4QjCkLg=;\n\tb=ObKzXRCU5/7czFu/qc2b6ah53Ypvsi+bu5N6bt8fU0ITED29uFYM1SQ5Lhhah2fBN/\n\tJii/Vd3+DN7sCnt71f7WuEs4Ljk8zQBAeK+Cz5tcXyTAE0K7JgJ5hm1Orn+b0lDl52JV\n\tiKDmoemYgg24ia8WZujI+ddlm+CYLbZoE2gm+2wO/dDFcuEpkcMp410uDjZVBOhlNy/f\n\tzzTKvisPQSlrkh6BEc9vsDB2a0W9EkTxOODtjEvVprOb4ZxGkX/cm3ih7g6N93g6OCAu\n\t8y8fGCYOZTxO8H+VZHiwnAaVKn5eRVLu/FLdiS33mtxsOn4Q3VuV3/x+E71af34mtIzv\n\tLTfQ==", "X-Gm-Message-State": "AOAM531eJzQnYVIxtO10xUH7/jUxPc/ahz/R5pRjDUzOMJBock+D6KBd\n\tPiEy7unkg1rdH3JxRmHkGswTy17XQq5jAg==", "X-Google-Smtp-Source": "ABdhPJwdeg29lNFlpnrWm1tlcdT1mPs/Hm1e0tWL6RrR0lRX7KaLHsL107oEKu9jdtpOFfLaesFGeQ==", "X-Received": "by 2002:a5d:4573:: with SMTP id\n\ta19mr3051548wrc.346.1625824609567; \n\tFri, 09 Jul 2021 02:56:49 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 9 Jul 2021 10:56:32 +0100", "Message-Id": "<20210709095638.2801713-2-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210709095638.2801713-1-naush@raspberrypi.com>", "References": "<20210709095638.2801713-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 2/8] ipa: raspberrypi: Add a\n\tconstructor struct DeviceStatus", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The constructor sets all fields to 0. This replaces the memset(0) and default\nvalue initialisation usage in the agc and lux controllers respectively.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/raspberrypi/controller/device_status.h | 6 ++++++\n src/ipa/raspberrypi/controller/rpi/agc.cpp | 1 -\n src/ipa/raspberrypi/controller/rpi/lux.cpp | 9 +--------\n 3 files changed, 7 insertions(+), 9 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/controller/device_status.h b/src/ipa/raspberrypi/controller/device_status.h\nindex 733378dbfa27..73df7ce228dd 100644\n--- a/src/ipa/raspberrypi/controller/device_status.h\n+++ b/src/ipa/raspberrypi/controller/device_status.h\n@@ -14,6 +14,12 @@\n */\n \n struct DeviceStatus {\n+\tDeviceStatus()\n+\t\t: shutter_speed(std::chrono::seconds(0)), analogue_gain(0.0),\n+\t\t lens_position(0.0), aperture(0.0), flash_intensity(0.0)\n+\t{\n+\t}\n+\n \t/* time shutter is open */\n \tlibcamera::utils::Duration shutter_speed;\n \tdouble analogue_gain;\ndiff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp\nindex 6c3a4eb2a04d..f57783f821ec 100644\n--- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n@@ -172,7 +172,6 @@ Agc::Agc(Controller *controller)\n \t// it's not been calculated yet (i.e. Process hasn't yet run).\n \tmemset(&status_, 0, sizeof(status_));\n \tstatus_.ev = ev_;\n-\tmemset(&last_device_status_, 0, sizeof(last_device_status_));\n }\n \n char const *Agc::Name() const\ndiff --git a/src/ipa/raspberrypi/controller/rpi/lux.cpp b/src/ipa/raspberrypi/controller/rpi/lux.cpp\nindex f58d69397e1c..6367b17dc7f4 100644\n--- a/src/ipa/raspberrypi/controller/rpi/lux.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/lux.cpp\n@@ -60,14 +60,7 @@ void Lux::Prepare(Metadata *image_metadata)\n \n void Lux::Process(StatisticsPtr &stats, Metadata *image_metadata)\n {\n-\t// set some initial values to shut the compiler up\n-\tDeviceStatus device_status = {\n-\t\t.shutter_speed = 1.0ms,\n-\t\t.analogue_gain = 1.0,\n-\t\t.lens_position = 0.0,\n-\t\t.aperture = 0.0,\n-\t\t.flash_intensity = 0.0\n-\t};\n+\tDeviceStatus device_status;\n \tif (image_metadata->Get(\"device.status\", device_status) == 0) {\n \t\tdouble current_gain = device_status.analogue_gain;\n \t\tdouble current_aperture = device_status.aperture;\n", "prefixes": [ "libcamera-devel", "v5", "2/8" ] }