Patch Detail
Show a patch.
GET /api/1.1/patches/12773/?format=api
{ "id": 12773, "url": "https://patchwork.libcamera.org/api/1.1/patches/12773/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12773/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210702103800.41291-9-paul.elder@ideasonboard.com>", "date": "2021-07-02T10:37:52", "name": "[libcamera-devel,RFC,v3,08/16] android: Plumb AeEnable control", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "522565ad8d16ed096020165e86809d76171fd74e", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/12773/mbox/", "series": [ { "id": 2199, "url": "https://patchwork.libcamera.org/api/1.1/series/2199/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2199", "date": "2021-07-02T10:37:44", "name": "Preliminary FULL plumbing", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2199/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12773/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12773/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B6161C3223\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 2 Jul 2021 10:38:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 74A54684F2;\n\tFri, 2 Jul 2021 12:38:29 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C17E684EA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 2 Jul 2021 12:38:28 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 013704AB;\n\tFri, 2 Jul 2021 12:38:26 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"owPMM4w3\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625222308;\n\tbh=iVTWY+Na5T9ScmcOGpzeaufCqnADUGvdg5sxTmjdXW0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=owPMM4w3qy1ck3nnokqawz86XvDOIR+Ej2gKkS3WqHGzsXmNNvtn+noKN/I857KwO\n\t5pwX2lHGo61049GgSVgV4ZAVK/Y6aJOLg1YXMat33O6lijYvzcp5XnSL0ZfJ/j9QTH\n\tMDMMYmgigLAKAD8OnBETJdjSNnCWvsxfRmFUR7Ug=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 2 Jul 2021 19:37:52 +0900", "Message-Id": "<20210702103800.41291-9-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210702103800.41291-1-paul.elder@ideasonboard.com>", "References": "<20210702103800.41291-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH v3 08/16] android: Plumb AeEnable\n\tcontrol", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Plumb the AeEnable control into the HAL for CONTROL_AE_AVAILABLE_MODES\nfor static metadata, and CONTROL_AE_MODE for result metadata.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=42\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nChanges in v3\n- use new setMetadata\n- rebase on camera capabilities refactor\n---\n src/android/camera_capabilities.cpp | 19 ++++++++++++++-----\n src/android/camera_device.cpp | 6 ++++--\n 2 files changed, 18 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 530167de..21ba791a 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -7,6 +7,7 @@\n \n #include \"camera_capabilities.h\"\n \n+#include <algorithm>\n #include <array>\n #include <cmath>\n #include <map>\n@@ -561,11 +562,19 @@ int CameraCapabilities::initializeStaticMetadata()\n \tstaticMetadata_->addEntry(ANDROID_CONTROL_AE_AVAILABLE_ANTIBANDING_MODES,\n \t\t\t\t aeAvailableAntiBandingModes);\n \n-\tstd::vector<uint8_t> aeAvailableModes = {\n-\t\tANDROID_CONTROL_AE_MODE_ON,\n-\t};\n-\tstaticMetadata_->addEntry(ANDROID_CONTROL_AE_AVAILABLE_MODES,\n-\t\t\t\t aeAvailableModes);\n+\tstd::vector<uint8_t> aeModes = setMetadata<uint8_t, bool>(\n+\t\tstaticMetadata_.get(),\n+\t\tANDROID_CONTROL_AE_AVAILABLE_MODES,\n+\t\tcontrolsInfo, &controls::AeEnable,\n+\t\tstd::vector<uint8_t>({ ANDROID_CONTROL_AE_MODE_ON }));\n+\n+\tif (std::find(aeModes.begin(), aeModes.end(),\n+\t\t ANDROID_CONTROL_AE_MODE_OFF) == aeModes.end()) {\n+\t\tLOG(HAL, Info) << \"AE cannot be turned off\";\n+\t\thwLevels.erase(ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_FULL);\n+\t\t/* \\todo Double check if this is the correct capability */\n+\t\tcapabilities.erase(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_SENSOR);\n+\t}\n \n \tint64_t minFrameDurationNsec = -1;\n \tint64_t maxFrameDurationNsec = -1;\ndiff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 678cde23..1711f271 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1202,8 +1202,10 @@ CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor) cons\n \tvalue = ANDROID_CONTROL_AE_LOCK_OFF;\n \tresultMetadata->addEntry(ANDROID_CONTROL_AE_LOCK, value);\n \n-\tvalue = ANDROID_CONTROL_AE_MODE_ON;\n-\tresultMetadata->addEntry(ANDROID_CONTROL_AE_MODE, value);\n+\tif (metadata.contains(controls::AeEnable)) {\n+\t\tuint8_t aeMode = metadata.get<bool>(controls::AeEnable);\n+\t\tresultMetadata->addEntry(ANDROID_CONTROL_AE_MODE, aeMode);\n+\t}\n \n \tif (settings.getEntry(ANDROID_CONTROL_AE_TARGET_FPS_RANGE, &entry))\n \t\t/*\n", "prefixes": [ "libcamera-devel", "RFC", "v3", "08/16" ] }