Patch Detail
Show a patch.
GET /api/1.1/patches/12753/?format=api
{ "id": 12753, "url": "https://patchwork.libcamera.org/api/1.1/patches/12753/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12753/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210629165830.196578-1-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-06-29T16:58:30", "name": "[libcamera-devel,v2] libcamera: pipeline_handler: Hide implementation detail comment from doxygen", "commit_ref": "9d44551404fe0e68d4eaf087ac6fdd549434e98a", "pull_url": null, "state": "accepted", "archived": false, "hash": "c17f048875861f0dc01defb9003897ddeb69e756", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12753/mbox/", "series": [ { "id": 2194, "url": "https://patchwork.libcamera.org/api/1.1/series/2194/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2194", "date": "2021-06-29T16:58:30", "name": "[libcamera-devel,v2] libcamera: pipeline_handler: Hide implementation detail comment from doxygen", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2194/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12753/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12753/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2DC93C321F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 29 Jun 2021 16:58:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 72C51684E9;\n\tTue, 29 Jun 2021 18:58:40 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A2FAC684CB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 29 Jun 2021 18:58:35 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:d4ff:199e:6bde:2ea6])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 28A7F4AD;\n\tTue, 29 Jun 2021 18:58:35 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Phc5CNZK\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624985915;\n\tbh=Ni4TkC3TBUKS5C7PYOW0jDnCfv96ZutYSuStq1xyxtc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Phc5CNZK6kllYgX2WZ1v6IzSrfn/a7TlLw2n0jLIjHhKU2Wapev2CtlbOcAsRXiJb\n\ttDZNDlby9aqdDhqmgyv8zV3eUNDCpFy/YBhoMc4ieVc6biBj2BDJpgRZn8P3gXNw7H\n\t+cgtBsBnAjOgAubOGa5aTehGEd22E1zjZjOgARak=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 29 Jun 2021 18:58:30 +0200", "Message-Id": "<20210629165830.196578-1-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2] libcamera: pipeline_handler: Hide\n\timplementation detail comment from doxygen", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The comment is a implementation detail and does not belong to API\ndocumentation. Move it inside the function.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline_handler.cpp | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex f626eddd..0ed172dc 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -707,14 +707,15 @@ void PipelineHandlerFactory::registerType(PipelineHandlerFactory *factory)\n \n /**\n * \\brief Retrieve the list of all pipeline handler factories\n- *\n- * The static factories map is defined inside the function to ensures it gets\n- * initialized on first use, without any dependency on link order.\n- *\n * \\return the list of pipeline handler factories\n */\n std::vector<PipelineHandlerFactory *> &PipelineHandlerFactory::factories()\n {\n+\t/*\n+\t * The static factories map is defined inside the function to ensure\n+\t * it gets initialized on first use, without any dependency on\n+\t * link order.\n+\t */\n \tstatic std::vector<PipelineHandlerFactory *> factories;\n \treturn factories;\n }\n", "prefixes": [ "libcamera-devel", "v2" ] }