Patch Detail
Show a patch.
GET /api/1.1/patches/12739/?format=api
{ "id": 12739, "url": "https://patchwork.libcamera.org/api/1.1/patches/12739/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12739/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210628202255.138874-5-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-06-28T20:22:52", "name": "[libcamera-devel,v1,4/7] ipa: ipu3: use process method for all algorithms", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "3bb87e7486ab33a21b75a857fac29086a92c73e9", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12739/mbox/", "series": [ { "id": 2190, "url": "https://patchwork.libcamera.org/api/1.1/series/2190/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2190", "date": "2021-06-28T20:22:48", "name": "ipa: Introduce a new open AGC", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2190/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12739/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12739/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 841C0C321F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 28 Jun 2021 20:23:07 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 24372684EA;\n\tMon, 28 Jun 2021 22:23:07 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 83C63684D8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 28 Jun 2021 22:23:00 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:c3ad:78d0:405e:fc33])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2D0532469;\n\tMon, 28 Jun 2021 22:23:00 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RXsaMKMn\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624911780;\n\tbh=Y0h3Bcoe7Rnm7xKKbZTDs4vuo3agSQr8boF6ViMbg+I=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=RXsaMKMn1ZMG66pWpwa8eP43kQAqJATB1+WD8fJylrqYaURtvgxPPfhAahOOp04RV\n\t6hbKgD+qcPusAWiHZE05/Rskzjx1IrgMR6Xryc0XMNVsQERDfv4+vNOkIf7Vy39Alm\n\ti5N9+30SbKEngChQXazNiVDgrnN4XM3U6P1nLLU0=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 28 Jun 2021 22:22:52 +0200", "Message-Id": "<20210628202255.138874-5-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210628202255.138874-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20210628202255.138874-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 4/7] ipa: ipu3: use process method for\n\tall algorithms", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The main goal will be to have the same process() prototype for all\nalgorithms, each of them would then grab the values needed using a\nmetadata exchange way (for instance, current analogue gain, shutter time,\nor red/blue gains calculated in the AWB algorithm from AGC, etc.).\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 2 +-\n src/ipa/ipu3/ipu3_awb.cpp | 5 +++++\n src/ipa/ipu3/ipu3_awb.h | 3 ++-\n 3 files changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex f43f8620..4466391a 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -296,7 +296,7 @@ void IPAIPU3::parseStatistics(unsigned int frame,\n \tagcAlgo_->process(stats, exposure_, gain);\n \tgain_ = camHelper_->gainCode(gain);\n \n-\tawbAlgo_->calculateWBGains(stats);\n+\tawbAlgo_->process(stats);\n \n \tif (agcAlgo_->updateControls())\n \t\tsetControls(frame);\ndiff --git a/src/ipa/ipu3/ipu3_awb.cpp b/src/ipa/ipu3/ipu3_awb.cpp\nindex 9b409c8f..a94935c5 100644\n--- a/src/ipa/ipu3/ipu3_awb.cpp\n+++ b/src/ipa/ipu3/ipu3_awb.cpp\n@@ -351,6 +351,11 @@ void IPU3Awb::calculateWBGains(const ipu3_uapi_stats_3a *stats)\n \t}\n }\n \n+void IPU3Awb::process(const ipu3_uapi_stats_3a *stats)\n+{\n+\tcalculateWBGains(stats);\n+}\n+\n void IPU3Awb::updateWbParameters(ipu3_uapi_params ¶ms, double agcGamma)\n {\n \t/*\ndiff --git a/src/ipa/ipu3/ipu3_awb.h b/src/ipa/ipu3/ipu3_awb.h\nindex f4100f4a..795e32e3 100644\n--- a/src/ipa/ipu3/ipu3_awb.h\n+++ b/src/ipa/ipu3/ipu3_awb.h\n@@ -33,7 +33,7 @@ public:\n \t~IPU3Awb();\n \n \tvoid initialise(ipu3_uapi_params ¶ms, const Size &bdsOutputSize, struct ipu3_uapi_grid_config &bdsGrid);\n-\tvoid calculateWBGains(const ipu3_uapi_stats_3a *stats);\n+\tvoid process(const ipu3_uapi_stats_3a *stats);\n \tvoid updateWbParameters(ipu3_uapi_params ¶ms, double agcGamma);\n \n private:\n@@ -42,6 +42,7 @@ private:\n \tvoid clearAwbStats();\n \tvoid awbGreyWorld();\n \tuint32_t estimateCCT(double red, double green, double blue);\n+\tvoid calculateWBGains(const ipu3_uapi_stats_3a *stats);\n \n \tstruct ipu3_uapi_grid_config awbGrid_;\n \n", "prefixes": [ "libcamera-devel", "v1", "4/7" ] }