Patch Detail
Show a patch.
GET /api/1.1/patches/12726/?format=api
{ "id": 12726, "url": "https://patchwork.libcamera.org/api/1.1/patches/12726/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12726/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210628122324.14541-4-david.plowman@raspberrypi.com>", "date": "2021-06-28T12:23:24", "name": "[libcamera-devel,v4,3/3] libcamera: ipa: raspberrypi: Add support for ov9281 sensor", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5fcfe3ee3a3bebc43283b6745ed7c6cba3569858", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12726/mbox/", "series": [ { "id": 2184, "url": "https://patchwork.libcamera.org/api/1.1/series/2184/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2184", "date": "2021-06-28T12:23:21", "name": "Support monochrome raw sensors", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2184/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12726/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12726/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2B5ADC3220\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 28 Jun 2021 12:23:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E1A3B684D9;\n\tMon, 28 Jun 2021 14:23:31 +0200 (CEST)", "from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com\n\t[IPv6:2a00:1450:4864:20::32e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2B2A1684D6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 28 Jun 2021 14:23:28 +0200 (CEST)", "by mail-wm1-x32e.google.com with SMTP id\n\tv20-20020a05600c2154b02901dcefb16af0so11035937wml.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 28 Jun 2021 05:23:28 -0700 (PDT)", "from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:1ce1:9965:4328:89c4])\n\tby smtp.gmail.com with ESMTPSA id\n\ts62sm19606542wms.13.2021.06.28.05.23.27\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 28 Jun 2021 05:23:27 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"XYbTlbAA\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=cI1Bogz/D11yXqXoXsnxUcCBS7ZdZXJpXnGGD6l2Ekk=;\n\tb=XYbTlbAA7zuVLJLSGbk85QaxOL1QVOszocd6TbZaqFRk970jwI1kLrkBUl5MN8dGJA\n\t8tfhJ2mXcvPkYU6kc/21jA5mB/8VZY0N6U7eBkSB1nqxv54fvTW1+nPunOPAMPUbms1i\n\tdghi1rDpWgclX+iTAVVgF5yPDFV2kju48rbQ3eoICthrSnHn2eD/IwyfihknW0BHOJ1V\n\tiHviEPdiPKcOixibb/62GOFMEeMXPrlQrZreV0k6mKQNwRhrgNPjTYdebeaNGOYsfp5j\n\tRme5RagR67wWWsRC8Jqc+aNPpg4pYSl59KpXBBccnAAy3pU9Bq6tZJVNVMAa6exXVpv2\n\t9Yrw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=cI1Bogz/D11yXqXoXsnxUcCBS7ZdZXJpXnGGD6l2Ekk=;\n\tb=mT8lgtf7wrLCvenH7u2R+/lVldtSg+kBqVsMo/UhL52Yum2smvtsTpcg7RW/HrSt+q\n\t49NuJooPdyhU04w2exYFc7TkNtLBib4X071iGzOX52Ku9BSF0L/S6+UOEqmlnIbP6pJs\n\tGtOqSMNMToiYj3Gk4G61jByfpe4rLpVt70bE6CdwWf+0zCRqagFVEkfbHQz283UEwozC\n\tQELY58VpSotKQ9JgnOcvW+P21X7Yx08rrPFg1QeDgaF4tIMxeX5yPXAUEqDSSdMTup6E\n\t173hACs+usXP23qdwPNCBRODWKmBpCSskHGH/GBtCf5tkG2huUpGP2c2ClpUAQ4WyzdY\n\tB/+w==", "X-Gm-Message-State": "AOAM531oP0T0bdY3pnszKxlHRU5MhdYA6BAXwYO/i3vIBoW9Cg3CJohl\n\tSUt1z/0raicMBnJN+u+tCNY5ASnlA5qneA==", "X-Google-Smtp-Source": "ABdhPJxaY+GBy/0/wN8u6hniFGKql8z1A5WdgMnuoYzMGp3iE20VkZXcvnO/xejgd1qzoxPlpFX1gQ==", "X-Received": "by 2002:a7b:cb03:: with SMTP id\n\tu3mr26866640wmj.119.1624883007696; \n\tMon, 28 Jun 2021 05:23:27 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 28 Jun 2021 13:23:24 +0100", "Message-Id": "<20210628122324.14541-4-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20210628122324.14541-1-david.plowman@raspberrypi.com>", "References": "<20210628122324.14541-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 3/3] libcamera: ipa: raspberrypi: Add\n\tsupport for ov9281 sensor", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The necessary tuning file and CamHelper is added for the ov9281 sensor.\n\nThe ov9281 is a 1280x800 monochrome global shutter sensor. To enable\nit, please add\n\ndtoverlay=ov9281\n\nto the /boot/config.txt file and reboot the Pi.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/raspberrypi/cam_helper_ov9281.cpp | 65 ++++++++++++++++\n src/ipa/raspberrypi/data/meson.build | 1 +\n src/ipa/raspberrypi/data/ov9281.json | 92 +++++++++++++++++++++++\n src/ipa/raspberrypi/meson.build | 1 +\n 4 files changed, 159 insertions(+)\n create mode 100644 src/ipa/raspberrypi/cam_helper_ov9281.cpp\n create mode 100644 src/ipa/raspberrypi/data/ov9281.json", "diff": "diff --git a/src/ipa/raspberrypi/cam_helper_ov9281.cpp b/src/ipa/raspberrypi/cam_helper_ov9281.cpp\nnew file mode 100644\nindex 00000000..54091f83\n--- /dev/null\n+++ b/src/ipa/raspberrypi/cam_helper_ov9281.cpp\n@@ -0,0 +1,65 @@\n+/* SPDX-License-Identifier: BSD-2-Clause */\n+/*\n+ * Copyright (C) 2021, Raspberry Pi (Trading) Limited\n+ *\n+ * cam_helper_ov9281.cpp - camera information for ov9281 sensor\n+ */\n+\n+#include <assert.h>\n+\n+#include \"cam_helper.hpp\"\n+\n+using namespace RPiController;\n+\n+class CamHelperOv9281 : public CamHelper\n+{\n+public:\n+\tCamHelperOv9281();\n+\tuint32_t GainCode(double gain) const override;\n+\tdouble Gain(uint32_t gain_code) const override;\n+\tvoid GetDelays(int &exposure_delay, int &gain_delay,\n+\t\t int &vblank_delay) const override;\n+\n+private:\n+\t/*\n+\t * Smallest difference between the frame length and integration time,\n+\t * in units of lines.\n+\t */\n+\tstatic constexpr int frameIntegrationDiff = 4;\n+};\n+\n+/*\n+ * OV9281 doesn't output metadata, so we have to use the \"unicam parser\" which\n+ * works by counting frames.\n+ */\n+\n+CamHelperOv9281::CamHelperOv9281()\n+\t: CamHelper(nullptr, frameIntegrationDiff)\n+{\n+}\n+\n+uint32_t CamHelperOv9281::GainCode(double gain) const\n+{\n+\treturn static_cast<uint32_t>(gain * 16.0);\n+}\n+\n+double CamHelperOv9281::Gain(uint32_t gain_code) const\n+{\n+\treturn static_cast<double>(gain_code) / 16.0;\n+}\n+\n+void CamHelperOv9281::GetDelays(int &exposure_delay, int &gain_delay,\n+\t\t\t\tint &vblank_delay) const\n+{\n+\t/* The driver appears to behave as follows: */\n+\texposure_delay = 2;\n+\tgain_delay = 2;\n+\tvblank_delay = 2;\n+}\n+\n+static CamHelper *Create()\n+{\n+\treturn new CamHelperOv9281();\n+}\n+\n+static RegisterCamHelper reg(\"ov9281\", &Create);\ndiff --git a/src/ipa/raspberrypi/data/meson.build b/src/ipa/raspberrypi/data/meson.build\nindex 92ad3272..adf89dbd 100644\n--- a/src/ipa/raspberrypi/data/meson.build\n+++ b/src/ipa/raspberrypi/data/meson.build\n@@ -4,6 +4,7 @@ conf_files = files([\n 'imx219.json',\n 'imx290.json',\n 'imx477.json',\n+ 'ov9281.json',\n 'ov5647.json',\n 'se327m12.json',\n 'uncalibrated.json',\ndiff --git a/src/ipa/raspberrypi/data/ov9281.json b/src/ipa/raspberrypi/data/ov9281.json\nnew file mode 100644\nindex 00000000..ecd262be\n--- /dev/null\n+++ b/src/ipa/raspberrypi/data/ov9281.json\n@@ -0,0 +1,92 @@\n+{\n+ \"rpi.black_level\":\n+ {\n+ \"black_level\": 4096\n+ },\n+ \"rpi.lux\":\n+ {\n+ \"reference_shutter_speed\": 2000,\n+ \"reference_gain\": 1.0,\n+ \"reference_aperture\": 1.0,\n+ \"reference_lux\": 800,\n+ \"reference_Y\": 20000\n+ },\n+ \"rpi.noise\":\n+ {\n+ \"reference_constant\": 0,\n+ \"reference_slope\": 2.5\n+ },\n+ \"rpi.sdn\":\n+ {\n+ },\n+ \"rpi.agc\":\n+ {\n+ \"metering_modes\":\n+ {\n+ \"centre-weighted\": {\n+ \"weights\": [4, 4, 4, 2, 2, 2, 2, 1, 1, 1, 1, 0, 0, 0, 0]\n+ }\n+ },\n+ \"exposure_modes\":\n+ {\n+ \"normal\":\n+ {\n+ \"shutter\": [ 100, 15000, 30000, 60000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 3.0, 4.0, 6.0 ]\n+ }\n+ },\n+ \"constraint_modes\":\n+ {\n+ \"normal\":\n+ [\n+ { \"bound\": \"LOWER\", \"q_lo\": 0.98, \"q_hi\": 1.0, \"y_target\": [ 0, 0.4, 1000, 0.4 ] }\n+ ]\n+ },\n+ \"y_target\": [ 0, 0.16, 1000, 0.165, 10000, 0.17 ]\n+ },\n+ \"rpi.alsc\":\n+ {\n+ \"n_iter\": 0,\n+ \"luminance_strength\": 1.0,\n+ \"corner_strength\": 1.5\n+ },\n+ \"rpi.contrast\":\n+ {\n+ \"ce_enable\": 0,\n+ \"gamma_curve\": [\n+ 0, 0,\n+ 1024, 5040,\n+ 2048, 9338,\n+ 3072, 12356,\n+ 4096, 15312,\n+ 5120, 18051,\n+ 6144, 20790,\n+ 7168, 23193,\n+ 8192, 25744,\n+ 9216, 27942,\n+ 10240, 30035,\n+ 11264, 32005,\n+ 12288, 33975,\n+ 13312, 35815,\n+ 14336, 37600,\n+ 15360, 39168,\n+ 16384, 40642,\n+ 18432, 43379,\n+ 20480, 45749,\n+ 22528, 47753,\n+ 24576, 49621,\n+ 26624, 51253,\n+ 28672, 52698,\n+ 30720, 53796,\n+ 32768, 54876,\n+ 36864, 57012,\n+ 40960, 58656,\n+ 45056, 59954,\n+ 49152, 61183,\n+ 53248, 62355,\n+ 57344, 63419,\n+ 61440, 64476,\n+ 65535, 65535\n+ ]\n+ }\n+}\ndiff --git a/src/ipa/raspberrypi/meson.build b/src/ipa/raspberrypi/meson.build\nindex 230356d3..714ac27e 100644\n--- a/src/ipa/raspberrypi/meson.build\n+++ b/src/ipa/raspberrypi/meson.build\n@@ -22,6 +22,7 @@ rpi_ipa_sources = files([\n 'cam_helper_imx219.cpp',\n 'cam_helper_imx290.cpp',\n 'cam_helper_imx477.cpp',\n+ 'cam_helper_ov9281.cpp',\n 'controller/controller.cpp',\n 'controller/histogram.cpp',\n 'controller/algorithm.cpp',\n", "prefixes": [ "libcamera-devel", "v4", "3/3" ] }