Patch Detail
Show a patch.
GET /api/1.1/patches/12720/?format=api
{ "id": 12720, "url": "https://patchwork.libcamera.org/api/1.1/patches/12720/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12720/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210628085630.2081-2-david.plowman@raspberrypi.com>", "date": "2021-06-28T08:56:29", "name": "[libcamera-devel,1/2] libcamera: camera: add a mode sensitivity field", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "93bba9947e1486a72f329e099029d55a1ea6f31b", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12720/mbox/", "series": [ { "id": 2183, "url": "https://patchwork.libcamera.org/api/1.1/series/2183/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2183", "date": "2021-06-28T08:56:29", "name": "Application support for per-mode sensitivities", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2183/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12720/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12720/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 60228C321F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 28 Jun 2021 08:56:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A6C31684DA;\n\tMon, 28 Jun 2021 10:56:34 +0200 (CEST)", "from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EDF6E684D3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 28 Jun 2021 10:56:32 +0200 (CEST)", "by mail-wm1-x329.google.com with SMTP id w13so10869232wmc.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 28 Jun 2021 01:56:32 -0700 (PDT)", "from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:1ce1:9965:4328:89c4])\n\tby smtp.gmail.com with ESMTPSA id\n\tg7sm10578243wmq.27.2021.06.28.01.56.32\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 28 Jun 2021 01:56:32 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"N36mUbQH\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=sowNw/qaIjLQtmQOw1xULSjivxaJNp/QUhd2EfpMn8E=;\n\tb=N36mUbQHe8pAE5SF0BLTZU7KMAInBEnJn8YbEeW+Gld1HV1H48pD/QPaPGHAptxncF\n\tRMSbUKP7wi3aqtDSj0MHuNsf9MmxEi2nPl/3S1ImYPUyLpjXCuUp6uGkSF/7iAKizVjW\n\tLujCizuzXKDk4rv9Fk7x+mLVmJZDcAxcfQFmppLqzaGDtEOd9DYza/eEdlxR+a8cOBNg\n\tOUfq0O5SvHyTSrfZJSW2dWg7cEEbgPgvcBPjT1GyxTI+Lqn1ZvCNsvMkq58NCr5yEds8\n\tCR9KsSquGLIJttBPwUtMo3LM9E2nki/J9pMkG7fCwqUxb5j3j0/O1ypL0RaXME6Af+aK\n\t9hZw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=sowNw/qaIjLQtmQOw1xULSjivxaJNp/QUhd2EfpMn8E=;\n\tb=jHun08BZCqJivYLYPriSe80FcwVRa/rPScddyqLYQeGbPpeG6CETss22k3KLJjqZDV\n\talDmQLf62ntW7gegCYxrXtEGrO8HkClvlJZM5KYtYeN7addC0ztL8sSAqON9DNQF09Em\n\tcu1/H9m1HPI9TjXznxam9tUymHrH3kVH9seWaO50I8qfG781FlWpVZdA/1KiDvYU8aXb\n\tIz5mohl3QeapjQAnMgbrTQUme9f2w2RGREwJHNV004W7mC3Bcf2D7QU5hl9vk6KQfRAB\n\tiEQkwN6V2LlaSiUSXtB2qnBFgvhytYKKRdnWRPpTB9uhJanDSa12fRaua/evGkNndtVG\n\tN6ig==", "X-Gm-Message-State": "AOAM530rA8oE4XRL6gU6CjsAA0RAhbGdt4Z+SId7CRGZdbSnUURXHK2N\n\tp/vEbb75DwuQwy2/TH4MV86CCm3JvoEvng==", "X-Google-Smtp-Source": "ABdhPJzlGz/huVVbAM5fQACVw5Xzes6ZdnlFuokcJkR/qgIe318E62Cw4xVNI2uYmZhC8M0rm9Xgxw==", "X-Received": "by 2002:a1c:4cd:: with SMTP id 196mr5282435wme.145.1624870592475;\n\tMon, 28 Jun 2021 01:56:32 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 28 Jun 2021 09:56:29 +0100", "Message-Id": "<20210628085630.2081-2-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20210628085630.2081-1-david.plowman@raspberrypi.com>", "References": "<20210628085630.2081-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/2] libcamera: camera: add a mode\n\tsensitivity field", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The modeSensitivity field is a number that describes how sensitive the\nselected sensor mode is compared to other readout modes of the same\nsensor. For example, a binned mode might have twice the sensitivity of\nthe full resolution mode, meaning you would get double the signal\nlevel for the same exposure and gains.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n include/libcamera/camera.h | 2 ++\n src/libcamera/camera.cpp | 16 +++++++++++++++-\n 2 files changed, 17 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\nindex d7164180..85f7f999 100644\n--- a/include/libcamera/camera.h\n+++ b/include/libcamera/camera.h\n@@ -65,6 +65,8 @@ public:\n \n \tTransform transform;\n \n+\tfloat modeSensitivity;\n+\n protected:\n \tCameraConfiguration();\n \ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 1340c266..6b3627b6 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -154,7 +154,7 @@ LOG_DECLARE_CATEGORY(Camera)\n * \\brief Create an empty camera configuration\n */\n CameraConfiguration::CameraConfiguration()\n-\t: transform(Transform::Identity), config_({})\n+\t: transform(Transform::Identity), modeSensitivity(1.0), config_({})\n {\n }\n \n@@ -325,6 +325,20 @@ std::size_t CameraConfiguration::size() const\n * may adjust this field at its discretion if the selection is not supported.\n */\n \n+/**\n+ * \\var CameraConfiguration::modeSensitivity\n+ * \\brief The relative sensitivity of the chosen sensor mode\n+ *\n+ * Some sensors have readout modes with different sensitivities. For example,\n+ * a binned camera mode might, with the same exposure and gains, produce\n+ * twice the signal level of the full resolution readout. This would be\n+ * signalled by the binned mode, when it is chosen, indicating a value here\n+ * that is twice that of the full resolution mode.\n+ *\n+ * This value should only be read, and not set, by the user. It will be\n+ * valid after the configure method has reteurned successfully.\n+ */\n+\n /**\n * \\var CameraConfiguration::config_\n * \\brief The vector of stream configurations\n", "prefixes": [ "libcamera-devel", "1/2" ] }