Patch Detail
Show a patch.
GET /api/1.1/patches/12718/?format=api
{ "id": 12718, "url": "https://patchwork.libcamera.org/api/1.1/patches/12718/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12718/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210627191937.14030-1-laurent.pinchart@ideasonboard.com>", "date": "2021-06-27T19:19:37", "name": "[libcamera-devel] libcamera: pipeline: simple: Log pipeline topology", "commit_ref": "535820fe51ac9881ae3562ffd4a69ef3359f85f6", "pull_url": null, "state": "accepted", "archived": false, "hash": "6c33cea4c79e3d48d8a5bf137894233fb328e663", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12718/mbox/", "series": [ { "id": 2181, "url": "https://patchwork.libcamera.org/api/1.1/series/2181/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2181", "date": "2021-06-27T19:19:37", "name": "[libcamera-devel] libcamera: pipeline: simple: Log pipeline topology", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2181/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12718/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12718/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BD991C321D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 27 Jun 2021 19:20:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EFAE2684D5;\n\tSun, 27 Jun 2021 21:20:14 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 46162684D0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 27 Jun 2021 21:20:13 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C005729A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 27 Jun 2021 21:20:12 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wkdvOrA9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624821612;\n\tbh=JPEkb7btDeSU4SPSqHW4FkFc2lGNpI7nvAicbZ/m96E=;\n\th=From:To:Subject:Date:From;\n\tb=wkdvOrA9uK+Mp+OQLkX2trqx9inR+5/ShVCHsnFtlVMXMnLMOYJ7J3Qr4fowiZp+2\n\tnQ/OkAuXUG1GFwJLWuKIgOGeejAxoIySUeHOTJGpRNBa+jNE9Xr+ZU92PO32TbZPib\n\teKO9f1EZZtRAPkSOz6Gs2wkm6PFnxc8f/+DWSEVg=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 27 Jun 2021 22:19:37 +0300", "Message-Id": "<20210627191937.14030-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: pipeline: simple: Log pipeline\n\ttopology", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Log the topology for each valid discovered pipeline to aid debugging.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 6ed3da423432..e214a7eb3a47 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -342,8 +342,15 @@ SimpleCameraData::SimpleCameraData(SimplePipelineHandler *pipe,\n \t/* Finally also remember the sensor. */\n \tsensor_ = std::make_unique<CameraSensor>(sensor);\n \tret = sensor_->init();\n-\tif (ret)\n+\tif (ret) {\n \t\tsensor_.reset();\n+\t\treturn;\n+\t}\n+\n+\tLOG(SimplePipeline, Debug)\n+\t\t<< \"Found pipeline: \"\n+\t\t<< utils::join(entities_, \" -> \",\n+\t\t\t [](const Entity &e) { return e.entity->name(); });\n }\n \n int SimpleCameraData::init()\n", "prefixes": [ "libcamera-devel" ] }