Patch Detail
Show a patch.
GET /api/1.1/patches/12716/?format=api
{ "id": 12716, "url": "https://patchwork.libcamera.org/api/1.1/patches/12716/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12716/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210625220554.1261-1-laurent.pinchart@ideasonboard.com>", "date": "2021-06-25T22:05:54", "name": "[libcamera-devel] libcamera: device_enumerator: Fix include order for internal headers", "commit_ref": "9fcef36be69fe2c6842680ec78c432cbdbbdc92d", "pull_url": null, "state": "accepted", "archived": false, "hash": "c0b4b4cf5ec1025772abcc5e683cd42fed08c440", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12716/mbox/", "series": [ { "id": 2179, "url": "https://patchwork.libcamera.org/api/1.1/series/2179/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2179", "date": "2021-06-25T22:05:54", "name": "[libcamera-devel] libcamera: device_enumerator: Fix include order for internal headers", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2179/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12716/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12716/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1EC11C321D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 25 Jun 2021 22:06:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C385684D5;\n\tSat, 26 Jun 2021 00:06:31 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A4E466028E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 26 Jun 2021 00:06:28 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2B97B3E5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 26 Jun 2021 00:06:28 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FwK5yUJi\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624658788;\n\tbh=ha89l94IloJ7Jaaah/EGS7VBD0+lK4uDR5Bc9Vxs/tY=;\n\th=From:To:Subject:Date:From;\n\tb=FwK5yUJiltL/yee+FK5LApcVl6Q/Z/K9dAvicebsT5+iHAdaXOFLKp3X2+ubAB7tL\n\tl9HHqjE8cKj8dx5T0COhKFUyH2DOs+D2GlWedycShp+aSA4z0l3Ljpk8i7sWghIyjO\n\t0wVCI+ezR85WXtYD8K+GN+6X/wdDciAI0XDfFsdw=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 26 Jun 2021 01:05:54 +0300", "Message-Id": "<20210625220554.1261-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: device_enumerator: Fix include\n\torder for internal headers", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The device_enumerator_sysfs.h and device_enumerator_udev.h internal\nheaders are not at the correct location. Fix it.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/device_enumerator.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\nindex 1f33faf5e7aa..cfd1e6b22f64 100644\n--- a/src/libcamera/device_enumerator.cpp\n+++ b/src/libcamera/device_enumerator.cpp\n@@ -6,13 +6,13 @@\n */\n \n #include \"libcamera/internal/device_enumerator.h\"\n-#include \"libcamera/internal/device_enumerator_sysfs.h\"\n-#include \"libcamera/internal/device_enumerator_udev.h\"\n \n #include <string.h>\n \n #include <libcamera/base/log.h>\n \n+#include \"libcamera/internal/device_enumerator_sysfs.h\"\n+#include \"libcamera/internal/device_enumerator_udev.h\"\n #include \"libcamera/internal/media_device.h\"\n \n /**\n", "prefixes": [ "libcamera-devel" ] }