Patch Detail
Show a patch.
GET /api/1.1/patches/12640/?format=api
{ "id": 12640, "url": "https://patchwork.libcamera.org/api/1.1/patches/12640/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12640/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210618103351.1642060-8-paul.elder@ideasonboard.com>", "date": "2021-06-18T10:33:44", "name": "[libcamera-devel,RFC,07/14] android: Plumb AeLock control", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "629b1e42c01fe154e0fb2e8981581b596dc00e40", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/12640/mbox/", "series": [ { "id": 2151, "url": "https://patchwork.libcamera.org/api/1.1/series/2151/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2151", "date": "2021-06-18T10:33:37", "name": "Preliminary FULL plumbing", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2151/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12640/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12640/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5273ABD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 18 Jun 2021 10:34:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A87068941;\n\tFri, 18 Jun 2021 12:34:15 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C81AD6050D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Jun 2021 12:34:13 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 55AB53E5;\n\tFri, 18 Jun 2021 12:34:12 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wajXb/4m\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624012453;\n\tbh=Xfz2OpTDCUs+50XQINHBJZ7KpMgvnqI94HKP2zqkQk8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=wajXb/4mz7+ZuFV9VZRUZZ2eBjO+Yne73uQBn/AUaQJvSKa1w3idApOkFsF36J+kc\n\t6kn3k05EfVgznFk7sitQ5gCY2DLao47DMnMGsF3yX23RyXcpb03cwBajjXb48lsi0b\n\tRtPHKTHLx5mKiIa8lDyfwzJWx/KVTogQEawHLFL4=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 18 Jun 2021 19:33:44 +0900", "Message-Id": "<20210618103351.1642060-8-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210618103351.1642060-1-paul.elder@ideasonboard.com>", "References": "<20210618103351.1642060-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH 07/14] android: Plumb AeLock control", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Plumb the AeLock control into the HAL for\nCONTROL_AE_LOCK_AVAILABLE_MODES for static metadata.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=43\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nTODO: plumb result metadata\n---\n src/android/camera_device.cpp | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 3446cdb6..3add5bc6 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1010,6 +1010,14 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\t\t\t sceneModesOverride);\n \n \tuint8_t aeLockAvailable = ANDROID_CONTROL_AE_LOCK_AVAILABLE_FALSE;\n+\tconst auto &aeLockInfo = controlsInfo.find(&controls::AeLock);\n+\tif (aeLockInfo != controlsInfo.end()) {\n+\t\taeLockAvailable = aeLockInfo->second.max().get<bool>();\n+\t}\n+\tif (!aeLockAvailable) {\n+\t\tcapabilities[ANDROID_REQUEST_AVAILABLE_CAPABILITIES_BURST_CAPTURE] = false;\n+\t\tcapabilities[ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_SENSOR] = false;\n+\t}\n \tstaticMetadata_->addEntry(ANDROID_CONTROL_AE_LOCK_AVAILABLE,\n \t\t\t\t aeLockAvailable);\n \n", "prefixes": [ "libcamera-devel", "RFC", "07/14" ] }