Patch Detail
Show a patch.
GET /api/1.1/patches/12618/?format=api
{ "id": 12618, "url": "https://patchwork.libcamera.org/api/1.1/patches/12618/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12618/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210616151152.3856595-3-kieran.bingham@ideasonboard.com>", "date": "2021-06-16T15:11:48", "name": "[libcamera-devel,2/6] libcamera-platform: Introduce new platform library", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a52e25816599b1cc6b799603223ee94edb6d339b", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12618/mbox/", "series": [ { "id": 2143, "url": "https://patchwork.libcamera.org/api/1.1/series/2143/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2143", "date": "2021-06-16T15:11:46", "name": "libcamera-platform: Split library functionality", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2143/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12618/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12618/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DDE0FC3219\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 16 Jun 2021 15:12:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7D64668949;\n\tWed, 16 Jun 2021 17:11:59 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B781168941\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 16 Jun 2021 17:11:57 +0200 (CEST)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5B6231163;\n\tWed, 16 Jun 2021 17:11:57 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"k194kQ/N\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1623856317;\n\tbh=oFa64UnUKFy+cnb8ZnQCSyma73A8i9CM9UmBmcxcRqg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=k194kQ/NqPQJueYBWzj08oaAReg/a/frBX8xIjNrekzEJxAgro/NEC7VUiWCBYgU2\n\tUo8zsJSI4LkLgDg3O8yfOh/0CxWcfFXlxClP9SFGanTPdrahxvU9jSHTdk6S4tAjwl\n\tHqQJXizGgLWrtYIWA9JxOhXe7L/s1rLrv29fFhag=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Wed, 16 Jun 2021 16:11:48 +0100", "Message-Id": "<20210616151152.3856595-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210616151152.3856595-1-kieran.bingham@ideasonboard.com>", "References": "<20210616151152.3856595-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/6] libcamera-platform: Introduce new\n\tplatform library", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The libcamera-platform.so will feature internal support functionality\nthat is utilised by libcamera, and can be shared in other places.\n\nHowever - the libcamera-platform library does not constitute a part\nof the public libcamera API directly. It is a layer beneath libcamera\nwhich provides common abstractions to internal objects.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n Documentation/Doxyfile.in | 4 +++-\n Documentation/meson.build | 2 ++\n include/libcamera/meson.build | 1 +\n include/libcamera/platform/meson.build | 9 ++++++++\n src/libcamera-platform/meson.build | 29 ++++++++++++++++++++++++++\n src/libcamera/meson.build | 2 ++\n src/meson.build | 1 +\n 7 files changed, 47 insertions(+), 1 deletion(-)\n create mode 100644 include/libcamera/platform/meson.build\n create mode 100644 src/libcamera-platform/meson.build", "diff": "diff --git a/Documentation/Doxyfile.in b/Documentation/Doxyfile.in\nindex 8305f56af7a8..c1b395bf0b83 100644\n--- a/Documentation/Doxyfile.in\n+++ b/Documentation/Doxyfile.in\n@@ -791,8 +791,10 @@ WARN_LOGFILE =\n INPUT = \"@TOP_SRCDIR@/include/libcamera\" \\\n \t\t\t \"@TOP_SRCDIR@/src/ipa/libipa\" \\\n \t\t\t \"@TOP_SRCDIR@/src/libcamera\" \\\n+\t\t\t \"@TOP_SRCDIR@/src/libcamera-platform\" \\\n \t\t\t \"@TOP_BUILDDIR@/include/libcamera\" \\\n-\t\t\t \"@TOP_BUILDDIR@/src/libcamera\"\n+\t\t\t \"@TOP_BUILDDIR@/src/libcamera\" \\\n+\t\t\t \"@TOP_BUILDDIR@/src/libcamera-platform\"\n \n # This tag can be used to specify the character encoding of the source files\n # that doxygen parses. Internally doxygen uses the UTF-8 encoding. Doxygen uses\ndiff --git a/Documentation/meson.build b/Documentation/meson.build\nindex 9ecf4dfcf79f..01b753f07fb6 100644\n--- a/Documentation/meson.build\n+++ b/Documentation/meson.build\n@@ -27,6 +27,8 @@ if doxygen.found() and dot.found()\n libcamera_ipa_interfaces,\n libcamera_public_headers,\n libcamera_sources,\n+ libcamera_platform_headers,\n+ libcamera_platform_sources,\n libipa_headers,\n libipa_sources,\n ],\ndiff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\nindex 086c958b0a53..2c3bbeb8df36 100644\n--- a/include/libcamera/meson.build\n+++ b/include/libcamera/meson.build\n@@ -25,6 +25,7 @@ include_dir = libcamera_include_dir / 'libcamera'\n \n subdir('internal')\n subdir('ipa')\n+subdir('platform')\n \n install_headers(libcamera_public_headers,\n subdir : include_dir)\ndiff --git a/include/libcamera/platform/meson.build b/include/libcamera/platform/meson.build\nnew file mode 100644\nindex 000000000000..c8e0d0c5ba12\n--- /dev/null\n+++ b/include/libcamera/platform/meson.build\n@@ -0,0 +1,9 @@\n+# SPDX-License-Identifier: CC0-1.0\n+\n+libcamera_platform_include_dir = libcamera_include_dir / 'platform'\n+\n+libcamera_platform_headers = files([\n+])\n+\n+install_headers(libcamera_platform_headers,\n+ subdir: libcamera_platform_include_dir)\ndiff --git a/src/libcamera-platform/meson.build b/src/libcamera-platform/meson.build\nnew file mode 100644\nindex 000000000000..64d0dfee2731\n--- /dev/null\n+++ b/src/libcamera-platform/meson.build\n@@ -0,0 +1,29 @@\n+# SPDX-License-Identifier: CC0-1.0\n+\n+libcamera_platform_sources = files([\n+])\n+\n+libcamera_platform_deps = [\n+]\n+\n+libcamera_platform_lib = shared_library('libcamera_platform',\n+ [libcamera_platform_sources, libcamera_platform_headers],\n+ name_prefix : '',\n+ install : true,\n+ cpp_args : libcamera_cpp_args,\n+ include_directories : libcamera_includes,\n+ dependencies : libcamera_platform_deps)\n+\n+libcamera_platform = declare_dependency(sources : [\n+ libcamera_platform_headers,\n+ ],\n+ include_directories : libcamera_includes,\n+ link_with : libcamera_platform_lib)\n+\n+pkg_mod = import('pkgconfig')\n+pkg_mod.generate(libraries : libcamera_platform_lib,\n+ version : '1.0',\n+ name : 'libcamera-platform',\n+ filebase : 'camera-platform',\n+ description : 'Complex Camera Support Library',\n+ subdirs : 'libcamera')\ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 54512652272c..6ba59e4006cb 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -127,6 +127,7 @@ libcamera_deps = [\n libgnutls,\n liblttng,\n libudev,\n+ libcamera_platform,\n dependency('threads'),\n ]\n \n@@ -156,6 +157,7 @@ libcamera_dep = declare_dependency(sources : [\n libcamera_generated_ipa_headers,\n ],\n include_directories : libcamera_includes,\n+ dependencies: libcamera_platform,\n link_with : libcamera)\n \n subdir('proxy/worker')\ndiff --git a/src/meson.build b/src/meson.build\nindex a4e96ecd728a..70e1a4618a0f 100644\n--- a/src/meson.build\n+++ b/src/meson.build\n@@ -29,6 +29,7 @@ libcamera_cpp_args = []\n libcamera_objects = []\n \n # libcamera must be built first as a dependency to the other components.\n+subdir('libcamera-platform')\n subdir('libcamera')\n \n subdir('android')\n", "prefixes": [ "libcamera-devel", "2/6" ] }