Patch Detail
Show a patch.
GET /api/1.1/patches/12616/?format=api
{ "id": 12616, "url": "https://patchwork.libcamera.org/api/1.1/patches/12616/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12616/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210616143430.3826175-1-kieran.bingham@ideasonboard.com>", "date": "2021-06-16T14:34:30", "name": "[libcamera-devel,v2] libcamera: pipeline: vimc: Fail without an IPA", "commit_ref": "5db033f0e7d4fd1b27422a74f6b3442affe13adc", "pull_url": null, "state": "accepted", "archived": false, "hash": "516a2ee36e91fd2aba374a5b343a5dae9536bc21", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12616/mbox/", "series": [ { "id": 2142, "url": "https://patchwork.libcamera.org/api/1.1/series/2142/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2142", "date": "2021-06-16T14:34:30", "name": "[libcamera-devel,v2] libcamera: pipeline: vimc: Fail without an IPA", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2142/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12616/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12616/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1320BD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 16 Jun 2021 14:34:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B2606029A;\n\tWed, 16 Jun 2021 16:34:35 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 329B66029A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 16 Jun 2021 16:34:34 +0200 (CEST)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C758B3E5;\n\tWed, 16 Jun 2021 16:34:33 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uuiaxf/8\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1623854074;\n\tbh=v2ylNFep2roJpy+OcijcOLKwsjtEJEOUXxoeHuyO9DQ=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=uuiaxf/8KbjMQB05Pvh/AJVAyJkfBsCuFz8fsyQLX91vQzBdXgMQxONC+85jF/QVj\n\trRci0PjryiNhg37rA4r09iGdJTlv6VZSDUhsWCSKQe30YM9NruOIqOGDr8lZQnfFDl\n\tCCxWAEwCrx0/XBPw6sRKYzNP29djvADasIuJ+ogs=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Wed, 16 Jun 2021 15:34:30 +0100", "Message-Id": "<20210616143430.3826175-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2] libcamera: pipeline: vimc: Fail\n\twithout an IPA", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The IPA is required for VIMC so fail early if it can't be loaded.\n\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/vimc/vimc.cpp | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nindex 1713dc0ca932..1c4135cc6daa 100644\n--- a/src/libcamera/pipeline/vimc/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc/vimc.cpp\n@@ -427,13 +427,14 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n \t\treturn false;\n \n \tdata->ipa_ = IPAManager::createIPA<ipa::vimc::IPAProxyVimc>(this, 0, 0);\n-\tif (data->ipa_ != nullptr) {\n-\t\tstd::string conf = data->ipa_->configurationFile(\"vimc.conf\");\n-\t\tdata->ipa_->init(IPASettings{ conf, data->sensor_->model() });\n-\t} else {\n-\t\tLOG(VIMC, Warning) << \"no matching IPA found\";\n+\tif (!data->ipa_) {\n+\t\tLOG(VIMC, Error) << \"no matching IPA found\";\n+\t\treturn false;\n \t}\n \n+\tstd::string conf = data->ipa_->configurationFile(\"vimc.conf\");\n+\tdata->ipa_->init(IPASettings{ conf, data->sensor_->model() });\n+\n \t/* Create and register the camera. */\n \tstd::set<Stream *> streams{ &data->stream_ };\n \tstd::shared_ptr<Camera> camera =\n", "prefixes": [ "libcamera-devel", "v2" ] }