Patch Detail
Show a patch.
GET /api/1.1/patches/12446/?format=api
{ "id": 12446, "url": "https://patchwork.libcamera.org/api/1.1/patches/12446/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12446/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210527101105.32789-1-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-05-27T10:11:05", "name": "[libcamera-devel] ipa: ipu3: Use a default gamma LUT at startup", "commit_ref": "bcfd7b636922261987121d785a4ce4a13dd6afc3", "pull_url": null, "state": "accepted", "archived": false, "hash": "cf21915486fd2f90ad5c0320377c650a0a70ff9a", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12446/mbox/", "series": [ { "id": 2085, "url": "https://patchwork.libcamera.org/api/1.1/series/2085/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2085", "date": "2021-05-27T10:11:05", "name": "[libcamera-devel] ipa: ipu3: Use a default gamma LUT at startup", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2085/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12446/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12446/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 153B0BDB80\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 27 May 2021 10:11:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 69F1B602AE;\n\tThu, 27 May 2021 12:11:09 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62F53602AA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 May 2021 12:11:08 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:563e:3c07:6748:2112])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D3569B2C;\n\tThu, 27 May 2021 12:11:07 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sfmN2iDk\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1622110267;\n\tbh=xQ3rGEbvdPp8ciEdEiC3XANRTEqfEnb+ihNPcDMRzJM=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=sfmN2iDkc/37bpowdokGtTuzDQKS77/jfhBMWIOgxdIE6x0LlP0zOZ4eG7asLQrAE\n\tbRjLpU1jqg6bk+bCr3CiG6eKyv02lobmeYRTzDzoWkLOnY34AmlBc7UkBBhdeytRCi\n\tfWg3RcdpyTpDuvrhFloQxgoiFugGmcx03/0gJZ2c=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 27 May 2021 12:11:05 +0200", "Message-Id": "<20210527101105.32789-1-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] ipa: ipu3: Use a default gamma LUT at\n\tstartup", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "A custom gamma LUT is used, but the table is not calculated at startup,\nresulting in an all 0's frame.\nUse the drfault LUT specified in the Linux kernel as a first estimation.\n\nReported-by: Paul Elder <paul.elder@ideasonboard.com>\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nTested-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3_awb.cpp | 26 ++++++++++++++++++++++++++\n 1 file changed, 26 insertions(+)", "diff": "diff --git a/src/ipa/ipu3/ipu3_awb.cpp b/src/ipa/ipu3/ipu3_awb.cpp\nindex f8788065..54ce8e67 100644\n--- a/src/ipa/ipu3/ipu3_awb.cpp\n+++ b/src/ipa/ipu3/ipu3_awb.cpp\n@@ -134,6 +134,31 @@ static const struct ipu3_uapi_ccm_mat_config imguCssCcmDefault = {\n \t0, 0, 8191, 0\n };\n \n+/* Default settings for Gamma correction */\n+const struct ipu3_uapi_gamma_corr_lut imguCssGammaLut = { {\n+\t63, 79, 95, 111, 127, 143, 159, 175, 191, 207, 223, 239, 255, 271, 287,\n+\t303, 319, 335, 351, 367, 383, 399, 415, 431, 447, 463, 479, 495, 511,\n+\t527, 543, 559, 575, 591, 607, 623, 639, 655, 671, 687, 703, 719, 735,\n+\t751, 767, 783, 799, 815, 831, 847, 863, 879, 895, 911, 927, 943, 959,\n+\t975, 991, 1007, 1023, 1039, 1055, 1071, 1087, 1103, 1119, 1135, 1151,\n+\t1167, 1183, 1199, 1215, 1231, 1247, 1263, 1279, 1295, 1311, 1327, 1343,\n+\t1359, 1375, 1391, 1407, 1423, 1439, 1455, 1471, 1487, 1503, 1519, 1535,\n+\t1551, 1567, 1583, 1599, 1615, 1631, 1647, 1663, 1679, 1695, 1711, 1727,\n+\t1743, 1759, 1775, 1791, 1807, 1823, 1839, 1855, 1871, 1887, 1903, 1919,\n+\t1935, 1951, 1967, 1983, 1999, 2015, 2031, 2047, 2063, 2079, 2095, 2111,\n+\t2143, 2175, 2207, 2239, 2271, 2303, 2335, 2367, 2399, 2431, 2463, 2495,\n+\t2527, 2559, 2591, 2623, 2655, 2687, 2719, 2751, 2783, 2815, 2847, 2879,\n+\t2911, 2943, 2975, 3007, 3039, 3071, 3103, 3135, 3167, 3199, 3231, 3263,\n+\t3295, 3327, 3359, 3391, 3423, 3455, 3487, 3519, 3551, 3583, 3615, 3647,\n+\t3679, 3711, 3743, 3775, 3807, 3839, 3871, 3903, 3935, 3967, 3999, 4031,\n+\t4063, 4095, 4127, 4159, 4223, 4287, 4351, 4415, 4479, 4543, 4607, 4671,\n+\t4735, 4799, 4863, 4927, 4991, 5055, 5119, 5183, 5247, 5311, 5375, 5439,\n+\t5503, 5567, 5631, 5695, 5759, 5823, 5887, 5951, 6015, 6079, 6143, 6207,\n+\t6271, 6335, 6399, 6463, 6527, 6591, 6655, 6719, 6783, 6847, 6911, 6975,\n+\t7039, 7103, 7167, 7231, 7295, 7359, 7423, 7487, 7551, 7615, 7679, 7743,\n+\t7807, 7871, 7935, 7999, 8063, 8127, 8191\n+} };\n+\n IPU3Awb::IPU3Awb()\n \t: Algorithm()\n {\n@@ -174,6 +199,7 @@ void IPU3Awb::initialise(ipu3_uapi_params ¶ms, const Size &bdsOutputSize, st\n \tparams.acc_param.ccm = imguCssCcmDefault;\n \n \tparams.use.acc_gamma = 1;\n+\tparams.acc_param.gamma.gc_lut = imguCssGammaLut;\n \tparams.acc_param.gamma.gc_ctrl.enable = 1;\n \n \tzones_.reserve(kAwbStatsSizeX * kAwbStatsSizeY);\n", "prefixes": [ "libcamera-devel" ] }