Patch Detail
Show a patch.
GET /api/1.1/patches/12419/?format=api
{ "id": 12419, "url": "https://patchwork.libcamera.org/api/1.1/patches/12419/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12419/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210526034720.1253094-2-paul.elder@ideasonboard.com>", "date": "2021-05-26T03:47:19", "name": "[libcamera-devel,v4,2/3] android: camera_device: Fix sensor frame duration", "commit_ref": "3beb1accac1d9eff6cc36681915b943413081593", "pull_url": null, "state": "accepted", "archived": false, "hash": "2d91fc671bd1349df47bbd659ed7181dc0f7e079", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12419/mbox/", "series": [ { "id": 2069, "url": "https://patchwork.libcamera.org/api/1.1/series/2069/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2069", "date": "2021-05-26T03:47:18", "name": "[libcamera-devel,v4,1/3] controls: Split FrameDurations into FrameDuration and FrameDurationLimits", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2069/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12419/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12419/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59252C3203\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 26 May 2021 03:47:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 16EDB68923;\n\tWed, 26 May 2021 05:47:42 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DA9C568923\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 May 2021 05:47:39 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A30AD332;\n\tWed, 26 May 2021 05:47:37 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aaLKxOJR\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1622000859;\n\tbh=di9P3RyVubxN4G1YO43OgG8vc+SQEPYroQq40orjZ+Q=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=aaLKxOJRpBCmc4bd3RCAuDKN/qcZkei0soPdIYMAa27xyEzsVUL4if4fdDHkiTi+x\n\tb1j/ZvV9g+diN3d+dUksHTudrAV9dSH51V0/xwn6c8+S3EWxYEKJrSPyuQ+K8KpTq6\n\tWqzQUjrUIEuQxHIIn5aBVBGymti6r9QnUUL/Dvlw=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 26 May 2021 12:47:19 +0900", "Message-Id": "<20210526034720.1253094-2-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210526034720.1253094-1-paul.elder@ideasonboard.com>", "References": "<20210526034720.1253094-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 2/3] android: camera_device: Fix sensor\n\tframe duration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The sensor frame duration should be set by IPA. Get the information for\nthe result metadata from libcamera.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_device.cpp | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 9e267b5f..376bfd5f 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -2299,6 +2299,12 @@ CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor) cons\n \t\tresultMetadata->addEntry(ANDROID_SENSOR_EXPOSURE_TIME, exposure);\n \t}\n \n+\tif (metadata.contains(controls::FrameDuration)) {\n+\t\tint64_t duration = metadata.get(controls::FrameDuration) * 1000;\n+\t\tresultMetadata->addEntry(ANDROID_SENSOR_FRAME_DURATION,\n+\t\t\t\t\t duration);\n+\t}\n+\n \tif (metadata.contains(controls::ScalerCrop)) {\n \t\tRectangle crop = metadata.get(controls::ScalerCrop);\n \t\tint32_t cropRect[] = {\n", "prefixes": [ "libcamera-devel", "v4", "2/3" ] }