Patch Detail
Show a patch.
GET /api/1.1/patches/12402/?format=api
{ "id": 12402, "url": "https://patchwork.libcamera.org/api/1.1/patches/12402/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12402/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210525091812.1225580-3-paul.elder@ideasonboard.com>", "date": "2021-05-25T09:18:12", "name": "[libcamera-devel,v3,3/3] ipa: ipu3: Set output frame duration metadata", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "751d46808896a240be9fc9ee62baf6b57092f009", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12402/mbox/", "series": [ { "id": 2062, "url": "https://patchwork.libcamera.org/api/1.1/series/2062/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2062", "date": "2021-05-25T09:18:10", "name": "[libcamera-devel,v3,1/3] controls: Split FrameDurations into FrameDuration and FrameDurationLimits", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2062/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12402/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12402/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AF597C3202\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 25 May 2021 09:18:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7650E68926;\n\tTue, 25 May 2021 11:18:35 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9344F68921\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 25 May 2021 11:18:33 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1D19A344;\n\tTue, 25 May 2021 11:18:30 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dP+5ESzy\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1621934313;\n\tbh=vG29wqoHeH3ewKzjFlPcZ0Do28b51qvNRQoADeCzxGA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=dP+5ESzysIEaAU2YHrQUgo3vqFCLW5QR3+C9U5kEYZaLTvFnR76Nch3qJ0v+Do9/w\n\tDCI6dC6vgQco/YYbphVTbu0kki/KHlshUpmffBXMpqzT3hlDsAOKWXeuqQKML9ccO7\n\tCqfp8fb+4A5u3lvFUfPjca9P/msoIYOsHxUrbqqU=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 25 May 2021 18:18:12 +0900", "Message-Id": "<20210525091812.1225580-3-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210525091812.1225580-1-paul.elder@ideasonboard.com>", "References": "<20210525091812.1225580-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 3/3] ipa: ipu3: Set output frame\n\tduration metadata", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The sensor frame duration should be set by the IPA. Hardcode it for now.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Hirokazu Honda <hiroh@chromium.org>\n---\n src/ipa/ipu3/ipu3.cpp | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 769c24d3..6b9aeab6 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -267,6 +267,10 @@ void IPAIPU3::parseStatistics(unsigned int frame,\n \tif (agcAlgo_->updateControls())\n \t\tsetControls(frame);\n \n+\t/* \\todo Populate this with real values */\n+\tctrls.set(controls::FrameDuration,\n+\t\t static_cast<int64_t>(33334));\n+\n \tIPU3Action op;\n \top.op = ActionMetadataReady;\n \top.controls = ctrls;\n", "prefixes": [ "libcamera-devel", "v3", "3/3" ] }