Patch Detail
Show a patch.
GET /api/1.1/patches/12366/?format=api
{ "id": 12366, "url": "https://patchwork.libcamera.org/api/1.1/patches/12366/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12366/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210523023155.20268-4-laurent.pinchart@ideasonboard.com>", "date": "2021-05-23T02:31:54", "name": "[libcamera-devel,3/4] libcamera: thread: Drop doc of asynchronous signals delivery to applications", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ec7825952b3e4d95e57c94cd57250c7f29a56469", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12366/mbox/", "series": [ { "id": 2049, "url": "https://patchwork.libcamera.org/api/1.1/series/2049/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2049", "date": "2021-05-23T02:31:51", "name": "libcamera: thread: Documentation fixes and enhancements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2049/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12366/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12366/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C3CD9C3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 23 May 2021 02:32:06 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6869D6891E;\n\tSun, 23 May 2021 04:32:06 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 703E368911\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 23 May 2021 04:32:02 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F35302A8;\n\tSun, 23 May 2021 04:32:01 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Hc0Xmbbe\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1621737122;\n\tbh=4DX+fdAAjUoOjofw2CydUwhFYPlKi9X48/oFJfmcoM4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Hc0XmbbewOZSlZ9vX3FsgOpk+gvBoa8YOucq/K5kf45/SIAS9QhzzeNc0zWSfyPdI\n\tRWVSQ2bzWQSNGIEvOdtF/c8+2k/vA6xtNTWbBSu4Djj3CUKZPCsmEu/in5E7VaWK+k\n\tjMumh3aXqmAOoecjNiG3TXVeO8fpclav1g4v3TnM=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 23 May 2021 05:31:54 +0300", "Message-Id": "<20210523023155.20268-4-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.28.1", "In-Reply-To": "<20210523023155.20268-1-laurent.pinchart@ideasonboard.com>", "References": "<20210523023155.20268-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 3/4] libcamera: thread: Drop doc of\n\tasynchronous signals delivery to applications", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The asynchronous signal delivery mechanism can't be used by application,\nas it requires libcamera to be aware of the application event loop,\nwhich has been dropped a long time ago. Drop the corresponding\ndocumentation paragraph.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/thread.cpp | 8 --------\n 1 file changed, 8 deletions(-)", "diff": "diff --git a/src/libcamera/thread.cpp b/src/libcamera/thread.cpp\nindex bc1dcedea0d1..d59e43966d26 100644\n--- a/src/libcamera/thread.cpp\n+++ b/src/libcamera/thread.cpp\n@@ -64,14 +64,6 @@\n * be overridden by selecting a different connection type when calling\n * Signal::connect().\n *\n- * Asynchronous signal delivery is used internally in libcamera, but is also\n- * available to applications if desired. To use this feature, applications\n- * shall create receiver classes that inherit from the Object class, and\n- * provide an event loop to the CameraManager as explained above. Note that\n- * Object instances created by the application are limited to living in the\n- * application's main thread. Creating Object instances from another thread of\n- * an application causes undefined behaviour.\n- *\n * \\section thread-reentrancy Reentrancy and Thread-Safety\n *\n * Through the documentation, several terms are used to define how classes and\n", "prefixes": [ "libcamera-devel", "3/4" ] }