Patch Detail
Show a patch.
GET /api/1.1/patches/12360/?format=api
{ "id": 12360, "url": "https://patchwork.libcamera.org/api/1.1/patches/12360/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12360/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210522002309.26083-1-laurent.pinchart@ideasonboard.com>", "date": "2021-05-22T00:23:09", "name": "[libcamera-devel] libcamera: log: Hide value of the ASSERT() macro", "commit_ref": "fd1cbe84476b25b458c3dbe78ec6c55e774ce435", "pull_url": null, "state": "accepted", "archived": false, "hash": "d671573aec1f1c3d55e7e557b327ae7e23e8f9cc", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12360/mbox/", "series": [ { "id": 2046, "url": "https://patchwork.libcamera.org/api/1.1/series/2046/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2046", "date": "2021-05-22T00:23:09", "name": "[libcamera-devel] libcamera: log: Hide value of the ASSERT() macro", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2046/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12360/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12360/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ADC38C3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 22 May 2021 00:23:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 101A46891E;\n\tSat, 22 May 2021 02:23:28 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4EB14602B2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 22 May 2021 02:23:26 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CDA3B4A8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 22 May 2021 02:23:25 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ttoAR9Ue\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1621643006;\n\tbh=0OU/ls9NN4jkJflsD3w9B+s76kEXeRuozyPqVBRE8l8=;\n\th=From:To:Subject:Date:From;\n\tb=ttoAR9Ue4ecMLNYTP//zssNbKV8C6KZQMc0//BUnhUmXl3CD8uqTN1C+wQNtWKTNr\n\tR3VqxARzMiyaxfQq/FOoC5N/BvqK1J4EczSy8psL3Oyn6+k6TtRtOCRDaLpEEqpgTb\n\tl1Z/umm/t58XNl8WnGlpeTUtmY+u4qtZEzn81+mQ=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 22 May 2021 03:23:09 +0300", "Message-Id": "<20210522002309.26083-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.28.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: log: Hide value of the\n\tASSERT() macro", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "ASSERT() is a function-like macro that expands to internal code. Hide\nthe expansion from the generated documentation, as it would only confuse\nthe reader.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/log.cpp | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\nindex 985952249289..dd991647b9bc 100644\n--- a/src/libcamera/log.cpp\n+++ b/src/libcamera/log.cpp\n@@ -990,6 +990,7 @@ LogMessage _log(const LogCategory *category, LogSeverity severity,\n \n /**\n * \\def ASSERT(condition)\n+ * \\hideinitializer\n * \\brief Abort program execution if assertion fails\n *\n * If \\a condition is false, ASSERT() logs an error message with the Fatal log\n", "prefixes": [ "libcamera-devel" ] }