Patch Detail
Show a patch.
GET /api/1.1/patches/1229/?format=api
{ "id": 1229, "url": "https://patchwork.libcamera.org/api/1.1/patches/1229/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1229/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190517230621.24668-13-laurent.pinchart@ideasonboard.com>", "date": "2019-05-17T23:06:21", "name": "[libcamera-devel,PATCH/RFC,12/12] cam: Validate camera configuration", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "804a1192aeceb7f1c9aa9ee2ae13c0ca411250a3", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1229/mbox/", "series": [ { "id": 307, "url": "https://patchwork.libcamera.org/api/1.1/series/307/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=307", "date": "2019-05-17T23:06:09", "name": "Rework camera configuration to introduce negotiation of parameters", "version": 1, "mbox": "https://patchwork.libcamera.org/series/307/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1229/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1229/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BBE1D6186B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 18 May 2019 01:06:46 +0200 (CEST)", "from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5A2E7336\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 18 May 2019 01:06:46 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1558134406;\n\tbh=rR4ehpcqEikhcJyaY1PU1JMA7xCXc9+aH8pRz9tJQa8=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=hJqjRK6kAL2YvsmGar9l0YU02QApQ0uEuIdNltTDyBROTo2AqY7sennSfqeVwPmw+\n\tdW7rawG8riL46vfngEpIni3OU0QE+mG6/WS3UmsaHBB4W8smEMRvOTY5N3t9iLKhPz\n\tclQeuy8p3GF0lf7iiYa552Rhu0PHGrVEjGPu1W2c=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 18 May 2019 02:06:21 +0300", "Message-Id": "<20190517230621.24668-13-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190517230621.24668-1-laurent.pinchart@ideasonboard.com>", "References": "<20190517230621.24668-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH/RFC 12/12] cam: Validate camera\n\tconfiguration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 17 May 2019 23:06:49 -0000" }, "content": "From: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nUse CameraConfiguration::validate() to validate and possibly update the\nstream formats before configuring a camera.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/cam/main.cpp | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex a962f94c8f59..91785b7fea31 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -140,6 +140,18 @@ static CameraConfiguration *prepareCameraConfig()\n \t\t\tcfg.pixelFormat = conf[\"pixelformat\"];\n \t}\n \n+\tswitch (config->validate()) {\n+\tcase CameraConfiguration::Valid:\n+\t\tbreak;\n+\tcase CameraConfiguration::Adjusted:\n+\t\tstd::cout << \"Adjusted request format\" << std::endl;\n+\t\tbreak;\n+\tcase CameraConfiguration::Invalid:\n+\t\tdelete config;\n+\t\tconfig = nullptr;\n+\t\tbreak;\n+\t}\n+\n \treturn config;\n }\n \n", "prefixes": [ "libcamera-devel", "PATCH/RFC", "12/12" ] }