Patch Detail
Show a patch.
GET /api/1.1/patches/12222/?format=api
{ "id": 12222, "url": "https://patchwork.libcamera.org/api/1.1/patches/12222/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12222/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210507084042.31879-2-naush@raspberrypi.com>", "date": "2021-05-07T08:40:38", "name": "[libcamera-devel,v6,1/5] ipa: raspberrypi: Store dropped frame count in a member variable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "99b0cf3fca595fc87c0da11ee01a39e1f067c84f", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12222/mbox/", "series": [ { "id": 2010, "url": "https://patchwork.libcamera.org/api/1.1/series/2010/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2010", "date": "2021-05-07T08:40:37", "name": "ipa: raspberrypi: Rate-limit the controller algorithms", "version": 6, "mbox": "https://patchwork.libcamera.org/series/2010/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12222/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12222/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4A19ABF831\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 7 May 2021 08:40:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EAA6068919;\n\tFri, 7 May 2021 10:40:50 +0200 (CEST)", "from mail-wr1-x436.google.com (mail-wr1-x436.google.com\n\t[IPv6:2a00:1450:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E0A86890C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 7 May 2021 10:40:49 +0200 (CEST)", "by mail-wr1-x436.google.com with SMTP id l14so8319856wrx.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 07 May 2021 01:40:49 -0700 (PDT)", "from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:81ab:95ee:9715:e9fb])\n\tby smtp.gmail.com with ESMTPSA id\n\tl12sm7604098wrm.76.2021.05.07.01.40.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 07 May 2021 01:40:48 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"j9KncL+U\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=gWJqV6+KMq4Cdqjn8VB0rZGm/jSwDPd5ZcJ2lMonb8E=;\n\tb=j9KncL+UNOwGCZ6bLH9bwOlmpFhoDC8zPaGAvMT5rfFJeNomHPimHlrZ/sAyeM0A1y\n\t0WS5aLGzpF/MPh11s5jaDCGk6S+L3sAZnDkYz/6armdnIpumnbqtOcWdSCNQtM9KlduX\n\tLnCaT+kCjnqejI2gl3mVJbeo1m4HERt2gi4uUEM23QEn3eut+FZrrphAxMY8A93PjmQA\n\tPs0r2SmxFbUooxQAmAOjDggY2/jO6lSgdmazDSkkm0ztEIVAuVDU2OqMr+5qAxlfNfkH\n\t3zOzmECiI2Uo4VH+326bCxFjcBvho3hhXW+zHDtMIkNmNenuy2zQUt0r86mQITNr7MWj\n\tYbEg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=gWJqV6+KMq4Cdqjn8VB0rZGm/jSwDPd5ZcJ2lMonb8E=;\n\tb=AUtRCtvB6NdG4+5CUAyTAQZbOfBpTUBLFDqTdscyMpvzqSMTHYxQycXN/K8hrCpIfl\n\tv59CeszA9dL+cS9AEaQos3HprUjpTYcXPpYgAJh4EXqMkzOkBJ2tDT/yMN87/XssNs56\n\tFwsY4En3gQgmWl/lmdXclfGf+MO2cQ+ed19f0HHXPdF32lCWzsDYnFjP7Bb8YSrdc+ke\n\tR33akSAbFodVXnp4gqspH3CZdQwjnTscnXNvuE1hfugUn74NMXTcpDWV0DW0upy/MmFy\n\tsoPF5F3YHH9TZI6wDBIM5lssoPg5/Rl321FSlWNG0UzC/EicIs3QO1IU/3b6PBiQisgR\n\tBjaw==", "X-Gm-Message-State": "AOAM531EGzBdPy3fmmWSQ27BXf3KA1Cr51pEIXM947D970Rte0Y84ZTy\n\tDdtEJIuYeAx2H5XbGK776aKPdDNR8cg1pg==", "X-Google-Smtp-Source": "ABdhPJyH27Y+ynH6eG5fj+bK0oeCRPGgiC4qcW8GLxXu+O24x4yvqKJO14JHuBs7e5+M7kX6hX2fYQ==", "X-Received": "by 2002:a5d:400f:: with SMTP id\n\tn15mr6838475wrp.274.1620376849173; \n\tFri, 07 May 2021 01:40:49 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 7 May 2021 09:40:38 +0100", "Message-Id": "<20210507084042.31879-2-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210507084042.31879-1-naush@raspberrypi.com>", "References": "<20210507084042.31879-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v6 1/5] ipa: raspberrypi: Store dropped\n\tframe count in a member variable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Store the number of dropped frames on startup in a member variable. This\nwill be used in a subsequent change for rate limiting the controller\nalgorithms.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/raspberrypi/raspberrypi.cpp | 14 ++++++++------\n 1 file changed, 8 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex b0f61d351e3a..f6d1ab16a290 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -143,6 +143,9 @@ private:\n \t/* How many frames we should avoid running control algos on. */\n \tunsigned int mistrustCount_;\n \n+\t/* Number of frames that need to be dropped on startup. */\n+\tunsigned int dropFrameCount_;\n+\n \t/* LS table allocation passed in from the pipeline handler. */\n \tFileDescriptor lsTableHandle_;\n \tvoid *lsTable_;\n@@ -220,9 +223,8 @@ void IPARPi::start(const ControlList &controls, ipa::RPi::StartConfig *startConf\n \t */\n \tframeCount_ = 0;\n \tcheckCount_ = 0;\n-\tunsigned int dropFrame = 0;\n \tif (firstStart_) {\n-\t\tdropFrame = helper_->HideFramesStartup();\n+\t\tdropFrameCount_ = helper_->HideFramesStartup();\n \t\tmistrustCount_ = helper_->MistrustFramesStartup();\n \n \t\t/*\n@@ -250,14 +252,14 @@ void IPARPi::start(const ControlList &controls, ipa::RPi::StartConfig *startConf\n \t\t\t\tawbConvergenceFrames += mistrustCount_;\n \t\t}\n \n-\t\tdropFrame = std::max({ dropFrame, agcConvergenceFrames, awbConvergenceFrames });\n-\t\tLOG(IPARPI, Debug) << \"Drop \" << dropFrame << \" frames on startup\";\n+\t\tdropFrameCount_ = std::max({ dropFrameCount_, agcConvergenceFrames, awbConvergenceFrames });\n+\t\tLOG(IPARPI, Debug) << \"Drop \" << dropFrameCount_ << \" frames on startup\";\n \t} else {\n-\t\tdropFrame = helper_->HideFramesModeSwitch();\n+\t\tdropFrameCount_ = helper_->HideFramesModeSwitch();\n \t\tmistrustCount_ = helper_->MistrustFramesModeSwitch();\n \t}\n \n-\tstartConfig->dropFrameCount = dropFrame;\n+\tstartConfig->dropFrameCount = dropFrameCount_;\n \n \tfirstStart_ = false;\n }\n", "prefixes": [ "libcamera-devel", "v6", "1/5" ] }