Patch Detail
Show a patch.
GET /api/1.1/patches/12119/?format=api
{ "id": 12119, "url": "https://patchwork.libcamera.org/api/1.1/patches/12119/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12119/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210427130844.11357-2-david.plowman@raspberrypi.com>", "date": "2021-04-27T13:08:41", "name": "[libcamera-devel,v4,1/4] ipa: raspberrypi: Make CamHelper exposure methods virtual", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7fa0a8cb40fac1ec7942491ae2dbd76623b110c3", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12119/mbox/", "series": [ { "id": 1982, "url": "https://patchwork.libcamera.org/api/1.1/series/1982/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1982", "date": "2021-04-27T13:08:40", "name": "Raspberry Pi: handle sensors more flexibly", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1982/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12119/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12119/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3B652BDE3B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 27 Apr 2021 13:08:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F19D0688B6;\n\tTue, 27 Apr 2021 15:08:51 +0200 (CEST)", "from mail-wm1-x332.google.com (mail-wm1-x332.google.com\n\t[IPv6:2a00:1450:4864:20::332])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 87517602C2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 27 Apr 2021 15:08:50 +0200 (CEST)", "by mail-wm1-x332.google.com with SMTP id n84so4602035wma.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 27 Apr 2021 06:08:50 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tr11sm3899327wrx.22.2021.04.27.06.08.49\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 27 Apr 2021 06:08:49 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"WOu9A4j6\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=wG9J5D/wwMDG87CUQxw2d46l59UXBc9BQI+/bLGXxxo=;\n\tb=WOu9A4j6OvJ9gO9ZwfZCEjEu4wqabTRyX6AfP8KOn7S32W+PM2ZxVPLLk4V4TUwNKv\n\tXM60dUxEMEYqixaQm0Du/V1g9KzMuBDBfgkNhDTMIa10d5XAithhdakq8xeDplRBv4BY\n\tb4ZzU9D/tgMKP6Pl2bxc593Oqz3qUa7/g/pgLz78SCNlIt5FblNQWVizOXaKymZ1LrIX\n\tmxcJrMsO8G6xaYfjJenr6xqE/0kc+MWpwnBopDdvTxShkWzTo4kEvUpIXXuvGyqBYaeu\n\tqTLIy2HFP1byAPbA8BNiem43r7xSGeGq8TK1kKgGzcIuFGA9wpvOT65S5sUcTqDkcCcQ\n\tFF3g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=wG9J5D/wwMDG87CUQxw2d46l59UXBc9BQI+/bLGXxxo=;\n\tb=kP/gzQnirCKnpUsEVLYp4EPHE1iRbOtpt5s9kIBizRYVwvP4v1Ba/jzXDhmJR06g41\n\tvm+gqRK3086z3qNyfFLFmkhc8Xsa3hKrCerVOZVk2e/Axt4hsqEUYw/s5fkpSq1Q7Ok/\n\t0g8RhD55tJ2f1BXipgb12pfDuZbTQqQooDn4cvJ1e4W92wn2lrshkaP5j5vop05NcWPE\n\tV2H7fRKys8K1RrNVhWJytz/Z/h+Za4pOLt9fXoagpaBx3b+fAS2DNr/EVdY3onNYfraZ\n\tzCEhDhawFlldfqxJgkfz0xkZXjkKJ5LQw4r4xDVQI2WzJrHsMakH0CFCY+vwoC5z8+d/\n\tjkWQ==", "X-Gm-Message-State": "AOAM530FtuojgIyWWDGV4Up9rSQxRfBb0WdrYkYWZaRkIX/RoRe2tmSU\n\tGTr9Z3LOxJYCVojxtaQywlr+rTZvOWnAuw==", "X-Google-Smtp-Source": "ABdhPJyvWoYxEKdF0H0BI75F493KRnADzjRWZznZXbQq8g46cvG7owDA6kgf3bBT+dFota2bL5n8QQ==", "X-Received": "by 2002:a05:600c:4e93:: with SMTP id\n\tf19mr24479679wmq.122.1619528930103; \n\tTue, 27 Apr 2021 06:08:50 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 27 Apr 2021 14:08:41 +0100", "Message-Id": "<20210427130844.11357-2-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20210427130844.11357-1-david.plowman@raspberrypi.com>", "References": "<20210427130844.11357-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 1/4] ipa: raspberrypi: Make CamHelper\n\texposure methods virtual", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This allows derived classes to override them if they have any special\nbehaviours to implement. For instance if a particular camera mode\nproduces a different signal level to other modes, you might choose to\naddress that in the gain or exposure methods.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/raspberrypi/cam_helper.hpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp\nindex c3ed5362..618391e9 100644\n--- a/src/ipa/raspberrypi/cam_helper.hpp\n+++ b/src/ipa/raspberrypi/cam_helper.hpp\n@@ -66,8 +66,8 @@ public:\n \tvirtual ~CamHelper();\n \tvoid SetCameraMode(const CameraMode &mode);\n \tMdParser &Parser() const { return *parser_; }\n-\tuint32_t ExposureLines(double exposure_us) const;\n-\tdouble Exposure(uint32_t exposure_lines) const; // in us\n+\tvirtual uint32_t ExposureLines(double exposure_us) const;\n+\tvirtual double Exposure(uint32_t exposure_lines) const; // in us\n \tvirtual uint32_t GetVBlanking(double &exposure_us, double minFrameDuration,\n \t\t\t\t double maxFrameDuration) const;\n \tvirtual uint32_t GainCode(double gain) const = 0;\n", "prefixes": [ "libcamera-devel", "v4", "1/4" ] }