Patch Detail
Show a patch.
GET /api/1.1/patches/12080/?format=api
{ "id": 12080, "url": "https://patchwork.libcamera.org/api/1.1/patches/12080/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12080/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210422124123.113903-1-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-04-22T12:41:23", "name": "[libcamera-devel] ipa: ipu3: fix coverity issues in AWB", "commit_ref": "7e0da7c34900cb219ee447df547162211d8683e3", "pull_url": null, "state": "accepted", "archived": false, "hash": "9c8f8475ebe70305a6c2ffb79cf3969c337b3985", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12080/mbox/", "series": [ { "id": 1963, "url": "https://patchwork.libcamera.org/api/1.1/series/1963/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1963", "date": "2021-04-22T12:41:23", "name": "[libcamera-devel] ipa: ipu3: fix coverity issues in AWB", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1963/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12080/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12080/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 584FDBDB17\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 22 Apr 2021 12:41:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 70A7968853;\n\tThu, 22 Apr 2021 14:41:27 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C37C360514\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 Apr 2021 14:41:25 +0200 (CEST)", "from localhost.localdomain (unknown\n\t[IPv6:2a01:e0a:169:7140:e96c:3f42:9018:e1b2])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5F21C3EE;\n\tThu, 22 Apr 2021 14:41:25 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"prTPOKkp\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619095285;\n\tbh=tWCosl9eQ8Br01bY+aPwunDG0dlLQuJfgx5I3SPaHQg=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=prTPOKkpsL+K0EH2rwA9xrIq3LJi/ZkDjP5nZQolL8bModiFGAgH84jLJHL7o9FD+\n\tQPYv+cdk7dXKPVSIBEqbssW6rQaIJNQVpB3/KYwuo0j3l2bBQ/HUdL7UbTiXh8x87G\n\tMQY7RnNoLtvWSOP+E3fbfnCxX+iLGZF+7IIlcZG4=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 22 Apr 2021 14:41:23 +0200", "Message-Id": "<20210422124123.113903-1-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] ipa: ipu3: fix coverity issues in AWB", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This patch fixes two minor issues detected by converity after merging in\nmaster.\n\nReported-by: Coverity CID=320056\nReported-by: Coverity CID=320058\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3_awb.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/ipu3_awb.cpp b/src/ipa/ipu3/ipu3_awb.cpp\nindex 060d1e18..f8788065 100644\n--- a/src/ipa/ipu3/ipu3_awb.cpp\n+++ b/src/ipa/ipu3/ipu3_awb.cpp\n@@ -96,14 +96,14 @@ static const struct ipu3_uapi_bnr_static_config imguCssBnrDefaults = {\n \t.wb_gains_thr = { 255, 255, 255, 255 },\n \t.thr_coeffs = { 1700, 0, 31, 31, 0, 16 },\n \t.thr_ctrl_shd = { 26, 26, 26, 26 },\n-\t.opt_center{ -648, 0, -366, 0 },\n+\t.opt_center = { -648, 0, -366, 0 },\n \t.lut = {\n \t\t{ 17, 23, 28, 32, 36, 39, 42, 45,\n \t\t 48, 51, 53, 55, 58, 60, 62, 64,\n \t\t 66, 68, 70, 72, 73, 75, 77, 78,\n \t\t 80, 82, 83, 85, 86, 88, 89, 90 } },\n \t.bp_ctrl = { 20, 0, 1, 40, 0, 6, 0, 6, 0 },\n-\t.dn_detect_ctrl{ 9, 3, 4, 0, 8, 0, 1, 1, 1, 1, 0 },\n+\t.dn_detect_ctrl = { 9, 3, 4, 0, 8, 0, 1, 1, 1, 1, 0 },\n \t.column_size = 1296,\n \t.opt_center_sqr = { 419904, 133956 },\n };\n", "prefixes": [ "libcamera-devel" ] }