Patch Detail
Show a patch.
GET /api/1.1/patches/12076/?format=api
{ "id": 12076, "url": "https://patchwork.libcamera.org/api/1.1/patches/12076/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12076/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210422094102.371772-10-paul.elder@ideasonboard.com>", "date": "2021-04-22T09:40:59", "name": "[libcamera-devel,RFC,v2,09/12] pipeline: ipu3: Add controls for FULL compliance", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "5c29573b236562a38b16ffdc86c8d27bed4a073e", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/12076/mbox/", "series": [ { "id": 1962, "url": "https://patchwork.libcamera.org/api/1.1/series/1962/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1962", "date": "2021-04-22T09:40:50", "name": "FULL hardware level fixes", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1962/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12076/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12076/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 416DABDB17\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 22 Apr 2021 09:41:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E2BB76885E;\n\tThu, 22 Apr 2021 11:41:31 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 270CE6885A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 Apr 2021 11:41:29 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C0FDB3EE;\n\tThu, 22 Apr 2021 11:41:27 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"q+VfUPsH\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619084488;\n\tbh=fp6PnHlLUN8w+sOPVCI/naUNJevLG7Zp/k/mvZLz8kI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=q+VfUPsH7J5+iMmumDXdhTPaDFY0Rf/IW9vkiQ09Z3nR6ruNjKGDQtIpYnjVDwKLv\n\tKrzVTl9OQ5VEWzb3XCxrv+JkVDoNwP5oTrq5Lgo+MCQV6keTIUqjIqDXg0P+Zee/tP\n\txGq3ljeYTT85fqGaTmLgiJn5GBO8wepuO6RPJEU0=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 22 Apr 2021 18:40:59 +0900", "Message-Id": "<20210422094102.371772-10-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210422094102.371772-1-paul.elder@ideasonboard.com>", "References": "<20210422094102.371772-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [RFC PATCH v2 09/12] pipeline: ipu3: Add controls\n\tfor FULL compliance", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add controls to IPU3Controls that are necessary for FULL compliance.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 19 +++++++++++++++++++\n 1 file changed, 19 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 28e849a4..70a5e9ce 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -48,8 +48,27 @@ static constexpr unsigned int IMGU_OUTPUT_WIDTH_MARGIN = 64;\n static constexpr unsigned int IMGU_OUTPUT_HEIGHT_MARGIN = 32;\n static constexpr Size IPU3ViewfinderSize(1280, 720);\n \n+const std::array<const ControlValue, 3> IPU3NoiseReductionModeValues = {\n+\tstatic_cast<int32_t>(controls::draft::NoiseReductionModeOff),\n+\tstatic_cast<int32_t>(controls::draft::NoiseReductionModeFast),\n+\tstatic_cast<int32_t>(controls::draft::NoiseReductionModeHighQuality),\n+};\n+\n static const ControlInfoMap::Map IPU3Controls = {\n \t{ &controls::draft::PipelineDepth, ControlInfo(2, 3) },\n+\t{ &controls::draft::BlackLevelLocked, ControlInfo(false, true) },\n+\t{ &controls::AeLocked, ControlInfo(false, true) },\n+\t{ &controls::draft::AePrecaptureTrigger,\n+\t\tControlInfo(controls::draft::AePrecaptureTriggerValues) },\n+\t{ &controls::AwbMode, ControlInfo(controls::AwbModeValues) },\n+\t{ &controls::AwbLocked, ControlInfo(false, true) },\n+\t{ &controls::draft::EdgeMode,\n+\t\tControlInfo(controls::draft::EdgeModeValues) },\n+\t{ &controls::draft::NoiseReductionMode,\n+\t\tControlInfo(IPU3NoiseReductionModeValues) },\n+\t{ &controls::draft::SensorSensitivity, ControlInfo(32, 2400) },\n+\t{ &controls::draft::TonemapMode,\n+\t\tControlInfo(controls::draft::TonemapModeValues) },\n };\n \n class IPU3CameraData : public CameraData\n", "prefixes": [ "libcamera-devel", "RFC", "v2", "09/12" ] }