Patch Detail
Show a patch.
GET /api/1.1/patches/11958/?format=api
{ "id": 11958, "url": "https://patchwork.libcamera.org/api/1.1/patches/11958/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11958/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210416074909.24218-2-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-04-16T07:49:06", "name": "[libcamera-devel,v5,1/4] ipa: Add a common interface for algorithm objects", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "78f84aec74dbeb969fd8d611200c64125c47871e", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11958/mbox/", "series": [ { "id": 1938, "url": "https://patchwork.libcamera.org/api/1.1/series/1938/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1938", "date": "2021-04-16T07:49:05", "name": "Implement IPA algorithms and demo with IPU3", "version": 5, "mbox": "https://patchwork.libcamera.org/series/1938/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11958/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11958/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5ECAEBD235\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 16 Apr 2021 07:49:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E65D26880E;\n\tFri, 16 Apr 2021 09:49:14 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0570B68803\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 16 Apr 2021 09:49:13 +0200 (CEST)", "from localhost.localdomain (unknown\n\t[IPv6:2a01:e0a:169:7140:5b63:445c:7960:347a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7752D6F2;\n\tFri, 16 Apr 2021 09:49:12 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hiH9Wf/Z\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618559352;\n\tbh=VGhDvdOozrLwBj9ocsQecnLamsF1P2b0CqyFd4fsCA8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=hiH9Wf/ZW4flnicx7IW6cxCxvvG8T58xohVY2RcBSFDjiDOtCZ4EXwJHYhjKmy+Ti\n\tscBtfRMOCPC8nOgVCpfYSaFVRz68noyU/GpsubLCZKuPoXYcdedss92UBt/Eo4/d12\n\t2PIxzuvzojQBaBEg3AiJZt9vHCdL+us3cR09QxSY=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 16 Apr 2021 09:49:06 +0200", "Message-Id": "<20210416074909.24218-2-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210416074909.24218-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20210416074909.24218-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v5 1/4] ipa: Add a common interface for\n\talgorithm objects", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In order to instantiate and use algorithms (AWB, AGC, etc.)\nthere is a need for a common class to define mandatory methods.\n\nInstead of reinventing the wheel, reuse what Raspberry Pi has done and\nadapt to the minimum requirements expected.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/libipa/algorithm.cpp | 39 ++++++++++++++++++++++++++++++++++++\n src/ipa/libipa/algorithm.h | 24 ++++++++++++++++++++++\n src/ipa/libipa/meson.build | 4 +++-\n 3 files changed, 66 insertions(+), 1 deletion(-)\n create mode 100644 src/ipa/libipa/algorithm.cpp\n create mode 100644 src/ipa/libipa/algorithm.h", "diff": "diff --git a/src/ipa/libipa/algorithm.cpp b/src/ipa/libipa/algorithm.cpp\nnew file mode 100644\nindex 00000000..930f9353\n--- /dev/null\n+++ b/src/ipa/libipa/algorithm.cpp\n@@ -0,0 +1,39 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2021, Ideas On Board\n+ *\n+ * algorithm.cpp - ISP control algorithms\n+ */\n+\n+#include \"algorithm.h\"\n+\n+/**\n+ * \\file algorithm.h\n+ * \\brief Algorithm common interface\n+ */\n+\n+namespace libcamera {\n+\n+/**\n+ * \\brief The IPA namespace\n+ *\n+ * The IPA namespace groups all types specific to IPA modules. It serves as the\n+ * top-level namespace for the IPA library libipa, and also contains\n+ * module-specific namespaces for IPA modules.\n+ */\n+namespace ipa {\n+\n+/**\n+ * \\class Algorithm\n+ * \\brief The base class for all IPA algorithms\n+ *\n+ * The Algorithm class defines a standard interface for IPA algorithms. By\n+ * abstracting algorithms, it makes possible the implementation of generic code\n+ * to manage algorithms regardless of their specific type.\n+ */\n+\n+Algorithm::~Algorithm() = default;\n+\n+} /* namespace ipa */\n+\n+} /* namespace libcamera */\ndiff --git a/src/ipa/libipa/algorithm.h b/src/ipa/libipa/algorithm.h\nnew file mode 100644\nindex 00000000..89cee4c4\n--- /dev/null\n+++ b/src/ipa/libipa/algorithm.h\n@@ -0,0 +1,24 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2021, Ideas On Board\n+ *\n+ * algorithm.h - ISP control algorithm interface\n+ */\n+#ifndef __LIBCAMERA_IPA_LIBIPA_ALGORITHM_H__\n+#define __LIBCAMERA_IPA_LIBIPA_ALGORITHM_H__\n+\n+namespace libcamera {\n+\n+namespace ipa {\n+\n+class Algorithm\n+{\n+public:\n+\tvirtual ~Algorithm();\n+};\n+\n+} /* namespace ipa */\n+\n+} /* namespace libcamera */\n+\n+#endif /* __LIBCAMERA_IPA_LIBIPA_ALGORITHM_H__ */\ndiff --git a/src/ipa/libipa/meson.build b/src/ipa/libipa/meson.build\nindex b29ef0f4..1819711d 100644\n--- a/src/ipa/libipa/meson.build\n+++ b/src/ipa/libipa/meson.build\n@@ -1,13 +1,15 @@\n # SPDX-License-Identifier: CC0-1.0\n \n libipa_headers = files([\n+ 'algorithm.h',\n ])\n \n libipa_sources = files([\n+ 'algorithm.cpp',\n ])\n \n libipa_includes = include_directories('..')\n \n-libipa = static_library('ipa', libipa_sources,\n+libipa = static_library('ipa', [libipa_sources, libipa_headers],\n include_directories : ipa_includes,\n dependencies : libcamera_dep)\n", "prefixes": [ "libcamera-devel", "v5", "1/4" ] }