Patch Detail
Show a patch.
GET /api/1.1/patches/11947/?format=api
{ "id": 11947, "url": "https://patchwork.libcamera.org/api/1.1/patches/11947/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11947/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210415101741.1215178-1-naush@raspberrypi.com>", "date": "2021-04-15T10:17:42", "name": "[libcamera-devel] pipeline: raspberrypi: Fix typo in a comment", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ff67306a993d9f1e4420491b74bc9974936844ec", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11947/mbox/", "series": [ { "id": 1934, "url": "https://patchwork.libcamera.org/api/1.1/series/1934/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1934", "date": "2021-04-15T10:17:42", "name": "[libcamera-devel] pipeline: raspberrypi: Fix typo in a comment", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1934/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11947/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11947/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6DD3DBD224\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 15 Apr 2021 10:17:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8B1036880C;\n\tThu, 15 Apr 2021 12:17:55 +0200 (CEST)", "from mail-ed1-x530.google.com (mail-ed1-x530.google.com\n\t[IPv6:2a00:1450:4864:20::530])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2134F605AE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Apr 2021 12:17:54 +0200 (CEST)", "by mail-ed1-x530.google.com with SMTP id s15so27382264edd.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Apr 2021 03:17:53 -0700 (PDT)", "from naush-laptop.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\te12sm2076071edv.11.2021.04.15.03.17.52\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 15 Apr 2021 03:17:52 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"PbxXC/LN\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=b3eatZDCgsI1kFnVCfHq0Wjd0BC0RTxt2A4BaHUITXw=;\n\tb=PbxXC/LNb6t7NKCBZA0wivnu0GwMakbFSVm1OVzfQFkoaP96jHG/IW+kV7hxYVOgIa\n\tE+015mm2LzMGxpHb9wRRTfLVNuZrde+R7/VFr0mWcVdUSugNDduEzsa3drewN6TyiMxq\n\tjcyeLFFZsml+g+fdErVne5oMu910cVKTOaL/0OG1fyyWyxKUS//l2cyZOG4QM0nNPgub\n\te5mKZ8xuBDbYl2ZTFaspOuZa/JxTTFD4qZLLfOTisi9I3Cy5IczjRmRSv1YZVEkPZ1SC\n\tGEfaUSU0cbgaABf8i7Df1L4/VcYusfCCoJX+bsGvq4vHhUPcKln4dtBlTPqQpNeSs321\n\tVV3g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=b3eatZDCgsI1kFnVCfHq0Wjd0BC0RTxt2A4BaHUITXw=;\n\tb=o23dyOZrx20Q2yvEwyQfNagXDBT+Cey2G6QtDxP1MXrEM3yIqSr1Ge63hFgBgN42gZ\n\tdzUPDZykZM4+YAsDni4S26wzmy30pLPKBEKoLe+L7/9MVQsq6VoJwb1Kkn5X661Q2LRO\n\taz6EamOmz1C7ZYgyhL6Ev/3qlF1738dioNMfDwDtJo2hhIhhHFrBE41tXgc/6UEfqtNF\n\tNg8d9LcexObwqOaGx2DCjdl9Ye7alVYKN8/y84gILRoSNv5Ypfa2IufeYr3VA7yJc7QM\n\tioJLUYAwY4qqREpe8pPpN4lLLYxCpMFFOle+TTvK+kv+NMsv5xsufcV9UYy+8clP76gc\n\tV5Ow==", "X-Gm-Message-State": "AOAM533Rh6bFGTvG8Wmm1Yf9Pwu7bKyXn5L8q5abxQTkOb0xRB2z95H/\n\tGfxov55vEeE0h1PBUL8hy9O6V7fezwgotg==", "X-Google-Smtp-Source": "ABdhPJzFPfLJ1yWjiX/a+Bv6k/Sw6F9liQUb7Y/wgLtKwDTqWrA6Awgb8G1qZeX+++JP5lYwqhCGPw==", "X-Received": "by 2002:a05:6402:142:: with SMTP id\n\ts2mr3261054edu.2.1618481873236; \n\tThu, 15 Apr 2021 03:17:53 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 15 Apr 2021 11:17:42 +0100", "Message-Id": "<20210415101741.1215178-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] pipeline: raspberrypi: Fix typo in a\n\tcomment", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "s/embedded/bayer/\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex f22e286ed87a..2a917455500f 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -1802,7 +1802,7 @@ bool RPiCameraData::findMatchingBuffers(BayerFrame &bayerFrame, FrameBuffer *&em\n \t\t\t * pending embedded data buffers.\n \t\t\t */\n \t\t\tif (bayerRequeueCount == unicam_[Unicam::Image].getBuffers().size()) {\n-\t\t\t\t/* The embedded queue must be empty at this point! */\n+\t\t\t\t/* The bayer queue must be empty at this point! */\n \t\t\t\tASSERT(bayerQueue_.empty());\n \n \t\t\t\tLOG(RPI, Warning) << \"Flushing embedded data stream!\";\n", "prefixes": [ "libcamera-devel" ] }