Patch Detail
Show a patch.
GET /api/1.1/patches/11920/?format=api
{ "id": 11920, "url": "https://patchwork.libcamera.org/api/1.1/patches/11920/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11920/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210413215144.2733876-1-niklas.soderlund@ragnatech.se>", "date": "2021-04-13T21:51:44", "name": "[libcamera-devel] lc-compliance: Drop return value from SimpleCapture::stop()", "commit_ref": "58f558fddaf3d7d149ab1c320c2cee7c6948ec01", "pull_url": null, "state": "accepted", "archived": false, "hash": "ca91e039c6146ee166a49e53c424703e9502f9dd", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11920/mbox/", "series": [ { "id": 1923, "url": "https://patchwork.libcamera.org/api/1.1/series/1923/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1923", "date": "2021-04-13T21:51:44", "name": "[libcamera-devel] lc-compliance: Drop return value from SimpleCapture::stop()", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1923/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11920/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11920/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 346B0BD224\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Apr 2021 21:52:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AC3A3687D6;\n\tTue, 13 Apr 2021 23:51:59 +0200 (CEST)", "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1ABBB602D1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Apr 2021 23:51:57 +0200 (CEST)", "from bismarck.berto.se (p54ac5521.dip0.t-ipconnect.de\n\t[84.172.85.33])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 75cc6956-9ca2-11eb-a9ab-0050569116f7;\n\tTue, 13 Apr 2021 23:51:56 +0200 (CEST)" ], "X-Halon-ID": "75cc6956-9ca2-11eb-a9ab-0050569116f7", "Authorized-sender": "niklas.soderlund@fsdn.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 13 Apr 2021 23:51:44 +0200", "Message-Id": "<20210413215144.2733876-1-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] lc-compliance: Drop return value from\n\tSimpleCapture::stop()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The return value is never checked and serves to real usage, drop it.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/lc-compliance/simple_capture.cpp | 4 +---\n src/lc-compliance/simple_capture.h | 2 +-\n 2 files changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/lc-compliance/simple_capture.cpp b/src/lc-compliance/simple_capture.cpp\nindex 8f714d3b5e73e28e..811a6220009654be 100644\n--- a/src/lc-compliance/simple_capture.cpp\n+++ b/src/lc-compliance/simple_capture.cpp\n@@ -50,7 +50,7 @@ Results::Result SimpleCapture::start()\n \treturn { Results::Pass, \"Started camera\" };\n }\n \n-Results::Result SimpleCapture::stop()\n+void SimpleCapture::stop()\n {\n \tStream *stream = config_->at(0).stream();\n \n@@ -59,8 +59,6 @@ Results::Result SimpleCapture::stop()\n \tcamera_->requestCompleted.disconnect(this, &SimpleCapture::requestComplete);\n \n \tallocator_->free(stream);\n-\n-\treturn { Results::Pass, \"Stopped camera\" };\n }\n \n /* SimpleCaptureBalanced */\ndiff --git a/src/lc-compliance/simple_capture.h b/src/lc-compliance/simple_capture.h\nindex 4693c13404cee7d2..d9de53fb63a3ea3f 100644\n--- a/src/lc-compliance/simple_capture.h\n+++ b/src/lc-compliance/simple_capture.h\n@@ -24,7 +24,7 @@ protected:\n \tvirtual ~SimpleCapture();\n \n \tResults::Result start();\n-\tResults::Result stop();\n+\tvoid stop();\n \n \tvirtual void requestComplete(libcamera::Request *request) = 0;\n \n", "prefixes": [ "libcamera-devel" ] }