Patch Detail
Show a patch.
GET /api/1.1/patches/11918/?format=api
{ "id": 11918, "url": "https://patchwork.libcamera.org/api/1.1/patches/11918/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11918/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210413181226.17087-1-laurent.pinchart@ideasonboard.com>", "date": "2021-04-13T18:12:26", "name": "[libcamera-devel] libcamera: pipeline_handler: Fix typo in documentation", "commit_ref": "304ea65551b410a82b81dfd83e25b089ce158954", "pull_url": null, "state": "accepted", "archived": false, "hash": "50d48b21f6cc86bd650dcb7f87370bbe20823d80", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11918/mbox/", "series": [ { "id": 1921, "url": "https://patchwork.libcamera.org/api/1.1/series/1921/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1921", "date": "2021-04-13T18:12:26", "name": "[libcamera-devel] libcamera: pipeline_handler: Fix typo in documentation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1921/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11918/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11918/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 31A41BD1F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Apr 2021 18:13:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 900C1687FE;\n\tTue, 13 Apr 2021 20:13:21 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F309602D1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Apr 2021 20:13:20 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A31589F0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Apr 2021 20:13:19 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"n62sXn0W\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618337599;\n\tbh=9HXrPuSeqOQPnaHfqJORcCAH6kH+5VWf6gG752AllJI=;\n\th=From:To:Subject:Date:From;\n\tb=n62sXn0WwAKM/LuVoh9nYYnea3Hpi5kIBqqY0owIujWL/gnHDuCwUsKx1j+TZhDqJ\n\tat9hycJQpTD4hd1jUzQZ1hboZ/at0Sw8ab1Jg/BkOvk1gr4cznTa3WnjFb/Jd+vXEH\n\tzYjmf1um/5KaIf2q+JUwNLbsjt0/hfx4QzVVEFU4=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 13 Apr 2021 21:12:26 +0300", "Message-Id": "<20210413181226.17087-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.28.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: pipeline_handler: Fix typo in\n\tdocumentation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "There's no CameraConfiguration::valid(), the correct function is\nCameraConfiguration::validate().\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline_handler.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 433c05f60db0..03aa865f5b36 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -293,8 +293,8 @@ const ControlList &PipelineHandler::properties(const Camera *camera) const\n * application.\n *\n * The configuration is guaranteed to have been validated with\n- * CameraConfiguration::valid(). The pipeline handler implementation shall not\n- * perform further validation and may rely on any custom field stored in its\n+ * CameraConfiguration::validate(). The pipeline handler implementation shall\n+ * not perform further validation and may rely on any custom field stored in its\n * custom CameraConfiguration derived class.\n *\n * When configuring the camera the pipeline handler shall associate a Stream\n", "prefixes": [ "libcamera-devel" ] }