Patch Detail
Show a patch.
GET /api/1.1/patches/11911/?format=api
{ "id": 11911, "url": "https://patchwork.libcamera.org/api/1.1/patches/11911/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11911/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210413122534.342138-4-kieran.bingham@ideasonboard.com>", "date": "2021-04-13T12:25:34", "name": "[libcamera-devel,3/3] libcamera: pipeline_handler: Document requestSequence_", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4e2e2c606b1467e57e9b30ac05c44ad16dd09158", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11911/mbox/", "series": [ { "id": 1918, "url": "https://patchwork.libcamera.org/api/1.1/series/1918/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1918", "date": "2021-04-13T12:25:31", "name": "Documentation cleanup", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1918/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11911/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11911/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5324CBD22F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Apr 2021 12:25:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 985D36880E;\n\tTue, 13 Apr 2021 14:25:43 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D36F8687D6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Apr 2021 14:25:40 +0200 (CEST)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 676FF9F0;\n\tTue, 13 Apr 2021 14:25:40 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NqeDbmJY\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618316740;\n\tbh=SQXje+uGcTZktIAkTw5dMOiePQn76CiXjxmuBq61LVQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NqeDbmJYcdeaJKXMY9PJPb9dMuF88+FsHTswI6sP4BId6zovyh6tCf5dkhD0QASuu\n\tYR4fl5KLG6U0mLa8bAggFK2OEYFGbL1KSGSg+BjgOklIeHPKAMxDexFOfB7C+jNP2j\n\txTyyRPG85wsDtDRH8xMdN1V6HRcPOCVcI4pkI9mU=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 13 Apr 2021 13:25:34 +0100", "Message-Id": "<20210413122534.342138-4-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210413122534.342138-1-kieran.bingham@ideasonboard.com>", "References": "<20210413122534.342138-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 3/3] libcamera: pipeline_handler: Document\n\trequestSequence_", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The documentation for requestSequence_ was not added when the sequence\nnumber was implemented.\n\nProvide it.\n\nFixes: d874b3e34173 (\"libcamera: request: Provide a sequence number\")\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline_handler.cpp | 11 +++++++++++\n 1 file changed, 11 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 433c05f60db0..43395b57d818 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -97,6 +97,17 @@ LOG_DEFINE_CATEGORY(Pipeline)\n * when creating the camera, and shall not be modified afterwards.\n */\n \n+/**\n+ * \\var CameraData::requestSequence_\n+ * \\brief The queuing sequence of the request\n+ *\n+ * When requests are queued, they are given a per-camera sequence number to\n+ * facilitate debugging of internal request usage.\n+ *\n+ * The requestSequence_ tracks the number of requests queued to a camera\n+ * over its lifetime.\n+ */\n+\n /**\n * \\class PipelineHandler\n * \\brief Create and manage cameras based on a set of media devices\n", "prefixes": [ "libcamera-devel", "3/3" ] }