Patch Detail
Show a patch.
GET /api/1.1/patches/11895/?format=api
{ "id": 11895, "url": "https://patchwork.libcamera.org/api/1.1/patches/11895/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11895/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210413002731.25653-3-laurent.pinchart@ideasonboard.com>", "date": "2021-04-13T00:27:31", "name": "[libcamera-devel,2/2] libcamera: span: Fix reverse iterators", "commit_ref": "1ad214dd1b353e79923ec6d6dfd4246759e99407", "pull_url": null, "state": "accepted", "archived": false, "hash": "8bdf52c7c841d000b03e67d537122eb70c035d86", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11895/mbox/", "series": [ { "id": 1914, "url": "https://patchwork.libcamera.org/api/1.1/series/1914/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1914", "date": "2021-04-13T00:27:29", "name": "libcamera: Fix Span reverse iterators", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1914/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11895/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11895/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA805BD1F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Apr 2021 00:28:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 89A0268804;\n\tTue, 13 Apr 2021 02:28:27 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 564C9605AE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Apr 2021 02:28:25 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EB2116F2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Apr 2021 02:28:24 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Neb6EcGd\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618273705;\n\tbh=stdg1CduJtJEBdrUMvTKd0z7XLLVFtmpyjDtsdydaXI=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Neb6EcGdjMUNGH/9tU/ftUcNITlB3BprlltNGr9eL2fsZWgDt9EP9ivUMaj/5g2kl\n\t+tJMpB/ntrVkX6XyM6scIj9Z4jz8+GqmlByvATP3a6fSUTKv242KWJvsZ4Qf1LIX5M\n\tMgw+2rfZJmjUXnyaJhz/409+/VE7Q6joky8/teAY=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 13 Apr 2021 03:27:31 +0300", "Message-Id": "<20210413002731.25653-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.28.1", "In-Reply-To": "<20210413002731.25653-1-laurent.pinchart@ideasonboard.com>", "References": "<20210413002731.25653-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 2/2] libcamera: span: Fix reverse iterators", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "std::reverse_iterator<iterator> is constructed from an instance of\niterator, and automatically subtract 1 when dereferencing. rbegin() and\nrend() should thus be constructed from end() and begin() respectively.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/span.h | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/include/libcamera/span.h b/include/libcamera/span.h\nindex 91e9f974cc58..7a35806b1710 100644\n--- a/include/libcamera/span.h\n+++ b/include/libcamera/span.h\n@@ -194,9 +194,9 @@ public:\n \tconstexpr const_iterator cbegin() const { return begin(); }\n \tconstexpr iterator end() const { return data() + size(); }\n \tconstexpr const_iterator cend() const { return end(); }\n-\tconstexpr reverse_iterator rbegin() const { return reverse_iterator(data() + size() - 1); }\n+\tconstexpr reverse_iterator rbegin() const { return reverse_iterator(end()); }\n \tconstexpr const_reverse_iterator crbegin() const { return rbegin(); }\n-\tconstexpr reverse_iterator rend() const { return reverse_iterator(data() - 1); }\n+\tconstexpr reverse_iterator rend() const { return reverse_iterator(begin()); }\n \tconstexpr const_reverse_iterator crend() const { return rend(); }\n \n \tconstexpr reference front() const { return *data(); }\n@@ -360,9 +360,9 @@ public:\n \tconstexpr const_iterator cbegin() const { return begin(); }\n \tconstexpr iterator end() const { return data() + size(); }\n \tconstexpr const_iterator cend() const { return end(); }\n-\tconstexpr reverse_iterator rbegin() const { return reverse_iterator(data() + size() - 1); }\n+\tconstexpr reverse_iterator rbegin() const { return reverse_iterator(end()); }\n \tconstexpr const_reverse_iterator crbegin() const { return rbegin(); }\n-\tconstexpr reverse_iterator rend() const { return reverse_iterator(data() - 1); }\n+\tconstexpr reverse_iterator rend() const { return reverse_iterator(begin()); }\n \tconstexpr const_reverse_iterator crend() const { return rend(); }\n \n \tconstexpr reference front() const { return *data(); }\n", "prefixes": [ "libcamera-devel", "2/2" ] }