Patch Detail
Show a patch.
GET /api/1.1/patches/11891/?format=api
{ "id": 11891, "url": "https://patchwork.libcamera.org/api/1.1/patches/11891/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11891/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210412225841.13724-1-laurent.pinchart@ideasonboard.com>", "date": "2021-04-12T22:58:41", "name": "[libcamera-devel] libcamera: signal: Fix return value template type of BoundMethodMember", "commit_ref": "ab8db44efb09c54c402d027bbf980b0249958429", "pull_url": null, "state": "accepted", "archived": false, "hash": "f9f79c6cdbfde46e38a62fc0c801321b5131dc57", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11891/mbox/", "series": [ { "id": 1912, "url": "https://patchwork.libcamera.org/api/1.1/series/1912/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1912", "date": "2021-04-12T22:58:41", "name": "[libcamera-devel] libcamera: signal: Fix return value template type of BoundMethodMember", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1912/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11891/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11891/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0405ABD1F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 12 Apr 2021 22:59:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 66D92687FF;\n\tTue, 13 Apr 2021 00:59:40 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9EC56605AE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Apr 2021 00:59:38 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2DC146F2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Apr 2021 00:59:38 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"d7+mvldE\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618268378;\n\tbh=J8iE2siTuwwnsC1qleTtvT++pI2rb3Z0aXt2vf5Jp5Y=;\n\th=From:To:Subject:Date:From;\n\tb=d7+mvldEQlwlIcZaoGLfo5xSLRQ976Jbk4MnxlA+p+lK2bUa5fiRMJLNotOEq3ybX\n\tt38kQQT+cYDd7sidfc9JKF2CzIaapyAC1deB7Zc2zBQyqGSShOIPZzp3liSHAM86Bj\n\tLmQgGPQ+0Fye3tW0MjAfRwHKUJcXqkA6bmrsMaSg=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 13 Apr 2021 01:58:41 +0300", "Message-Id": "<20210412225841.13724-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.28.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: signal: Fix return value\n\ttemplate type of BoundMethodMember", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The BoundMethodMember instance created in Signal::connect() for\nreceivers inheriting from the Object class incorrectly sets the return\ntype to void instead of R. This doesn't cause any functional issue as\nthe return type is ignored anyway for signals, but should be fixed\nnonetheless.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/signal.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/signal.h b/include/libcamera/signal.h\nindex 5bcd7a77c5f1..3233529a1275 100644\n--- a/include/libcamera/signal.h\n+++ b/include/libcamera/signal.h\n@@ -49,7 +49,7 @@ public:\n \t\t ConnectionType type = ConnectionTypeAuto)\n \t{\n \t\tObject *object = static_cast<Object *>(obj);\n-\t\tSignalBase::connect(new BoundMethodMember<T, void, Args...>(obj, object, func, type));\n+\t\tSignalBase::connect(new BoundMethodMember<T, R, Args...>(obj, object, func, type));\n \t}\n \n \ttemplate<typename T, typename R, typename std::enable_if_t<!std::is_base_of<Object, T>::value> * = nullptr>\n", "prefixes": [ "libcamera-devel" ] }