Patch Detail
Show a patch.
GET /api/1.1/patches/11859/?format=api
{ "id": 11859, "url": "https://patchwork.libcamera.org/api/1.1/patches/11859/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11859/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210407145309.16877-1-laurent.pinchart@ideasonboard.com>", "date": "2021-04-07T14:53:09", "name": "[libcamera-devel] libcamera: bound_method: Fix type of pack for void methods", "commit_ref": "9b2544d3df481bc9dd0795fb645b544ba6484216", "pull_url": null, "state": "accepted", "archived": false, "hash": "4f61825b5c8c1f31f2505d80877b08bb39de67b9", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11859/mbox/", "series": [ { "id": 1901, "url": "https://patchwork.libcamera.org/api/1.1/series/1901/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1901", "date": "2021-04-07T14:53:09", "name": "[libcamera-devel] libcamera: bound_method: Fix type of pack for void methods", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1901/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11859/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11859/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4543BBD224\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 7 Apr 2021 14:54:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B7CFC687A2;\n\tWed, 7 Apr 2021 16:53:59 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3BA88687A1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 7 Apr 2021 16:53:58 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B009788F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 7 Apr 2021 16:53:57 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QV7asBZG\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1617807237;\n\tbh=W0BRucsyJGf88JUTp5QRVJ/N71jcgsQ0uUaLWigE/YU=;\n\th=From:To:Subject:Date:From;\n\tb=QV7asBZGW19FjydXpc916IOvEIsGGeJ+71A1dCnG1NVdX+s5K4/75rYf212psTE0h\n\telP9gtjs3iuRbf8qNqy+CuwOF9sW7q0grFRkliksMhxbJ9PKfzH9fI27qRbmRbX5Gu\n\tHV25iX3wKWhuboA8ewWm/uE9y3bt/pX18DA1awtk=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 7 Apr 2021 17:53:09 +0300", "Message-Id": "<20210407145309.16877-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.28.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: bound_method: Fix type of pack\n\tfor void methods", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The BoundMethodPack used by the void BoundMethodArgs variant incorrectly\nspecified the template argument as void * instead of void. This causes\nno functional problem, but results in space for an unused void * return\nvalue being reserved. Fix it.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/bound_method.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\nindex 95a956530877..f216e3b56826 100644\n--- a/include/libcamera/bound_method.h\n+++ b/include/libcamera/bound_method.h\n@@ -174,7 +174,7 @@ template<typename T, typename... Args>\n class BoundMethodMember<T, void, Args...> : public BoundMethodArgs<void, Args...>\n {\n public:\n-\tusing PackType = typename BoundMethodArgs<void *, Args...>::PackType;\n+\tusing PackType = typename BoundMethodArgs<void, Args...>::PackType;\n \n \tBoundMethodMember(T *obj, Object *object, void (T::*func)(Args...),\n \t\t\t ConnectionType type = ConnectionTypeAuto)\n", "prefixes": [ "libcamera-devel" ] }