Patch Detail
Show a patch.
GET /api/1.1/patches/11853/?format=api
{ "id": 11853, "url": "https://patchwork.libcamera.org/api/1.1/patches/11853/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11853/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210406182335.85847-3-nfraprado@collabora.com>", "date": "2021-04-06T18:23:34", "name": "[libcamera-devel,2/3] libcamera: pipeline: rkisp1: Assert empty queuedRequests before clearing frameInfo", "commit_ref": "63dd6a832722f801e93286f03428061dd0b16c00", "pull_url": null, "state": "accepted", "archived": false, "hash": "00e48cd2540def822e88105b81684a3f07d0d841", "submitter": { "id": 84, "url": "https://patchwork.libcamera.org/api/1.1/people/84/?format=api", "name": "Nícolas F. R. A. Prado", "email": "nfraprado@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11853/mbox/", "series": [ { "id": 1897, "url": "https://patchwork.libcamera.org/api/1.1/series/1897/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1897", "date": "2021-04-06T18:23:32", "name": "libcamera: pipeline: rkisp1: Fix issues exposed by lc-compliance", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1897/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11853/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11853/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C135C0DA5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 6 Apr 2021 18:24:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 57E7B687D4;\n\tTue, 6 Apr 2021 20:24:25 +0200 (CEST)", "from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C77C26084F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 6 Apr 2021 20:24:24 +0200 (CEST)", "from localhost.localdomain (unknown\n\t[IPv6:2804:14c:1a0:2f63:ddd7:19a9:2dbb:5548])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nfraprado)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 0C7941F445E8;\n\tTue, 6 Apr 2021 19:24:21 +0100 (BST)" ], "From": "=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= <nfraprado@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 6 Apr 2021 15:23:34 -0300", "Message-Id": "<20210406182335.85847-3-nfraprado@collabora.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210406182335.85847-1-nfraprado@collabora.com>", "References": "<20210406182335.85847-1-nfraprado@collabora.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 2/3] libcamera: pipeline: rkisp1: Assert\n\tempty queuedRequests before clearing frameInfo", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Collabora Kernel ML <kernel@collabora.com>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Assert that there are no queued requests before clearing the frameInfo,\notherwise a SEGFAULT can occur.\n\nThis issue happened while running lc-compliance.\n\nSuggested-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex c122c9be2afd..3c8d9dfe6f87 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -842,6 +842,7 @@ void PipelineHandlerRkISP1::stop(Camera *camera)\n \t\tLOG(RkISP1, Warning)\n \t\t\t<< \"Failed to stop parameters for \" << camera->id();\n \n+\tASSERT(data->queuedRequests_.empty());\n \tdata->frameInfo_.clear();\n \n \tfreeBuffers(camera);\n", "prefixes": [ "libcamera-devel", "2/3" ] }