Patch Detail
Show a patch.
GET /api/1.1/patches/11845/?format=api
{ "id": 11845, "url": "https://patchwork.libcamera.org/api/1.1/patches/11845/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11845/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210406104050.23814-3-david.plowman@raspberrypi.com>", "date": "2021-04-06T10:40:50", "name": "[libcamera-devel,v2,2/2] libcamera: pipeline: raspberrypi: Update ControlInfos after sensor format change", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c78bc201b54de7b7e50e940295788ab7d96e7a23", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11845/mbox/", "series": [ { "id": 1895, "url": "https://patchwork.libcamera.org/api/1.1/series/1895/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1895", "date": "2021-04-06T10:40:48", "name": "Fix CameraSensor::sensorInfo by updating VBLANK ControlInfo", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1895/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11845/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11845/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D0AB8C0DA6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 6 Apr 2021 10:41:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6F42B68786;\n\tTue, 6 Apr 2021 12:41:02 +0200 (CEST)", "from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com\n\t[IPv6:2a00:1450:4864:20::62b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 429A360518\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 6 Apr 2021 12:41:00 +0200 (CEST)", "by mail-ej1-x62b.google.com with SMTP id qo10so10751801ejb.6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 06 Apr 2021 03:41:00 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tdf8sm4068486edb.4.2021.04.06.03.40.59\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 06 Apr 2021 03:40:59 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"fEnISpvn\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=pHWsuaUAOfYCTjB2UPiy2vk4CMfqOc1BkAGZ1TZWZmk=;\n\tb=fEnISpvn3IJv57Qda3m5JWKAFl6BEh8bcp3MnYUxREe4LQyiSVyC3ouR/ETX8rTZow\n\tLCL9fgDmC3CF0b/OhZANOq6cxek7a0nM3c3CEl9BhPAlBBBeUxXpNfmV8dTTWKeGhs7q\n\thh52FSyDDH8l8gw1tlv8JeO083AdpYOrXUEuSkeX2IKMz6YkkiVclmNfvbABo+VpUAN2\n\tEfTI3b9fZ46C8nvpUaYno9m+yvMuKzJ5QtMf1tkOvGMa2c+mPS16YU9TW6cGvS2wBWw5\n\tCDZLb6lptaZyCh3LCEcZA+/5gYvf4gPD+kW3tf93k/BsGw0GVw0JsRjPThJu6wVVGDla\n\tXEcg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=pHWsuaUAOfYCTjB2UPiy2vk4CMfqOc1BkAGZ1TZWZmk=;\n\tb=jj/W4TrshTye6+oh6fT+54EyIgg95pHdqd26oc7S15KGNEVwaDOB/qwCPZm5Xsq0hx\n\t1XN3GsPkGpOlhUfwesOQkFenQ2Efh9YKWYf2ULVRnSrW1XYVaUbWWiS/1RmWEtWCQc7S\n\tLjsPAqnLCNY8iN2vtobQCTCGPRYf8M4QK6ii+p2+0MWW9xwS7qc7m5IrcByykbCIh6Xz\n\ttRyrTitcsKqFOoUTRUTGWfAY7ZnwHligBHRSGODdWlkgNkIBh4LN9akg7WKD+dEEOcao\n\tVMZSGMMxqSnvuUvz+yxVVOFCwJi6qMSTe02/EM9PvcYFTeGfLwyHaoSuRm+n+yG1MbQR\n\tlt/g==", "X-Gm-Message-State": "AOAM533m9AfSfEWwloivv/k6wVFjcYWm09LhA9v/2hdbZRwoPM+9+1NU\n\tn3lV36npkbBqo/H8NsFM7AdFZyDAWtNbOg==", "X-Google-Smtp-Source": "ABdhPJy5hLLNyCk0ixOSSvQ71o6MjsQA6OUQHywFy/vfGdqWV5Rnm+5eflSrijD32nYILreHoRNnkQ==", "X-Received": "by 2002:a17:906:b53:: with SMTP id\n\tv19mr15897919ejg.542.1617705659776; \n\tTue, 06 Apr 2021 03:40:59 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 6 Apr 2021 11:40:50 +0100", "Message-Id": "<20210406104050.23814-3-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20210406104050.23814-1-david.plowman@raspberrypi.com>", "References": "<20210406104050.23814-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 2/2] libcamera: pipeline: raspberrypi:\n\tUpdate ControlInfos after sensor format change", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Raspberry Pi pipeline handler does not update the sensor format\nusing CameraSensor::setFormat, so it must manually force the update of\nthe associated ControlInfos.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex f22e286e..bbcc15ec 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -608,6 +608,12 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n \tif (ret)\n \t\treturn ret;\n \n+\t/*\n+\t * The control ranges associated with the sensor may need updating\n+\t * after a format change.\n+\t */\n+\tdata->sensor_->updateControlInfos();\n+\n \tLOG(RPI, Info) << \"Sensor: \" << camera->id()\n \t\t << \" - Selected mode: \" << sensorFormat.toString();\n \n", "prefixes": [ "libcamera-devel", "v2", "2/2" ] }