Patch Detail
Show a patch.
GET /api/1.1/patches/11834/?format=api
{ "id": 11834, "url": "https://patchwork.libcamera.org/api/1.1/patches/11834/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11834/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210403235838.21594-1-laurent.pinchart@ideasonboard.com>", "date": "2021-04-03T23:58:38", "name": "[libcamera-devel] android: mm: cros: Fix compilation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c37ded63324b03aaef2958dc2ed7c783f001fb42", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11834/mbox/", "series": [ { "id": 1890, "url": "https://patchwork.libcamera.org/api/1.1/series/1890/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1890", "date": "2021-04-03T23:58:38", "name": "[libcamera-devel] android: mm: cros: Fix compilation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1890/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11834/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11834/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52586BD695\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 3 Apr 2021 23:59:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A6873602E5;\n\tSun, 4 Apr 2021 01:59:28 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B70F0602CE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 4 Apr 2021 01:59:26 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8A0FA8A0;\n\tSun, 4 Apr 2021 01:59:25 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pnRs0jCX\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1617494366;\n\tbh=XAlW/gI0gkPsYbb08d5glB9ozdcaSoFM7ry3lWt3G58=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=pnRs0jCXO1u2J+Ln+JHbHgjmbmiw7O0CHH9Q+l1xfoxmKO+bJHIZm4F/eE/qgDSa0\n\tgYXx7hYGvvTEUWtE3jQAmzg9lVUoQuimn2TbobS3Bib7oy6pBpzQrQq8ZjPAiu0c/A\n\t5X0+Doo2x3WdmQaSJqFsS27oNGkIs6vAxdmpw0dQ=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 4 Apr 2021 02:58:38 +0300", "Message-Id": "<20210403235838.21594-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.28.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] android: mm: cros: Fix compilation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Commit 7d7879833812 (\"android: mm: cros: Handle buffer registration\nfailure\") mistakenly tried to initialize the CameraBuffer::Private\nregistered member variable instead of registered_. This reults in a\ncompilation failure. Fix it.\n\nFixes: 7d7879833812 (\"android: mm: cros: Handle buffer registration failure\")\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/android/mm/cros_camera_buffer.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\nI failed to catch this before pushing :-( Sorry. I'll push the fix right\naway to fix the compilation breakage.", "diff": "diff --git a/src/android/mm/cros_camera_buffer.cpp b/src/android/mm/cros_camera_buffer.cpp\nindex 2a82d4b7c470..1a4fd5d1dfe3 100644\n--- a/src/android/mm/cros_camera_buffer.cpp\n+++ b/src/android/mm/cros_camera_buffer.cpp\n@@ -50,7 +50,7 @@ private:\n CameraBuffer::Private::Private(CameraBuffer *cameraBuffer,\n \t\t\t buffer_handle_t camera3Buffer, int flags)\n \t: Extensible::Private(cameraBuffer), handle_(camera3Buffer),\n-\t numPlanes_(0), valid_(false), registered(false)\n+\t numPlanes_(0), valid_(false), registered_(false)\n {\n \tbufferManager_ = cros::CameraBufferManager::GetInstance();\n \n", "prefixes": [ "libcamera-devel" ] }