Patch Detail
Show a patch.
GET /api/1.1/patches/11787/?format=api
{ "id": 11787, "url": "https://patchwork.libcamera.org/api/1.1/patches/11787/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11787/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210330062736.391600-1-hiroh@chromium.org>", "date": "2021-03-30T06:27:36", "name": "[libcamera-devel] libcamera: CameraData: Change queuedRequests_ type to std::dequeue", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "85dd79d8047a173e79826ca42b2c52ada41b2640", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/1.1/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11787/mbox/", "series": [ { "id": 1868, "url": "https://patchwork.libcamera.org/api/1.1/series/1868/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1868", "date": "2021-03-30T06:27:36", "name": "[libcamera-devel] libcamera: CameraData: Change queuedRequests_ type to std::dequeue", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1868/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11787/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11787/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1E695C32EA\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 30 Mar 2021 06:27:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5E0DC68782;\n\tTue, 30 Mar 2021 08:27:47 +0200 (CEST)", "from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com\n\t[IPv6:2607:f8b0:4864:20::42e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16C20602D7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Mar 2021 08:27:46 +0200 (CEST)", "by mail-pf1-x42e.google.com with SMTP id l123so11443175pfl.8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Mar 2021 23:27:45 -0700 (PDT)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:c112:2822:484f:486])\n\tby smtp.gmail.com with ESMTPSA id\n\t202sm18554884pfu.46.2021.03.29.23.27.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 29 Mar 2021 23:27:43 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"mxBF+7Q4\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=AxAEdE0s8KVO8nA/f8PNyhdGjLuWWQo/q0x3H/1QTHs=;\n\tb=mxBF+7Q412KAIJgSY1N2GaCPZyE3vzgu0ExUwjdzGe4PJzk9skQpGDhx4RPfK7WE/V\n\tmdRUpIuwRL1NFV7subaD0ejwGzA8DtM9xB2wPNpLSRR01ohX09oqiJkFqYO8n54eBMps\n\tEQiDPINs63x8u3kImOsjSzIs9cEFWuBPqTulc=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=AxAEdE0s8KVO8nA/f8PNyhdGjLuWWQo/q0x3H/1QTHs=;\n\tb=MmkipNVjjjCYrpvTIHP+ccQMelOR8u0onDAm/ZZn/sSvZ76Nmc7+OI4uf5EaQgwC7X\n\twSbxkZJL4VF/fa3ztFDEFiNw79WAtMAMdBK4z1WFXjY2PuhNT5LzKJ1lzKZjBW0rn1Hj\n\to9OleNnfYXiyNLGii4YAYMYDg5IkUkknK1L+F59d0RRQAfQJlQL1S7Ne2mJQG8aN11O/\n\tVDO1qK220vJB08PLGzZIBKEdKLTYFUtK/U26+iFCaPVVeoSfdkdjp4rbsi1IKfKFD9Co\n\tHpyupz4VybxUCqyYqASBkYrvMY5XvZVrALGRJ5hC1zp+3jB3u/CqEu39prfd9ee0ZSEw\n\tmwgg==", "X-Gm-Message-State": "AOAM530gpxKPhTIa1QF2X7XjLHppKPr72FZg4khzxOsNhzrFDdi/9yGs\n\tHIdaZJ9UiRKx8ijK27ecr48mwPw5llyewg==", "X-Google-Smtp-Source": "ABdhPJyuSzWKArtv0WsTWZHbWXPS55SyU7G24FPYZLNyep1OFazimgB0bvq/LtWVoNJCmIbsRw4Nqg==", "X-Received": "by 2002:a62:528e:0:b029:1f5:c5ee:a487 with SMTP id\n\tg136-20020a62528e0000b02901f5c5eea487mr27973651pfb.7.1617085663999; \n\tMon, 29 Mar 2021 23:27:43 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 30 Mar 2021 15:27:36 +0900", "Message-Id": "<20210330062736.391600-1-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.31.0.291.g576ba9dcdaf-goog", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: CameraData: Change\n\tqueuedRequests_ type to std::dequeue", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "A more appropriate type is std::dequeue as requests are reported\nand removed in the order of queuing.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\nReviewed-by: Sebastian Fricke <sebastian.fricke@posteo.net>\n---\n include/libcamera/internal/pipeline_handler.h | 4 ++--\n src/libcamera/pipeline_handler.cpp | 8 ++++----\n 2 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex 9bdda8f3..ff9d88d8 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -7,9 +7,9 @@\n #ifndef __LIBCAMERA_INTERNAL_PIPELINE_HANDLER_H__\n #define __LIBCAMERA_INTERNAL_PIPELINE_HANDLER_H__\n \n-#include <list>\n #include <map>\n #include <memory>\n+#include <queue>\n #include <set>\n #include <string>\n #include <sys/types.h>\n@@ -44,7 +44,7 @@ public:\n \tvirtual ~CameraData() = default;\n \n \tPipelineHandler *pipe_;\n-\tstd::list<Request *> queuedRequests_;\n+\tstd::deque<Request *> queuedRequests_;\n \tControlInfoMap controlInfo_;\n \tControlList properties_;\n \ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex e3d4975d..0fe913e9 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -72,10 +72,10 @@ LOG_DEFINE_CATEGORY(Pipeline)\n \n /**\n * \\var CameraData::queuedRequests_\n- * \\brief The list of queued and not yet completed request\n+ * \\brief The queue of incomplete requests.\n *\n- * The list of queued request is used to track requests queued in order to\n- * ensure completion of all requests when the pipeline handler is stopped.\n+ * This queue is used to ensure that all requests are completed when the pipeline\n+ * handler is stopped.\n *\n * \\sa PipelineHandler::queueRequest(), PipelineHandler::stop(),\n * PipelineHandler::completeRequest()\n@@ -386,7 +386,7 @@ int PipelineHandler::queueRequest(Request *request)\n \n \tint ret = queueRequestDevice(camera, request);\n \tif (ret)\n-\t\tdata->queuedRequests_.remove(request);\n+\t\tdata->queuedRequests_.pop_back(request);\n \n \treturn ret;\n }\n", "prefixes": [ "libcamera-devel" ] }