Patch Detail
Show a patch.
GET /api/1.1/patches/11784/?format=api
{ "id": 11784, "url": "https://patchwork.libcamera.org/api/1.1/patches/11784/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11784/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210330052521.381550-5-hiroh@chromium.org>", "date": "2021-03-30T05:25:21", "name": "[libcamera-devel,v3,4/4] android: CameraDevice: Deny non ROTATION_0 stream configuration", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "4a80e3b24225cbcb0254d37cc2f6b92900679105", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/1.1/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11784/mbox/", "series": [ { "id": 1866, "url": "https://patchwork.libcamera.org/api/1.1/series/1866/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1866", "date": "2021-03-30T05:25:17", "name": "Regard crop_rotate_scale_degrees in configuration", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1866/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11784/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11784/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 752DBC32F0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 30 Mar 2021 05:25:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2F3C36878D;\n\tTue, 30 Mar 2021 07:25:38 +0200 (CEST)", "from mail-pf1-x430.google.com (mail-pf1-x430.google.com\n\t[IPv6:2607:f8b0:4864:20::430])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4EEEF602D7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Mar 2021 07:25:35 +0200 (CEST)", "by mail-pf1-x430.google.com with SMTP id v10so6013036pfn.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Mar 2021 22:25:35 -0700 (PDT)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:c112:2822:484f:486])\n\tby smtp.gmail.com with ESMTPSA id\n\tu79sm19726006pfc.207.2021.03.29.22.25.32\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 29 Mar 2021 22:25:33 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"YPRBJECO\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=gVOz5jVRMv2He7b+Ik480Ku/8IyMwqhHk6RVu2nSBAE=;\n\tb=YPRBJECOgk6oBmnYpt6bCjtCtrD7CeDx6bJhBkYt/47hS2xce/YTqGTJhlOChlV++I\n\thPwY3xmLfBJoM7l8yvUOHQITsY1H6cfKOlKvfkBzezoA8OLJ5JPIVFPlSP4RQPxSXRy8\n\t7JUZHxdw1hBRRDo7GiY1xKhQExhobcW9pCZjM=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=gVOz5jVRMv2He7b+Ik480Ku/8IyMwqhHk6RVu2nSBAE=;\n\tb=c8OQglgnpK5XYY60FFT3AOsRguI8lewdrZTIXz0RJX/XVTKsNCDDxeRdusvXFmabzi\n\tZvhQtX5jCjtqLEajjvK3v3wrIN67AVetoyIvS4/OBs/KqFeKuGVB4fCbPCX78q7cSKQv\n\tB8ge84p33x+09/6qGmbVykHXOulSq+K2QVEqTQaqTEzeOMMY066rnk5/kKTrJd3PoXWN\n\tdHVdSzrVTeIWHBsw8XMvGFmn/YBtOvvFUoJ7AGRTawNn0gQa+acYTiTMEDk+DZ9uedcU\n\tg/uJZnHarNsEEIbkNXmSvHTjzixHXlMmBNJ/hxjrhr3st8Twyxv04Us5ta6utzW3pklm\n\tXe1w==", "X-Gm-Message-State": "AOAM532vbXEL7eUaGpXzADPz5WGK1yEelXvRTonpYz7Xwrg/AUj1htEo\n\tPQX4LK6mca9Cxm1WGW/yBqLv4H+Y0t699A==", "X-Google-Smtp-Source": "ABdhPJzKF862Pl+SD7yCMeO6d5McPzeIbSfo6++Ptd1kDJg2IOnRn1Kx5lKXkejmGoXZPHcJKn/1jg==", "X-Received": "by 2002:a62:6883:0:b029:220:4426:449c with SMTP id\n\td125-20020a6268830000b02902204426449cmr25257365pfc.14.1617081933782; \n\tMon, 29 Mar 2021 22:25:33 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 30 Mar 2021 14:25:21 +0900", "Message-Id": "<20210330052521.381550-5-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.31.0.291.g576ba9dcdaf-goog", "In-Reply-To": "<20210330052521.381550-1-hiroh@chromium.org>", "References": "<20210330052521.381550-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 4/4] android: CameraDevice: Deny non\n\tROTATION_0 stream configuration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "libcamera doesn't handle crop_rotate_scale_degrees. Therefore,\nif it is requested, that is, crop_rotate_scale_degrees is not\nCAMERA3_STREAM_ROTATION_0, the configuration should fail.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_device.cpp | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex e0eaa3b5..344522ba 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1657,6 +1657,18 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n \t\tif (!format.isValid())\n \t\t\treturn -EINVAL;\n \n+\t\t/* \\todo Support rotation. */\n+\t\tif (stream->rotation != CAMERA3_STREAM_ROTATION_0) {\n+\t\t\tLOG(HAL, Error) << \"Rotation is not supported\";\n+\t\t\treturn -EINVAL;\n+\t\t}\n+#if defined(CHROMEOS)\n+\t\tif (stream->crop_rotate_scale_degrees != CAMERA3_STREAM_ROTATION_0) {\n+\t\t\tLOG(HAL, Error) << \"Rotation is not supported\";\n+\t\t\treturn -EINVAL;\n+\t\t}\n+#endif\n+\n \t\t/* Defer handling of MJPEG streams until all others are known. */\n \t\tif (stream->format == HAL_PIXEL_FORMAT_BLOB) {\n \t\t\tif (jpegStream) {\n", "prefixes": [ "libcamera-devel", "v3", "4/4" ] }