Patch Detail
Show a patch.
GET /api/1.1/patches/11709/?format=api
{ "id": 11709, "url": "https://patchwork.libcamera.org/api/1.1/patches/11709/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11709/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210325134231.1400051-2-kieran.bingham@ideasonboard.com>", "date": "2021-03-25T13:42:19", "name": "[libcamera-devel,11/11] libcamera: pipeline: ipu3: frames: Use the request sequence", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9114ef6346055ae9a65e4b3789ccfb1ec15eed03", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/1.1/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/11709/mbox/", "series": [ { "id": 1832, "url": "https://patchwork.libcamera.org/api/1.1/series/1832/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1832", "date": "2021-03-25T13:42:18", "name": "[libcamera-devel,v3,01/11] utils: ipc: proxy: Track IPA with a state machine", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1832/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11709/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11709/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5939BC32E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 25 Mar 2021 13:42:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 320F768D7A;\n\tThu, 25 Mar 2021 14:42:39 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9AE7D602D9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 25 Mar 2021 14:42:36 +0100 (CET)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7AA3A8C9;\n\tThu, 25 Mar 2021 14:42:35 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"durc1w8A\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616679755;\n\tbh=+eJVhfP/EG7xCEzMb3zus1otZQVQ8RQJ4sSGGnO+zY4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=durc1w8ASfSF9zCd9jVUmDH0AOdUAAM7+XAoWlCRQOztlF6C8+o2x7jvb5wwNLPvN\n\t0UX8y0ZPeTuSBWL/Qt5WtSW0eu68CHgqTurJqD7RP6I1FuGQPl3ilCHoWfnmcTzzif\n\twV2d9a7Q6iDUvzNsbCnaivff3VSFgwl7FYJdQcrI=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 25 Mar 2021 13:42:19 +0000", "Message-Id": "<20210325134231.1400051-2-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210325134231.1400051-1-kieran.bingham@ideasonboard.com>", "References": "<20210325134231.1400051-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 11/11] libcamera: pipeline: ipu3: frames:\n\tUse the request sequence", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "For all frame indexes, use the same sequence number as generated\nby the Request object.\n\nThis allows clear matching of what operations occurred to which request.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/ipu3/frames.cpp | 4 +---\n src/libcamera/pipeline/ipu3/frames.h | 1 -\n 2 files changed, 1 insertion(+), 4 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/frames.cpp b/src/libcamera/pipeline/ipu3/frames.cpp\nindex 34ab4be6711b..a1b014eed8d7 100644\n--- a/src/libcamera/pipeline/ipu3/frames.cpp\n+++ b/src/libcamera/pipeline/ipu3/frames.cpp\n@@ -18,7 +18,6 @@ namespace libcamera {\n LOG_DECLARE_CATEGORY(IPU3)\n \n IPU3Frames::IPU3Frames()\n-\t: nextId_(0)\n {\n }\n \n@@ -31,7 +30,6 @@ void IPU3Frames::init(const std::vector<std::unique_ptr<FrameBuffer>> ¶mBuff\n \tfor (const std::unique_ptr<FrameBuffer> &buffer : statBuffers)\n \t\tavailableStatBuffers_.push(buffer.get());\n \n-\tnextId_ = 0;\n \tframeInfo_.clear();\n }\n \n@@ -43,7 +41,7 @@ void IPU3Frames::clear()\n \n IPU3Frames::Info *IPU3Frames::create(Request *request)\n {\n-\tunsigned int id = nextId_++;\n+\tunsigned int id = request->sequence();\n \n \tif (availableParamBuffers_.empty()) {\n \t\tLOG(IPU3, Error) << \"Parameters buffer underrun\";\ndiff --git a/src/libcamera/pipeline/ipu3/frames.h b/src/libcamera/pipeline/ipu3/frames.h\nindex 106e5c15cc7a..4acdf48eca9d 100644\n--- a/src/libcamera/pipeline/ipu3/frames.h\n+++ b/src/libcamera/pipeline/ipu3/frames.h\n@@ -53,7 +53,6 @@ private:\n \tstd::queue<FrameBuffer *> availableParamBuffers_;\n \tstd::queue<FrameBuffer *> availableStatBuffers_;\n \n-\tunsigned int nextId_;\n \tstd::map<unsigned int, std::unique_ptr<Info>> frameInfo_;\n };\n \n", "prefixes": [ "libcamera-devel", "11/11" ] }