Patch Detail
Show a patch.
GET /api/1.1/patches/11705/?format=api
{ "id": 11705, "url": "https://patchwork.libcamera.org/api/1.1/patches/11705/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11705/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210325051931.3748204-4-hiroh@chromium.org>", "date": "2021-03-25T05:19:31", "name": "[libcamera-devel,3/3] android: CameraDevice: Deny non ROTATION_0 stream configuration", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "165127795420b7060d189be87da113bab5a0ad7e", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/1.1/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11705/mbox/", "series": [ { "id": 1830, "url": "https://patchwork.libcamera.org/api/1.1/series/1830/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1830", "date": "2021-03-25T05:19:28", "name": "Regard crop_rotate_scale_degrees in configuration", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1830/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11705/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11705/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BC930C32E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 25 Mar 2021 05:19:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5A1A068D68;\n\tThu, 25 Mar 2021 06:19:47 +0100 (CET)", "from mail-pf1-x431.google.com (mail-pf1-x431.google.com\n\t[IPv6:2607:f8b0:4864:20::431])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E16B268D68\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 25 Mar 2021 06:19:45 +0100 (CET)", "by mail-pf1-x431.google.com with SMTP id h3so808613pfr.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Mar 2021 22:19:45 -0700 (PDT)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:7c07:24cd:c637:7fab])\n\tby smtp.gmail.com with ESMTPSA id\n\tfs9sm3999250pjb.40.2021.03.24.22.19.43\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 24 Mar 2021 22:19:44 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"LCJpynPX\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=PjpQr3Vz3Da91peYZt+5pvwi3qlCZ3U2n1oIkOsHbBI=;\n\tb=LCJpynPX2ka49HcUuHNewW5sjGEvTq5WPZJPJrnIpKQIs2dlDtq+DVdNVO3UoNOhWy\n\txeISIQJ3WKg8o2oWt8gMD9nRd2eV/waeXmpSPdCSJGHrM5mFxZSIpweTyGQ4QPiaU6O+\n\tK4qqnjQgX4MQy8o/a7mG23UbUM8WwuvhFjeTc=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=PjpQr3Vz3Da91peYZt+5pvwi3qlCZ3U2n1oIkOsHbBI=;\n\tb=LVkwB3xNNJdO78KS8fTh3NrrfS7rV11RhmkjUaNwTvHXHqijjPqLLQ322BbiLTPIKW\n\tL3E0rU3KutOnbX3T0ddlEkskpNaywba0VGw6Kz+SrnfkErKgPXpjwNlLpb3r9Ta9ux9e\n\teKSp6jkbztJRLgV3SCVoG1nzVgYKz8P2PfCCW5OyrhyR9Bxft27SDzLfid0tJ/CAwILb\n\taGLQMUICX3ldTDwj4h3McuiJ2dE441edBGjOYKBjVniq20UvxLbdtOGB5DN/15xWUsae\n\tp1SKgay6gdsPYkwLOE5DOoP7nlLXyNlBOTF5lNrXdcQzUJSS036bPJtWu/D0h+T8vkej\n\t5kcA==", "X-Gm-Message-State": "AOAM531zjGlz+Ts5FN740VRmWrZH7KXaxN0TpzEmMTEg+2omtYKeq9wP\n\tvgrtCKKZ/ygv2+ZoZjrDWf7hLjp/m5jqWQ==", "X-Google-Smtp-Source": "ABdhPJwlTh/lFHZTyKrXcQCfz/rPvfI5ZfoGhHp2ZLh0CfhitiOXkAC3N3Q/v2iCTgrQ6NO8O0ainA==", "X-Received": "by 2002:a05:6a00:14cc:b029:200:5f06:2ded with SMTP id\n\tw12-20020a056a0014ccb02902005f062dedmr6337028pfu.65.1616649584406; \n\tWed, 24 Mar 2021 22:19:44 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 25 Mar 2021 14:19:31 +0900", "Message-Id": "<20210325051931.3748204-4-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.31.0.291.g576ba9dcdaf-goog", "In-Reply-To": "<20210325051931.3748204-1-hiroh@chromium.org>", "References": "<20210325051931.3748204-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 3/3] android: CameraDevice: Deny non\n\tROTATION_0 stream configuration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Libcamera doesn't handle crop_rotate_scale_degrees. Therefore,\nif it is requested, that is, crop_rotate_scale_degrees is not\nCAMERA3_STREAM_ROTATION_0, the configuration should fail.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\n---\n src/android/camera_device.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)\n\n--\n2.31.0.291.g576ba9dcdaf-goog", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex d24b0b23..3aab643d 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1657,6 +1657,13 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n \t\tif (!format.isValid())\n \t\t\treturn -EINVAL;\n\n+\t\t/* \\todo Support crop_rotate_scale_degrees. */\n+\t\tif (stream->crop_rotate_scale_degrees != CAMERA3_STREAM_ROTATION_0) {\n+\t\t\tLOG(HAL, Error)\n+\t\t\t\t<< \"crop_rotate_scale_degrees is not supported\";\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\n \t\t/* Defer handling of MJPEG streams until all others are known. */\n \t\tif (stream->format == HAL_PIXEL_FORMAT_BLOB) {\n \t\t\tif (jpegStream) {\n", "prefixes": [ "libcamera-devel", "3/3" ] }