Patch Detail
Show a patch.
GET /api/1.1/patches/11700/?format=api
{ "id": 11700, "url": "https://patchwork.libcamera.org/api/1.1/patches/11700/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11700/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210324150125.1318325-7-kieran.bingham@ideasonboard.com>", "date": "2021-03-24T15:01:25", "name": "[libcamera-devel,v3,6/6] ipa: ipu3: Do not set controls during configure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c0b9a8f560471cb55122196219ab072e496316e4", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/1.1/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/11700/mbox/", "series": [ { "id": 1828, "url": "https://patchwork.libcamera.org/api/1.1/series/1828/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1828", "date": "2021-03-24T15:01:19", "name": "IPU3 Stability", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1828/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11700/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11700/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 94681C32E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 24 Mar 2021 15:01:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 52CFA68D75;\n\tWed, 24 Mar 2021 16:01:38 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C64568D6D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Mar 2021 16:01:33 +0100 (CET)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C61388F3;\n\tWed, 24 Mar 2021 16:01:32 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"o8zAxJlC\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616598092;\n\tbh=iUvS2PpgzAjP5fRAdisbJ107L5bPd52IEECPc7Va/+s=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=o8zAxJlCe1A1NDj+h0g3N2zAbztneLBR/8Z4jxk2oISDu8EWpAl2BnpABLbjlKIct\n\tagNaijAl/GOQDknz8bdhVCj7ntyKA6a5GrIzs164VxCnOrbSccmYmXeBCdy2ROzkGZ\n\tQjcF/vTx/bp+SsGaHjKGoKsEAmnIUF6cS4F6J7Cg=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Wed, 24 Mar 2021 15:01:25 +0000", "Message-Id": "<20210324150125.1318325-7-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210324150125.1318325-1-kieran.bingham@ideasonboard.com>", "References": "<20210324150125.1318325-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 6/6] ipa: ipu3: Do not set controls\n\tduring configure", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The configure operation is synchronous and should not send events back\nto the pipeline handler.\n\nIf information needs to be returned from configure it should be handled\nthrough the interface directly.\n\nMove the initial call to setControls() out of configure() and into the\nstart() method which is called after the IPA running_ state is updated.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex a5c5e029f465..34a907f23ef5 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -32,7 +32,7 @@ public:\n \t{\n \t\treturn 0;\n \t}\n-\tint start() override { return 0; }\n+\tint start() override;\n \tvoid stop() override {}\n \n \tvoid configure(const std::map<uint32_t, ControlInfoMap> &entityControls,\n@@ -63,6 +63,13 @@ private:\n \tuint32_t maxGain_;\n };\n \n+int IPAIPU3::start()\n+{\n+\tsetControls(0);\n+\n+\treturn 0;\n+}\n+\n void IPAIPU3::configure(const std::map<uint32_t, ControlInfoMap> &entityControls,\n \t\t\t[[maybe_unused]] const Size &bdsOutputSize)\n {\n@@ -90,8 +97,6 @@ void IPAIPU3::configure(const std::map<uint32_t, ControlInfoMap> &entityControls\n \tminGain_ = std::max(itGain->second.min().get<int32_t>(), 1);\n \tmaxGain_ = itGain->second.max().get<int32_t>();\n \tgain_ = maxGain_;\n-\n-\tsetControls(0);\n }\n \n void IPAIPU3::mapBuffers(const std::vector<IPABuffer> &buffers)\n", "prefixes": [ "libcamera-devel", "v3", "6/6" ] }