Patch Detail
Show a patch.
GET /api/1.1/patches/11692/?format=api
{ "id": 11692, "url": "https://patchwork.libcamera.org/api/1.1/patches/11692/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11692/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210324114415.19866-2-david.plowman@raspberrypi.com>", "date": "2021-03-24T11:44:14", "name": "[libcamera-devel,1/2] ipa: raspberrypi: Make CamHelper exposure methods virtual", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7fa0a8cb40fac1ec7942491ae2dbd76623b110c3", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11692/mbox/", "series": [ { "id": 1827, "url": "https://patchwork.libcamera.org/api/1.1/series/1827/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1827", "date": "2021-03-24T11:44:13", "name": "Raspberry Pi: handle sensors more flexibly", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1827/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11692/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11692/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3A917C32E5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 24 Mar 2021 11:44:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 18CE168D6A;\n\tWed, 24 Mar 2021 12:44:22 +0100 (CET)", "from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com\n\t[IPv6:2a00:1450:4864:20::52e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 94BB86051A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Mar 2021 12:44:19 +0100 (CET)", "by mail-ed1-x52e.google.com with SMTP id w18so27308201edc.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Mar 2021 04:44:19 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tc17sm1054781edw.32.2021.03.24.04.44.18\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 24 Mar 2021 04:44:18 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"mNfJ43Ek\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=mrjhT2FmHfGM+ETL2c8tGFpgFd9U4oNZSbU5UloGtqs=;\n\tb=mNfJ43Eks3xUF3+HJsLeQlHFAy2AU2UcydD50SW2Fn6aE+jnr+nKSHDbeDiVdJsJwv\n\t4kEJhIKsIR/MUFhd5nwvpqKt0PqowGs3xrmfgyGEelLJK/N6pwCYWnUNMf9n99u1OIVk\n\t74jRUeqWrNYgMLp3sG+wjF9q+DeDHNQyV3AjdeXd5Lo4mPelHtzVrXtK0i56pyVgfzoF\n\t1WklXfJw5oUqVyaUWUvKVp8EWxrEcwImAIidzH2tAphqCs3Oocx4j3I7g4/vUpXsCpOT\n\tzaguXKpSd+7+xQdj7I/qkZ1+BpXeNEev3wpTowtY9YWMejdDfJqglf55H4BM5IBzlqZm\n\tGqHQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=mrjhT2FmHfGM+ETL2c8tGFpgFd9U4oNZSbU5UloGtqs=;\n\tb=raVvjNpJk1oWCW/DW8IZ6dTSHYEYcfpdu25oToJNTWrQ7jG3GSeiaXMs/iS5AE3E3K\n\tbbwyy0Wwj5YbW4XmEl3IZIcxfCaSuMuiK3uE5XrCG5B81KBupPZYTSaugTB0ObWHibUD\n\tB5d1m2d5h4QOYjenZgV0JB7/VqLoOZOz+9QKZu0ISw2aNnYBIx+jk+3yJN4ksO8COjTP\n\tKS0D/nAqHFK6fHWaPyQui04adn5+2T3L2X2zhIQI3/cEmvogINZHAvyDTwteNYXngRKy\n\tZZvOuk6qE/e7j6o9wtrf7bVvetgqtvZ9eUZR3aTMZr+mNnBoGRkaS99dm5/Xmy6Xvbx8\n\t6peQ==", "X-Gm-Message-State": "AOAM5308eamYOhTWOxRWsqxSoyqzmV5OGPhKZKEQSuBkmmTvHPwbvgT1\n\tCI02qcXcsxKHezBZsveEWjiQz4dFCgR/pg==", "X-Google-Smtp-Source": "ABdhPJwipaldQ0UbHtRg5u4PoBnIWSjDhneM08wVtrrD8s+7Vhvy+B3AB7OWsRpqOB3jSUNLen6+3w==", "X-Received": "by 2002:a05:6402:c0f:: with SMTP id\n\tco15mr2887198edb.373.1616586259043; \n\tWed, 24 Mar 2021 04:44:19 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 24 Mar 2021 11:44:14 +0000", "Message-Id": "<20210324114415.19866-2-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20210324114415.19866-1-david.plowman@raspberrypi.com>", "References": "<20210324114415.19866-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 1/2] ipa: raspberrypi: Make CamHelper\n\texposure methods virtual", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This allows derived classes to override them if they have any special\nbehaviours to implement. For instance if a particular camera mode\nproduces a different signal level to other modes, you might choose to\naddress that in the gain or exposure methods.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/raspberrypi/cam_helper.hpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp\nindex 1b2d6eec..4053a870 100644\n--- a/src/ipa/raspberrypi/cam_helper.hpp\n+++ b/src/ipa/raspberrypi/cam_helper.hpp\n@@ -66,8 +66,8 @@ public:\n \tvirtual ~CamHelper();\n \tvoid SetCameraMode(const CameraMode &mode);\n \tMdParser &Parser() const { return *parser_; }\n-\tuint32_t ExposureLines(double exposure_us) const;\n-\tdouble Exposure(uint32_t exposure_lines) const; // in us\n+\tvirtual uint32_t ExposureLines(double exposure_us) const;\n+\tvirtual double Exposure(uint32_t exposure_lines) const; // in us\n \tvirtual uint32_t GetVBlanking(double &exposure_us, double minFrameDuration,\n \t\t\t\t double maxFrameDuration) const;\n \tvirtual uint32_t GainCode(double gain) const = 0;\n", "prefixes": [ "libcamera-devel", "1/2" ] }