Patch Detail
Show a patch.
GET /api/1.1/patches/11662/?format=api
{ "id": 11662, "url": "https://patchwork.libcamera.org/api/1.1/patches/11662/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11662/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210323122739.680560-6-naush@raspberrypi.com>", "date": "2021-03-23T12:27:37", "name": "[libcamera-devel,v2,5/7] ipa: raspberrypi: Remove unused member variable", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "867c9e1c4263d1574d8cb99fc610b395aceb6773", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11662/mbox/", "series": [ { "id": 1821, "url": "https://patchwork.libcamera.org/api/1.1/series/1821/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1821", "date": "2021-03-23T12:27:32", "name": "Raspberry Pi: ipa::init() restructuring", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1821/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11662/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11662/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 678FBC32E5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Mar 2021 12:27:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 14E2168D74;\n\tTue, 23 Mar 2021 13:27:54 +0100 (CET)", "from mail-ed1-x535.google.com (mail-ed1-x535.google.com\n\t[IPv6:2a00:1450:4864:20::535])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 12C7968D63\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Mar 2021 13:27:49 +0100 (CET)", "by mail-ed1-x535.google.com with SMTP id h10so23181787edt.13\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Mar 2021 05:27:49 -0700 (PDT)", "from naush-laptop.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tu13sm11082295ejy.31.2021.03.23.05.27.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 23 Mar 2021 05:27:48 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Ms78kzWY\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=IBYOmNhWc9VLgjJTDXl+uYxRIPrJR5MK3Zb55BkFyfk=;\n\tb=Ms78kzWYh92HCLb/q5jAbav20/7Nfjdb/mimJi4ezoCQthDWsq25gKXeLlXlQsLAHm\n\tXxcK9JG6OD2bb0MQDO17XXYKZylEPBXBh99wlY3Kog0UpP1gpFKqoTehtFa5dTAzr0pg\n\t3QJm+Rn4VY/jWA3DU1o8w0fq2T2Mh5QwX/as639t9ShQkJ9K8L6J46Ur2JcpSqOFUoFZ\n\tGrEhyDv3Lmnj7bj5d+fBY93qG1mxmWtqQDSmLZbfrYv0csImOSc3XDx16KfCk9iG3B2E\n\t/vev+cM1c48Emyt1wytpaQ4soImcyHjT1gi9L8dBxT3xyd/VWF5chKFRxtLECrCzAxfQ\n\t3bWQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=IBYOmNhWc9VLgjJTDXl+uYxRIPrJR5MK3Zb55BkFyfk=;\n\tb=UPcP4nwrDGXoLdsbuccSBI0u6YvC2ppzqzEbeF1IpWaGTeR6tSjnflQ6IKOK3UFJBb\n\tI14fU+UiMhhSLVnQTntrpP0+9bCYawYO6mZC8EP6oc4E2yqo9hhbnWh1zfB6LsbGGVVV\n\tpnIM8nfWwi+QXGZZWPcGXhTg6UAX4ksjuPi34h2NoMWxOK78DW1WBxwoPuDaIBh9pw6c\n\tj9tioSYzHz5gJ5A8Vfwe8fcO6B9aYLWAaurNmtLGPjz/X2bNJZ4PwWI3NI4Dqa54Z46N\n\tarD1nMbTKzPfTrBp+C7QaSzqsyNaeOwQ21h5KqirxHGXAU67+v2Tz3scEvhOVBH1fugI\n\t82nQ==", "X-Gm-Message-State": "AOAM531BRa1sGs2poQuf6aWKonLCCZsIey+LG1fwj1xNjgoGO2kvTyUI\n\tYxp2dfpkcU/ceo/kp6KVs3QwaK3JT5z3RQ==", "X-Google-Smtp-Source": "ABdhPJx7lhFmtOCOCAnup7LXGpUpVlNQLLPPooB9U6mUIwdC88i7Ivk4vYv8vPaspUJk3eu5gu+wSA==", "X-Received": "by 2002:a05:6402:1d1a:: with SMTP id\n\tdg26mr4291130edb.266.1616502468449; \n\tTue, 23 Mar 2021 05:27:48 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 23 Mar 2021 12:27:37 +0000", "Message-Id": "<20210323122739.680560-6-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210323122739.680560-1-naush@raspberrypi.com>", "References": "<20210323122739.680560-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 5/7] ipa: raspberrypi: Remove unused\n\tmember variable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The lastMode_ member variable is now unused, so remove it.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nTested-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/raspberrypi/raspberrypi.cpp | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex bd20b144f520..93e43f0626fb 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -67,8 +67,8 @@ class IPARPi : public ipa::RPi::IPARPiInterface\n {\n public:\n \tIPARPi()\n-\t\t: lastMode_({}), controller_(), frameCount_(0), checkCount_(0),\n-\t\t mistrustCount_(0), lsTable_(nullptr), firstStart_(true)\n+\t\t: controller_(), frameCount_(0), checkCount_(0), mistrustCount_(0),\n+\t\t lsTable_(nullptr), firstStart_(true)\n \t{\n \t}\n \n@@ -128,7 +128,6 @@ private:\n \n \t/* Camera sensor params. */\n \tCameraMode mode_;\n-\tCameraMode lastMode_;\n \n \t/* Raspberry Pi controller specific defines. */\n \tstd::unique_ptr<RPiController::CamHelper> helper_;\n@@ -383,8 +382,6 @@ int IPARPi::configure(const CameraSensorInfo &sensorInfo,\n \t\tresult->controls = std::move(ctrls);\n \t}\n \n-\tlastMode_ = mode_;\n-\n \treturn 0;\n }\n \n", "prefixes": [ "libcamera-devel", "v2", "5/7" ] }