Patch Detail
Show a patch.
GET /api/1.1/patches/11644/?format=api
{ "id": 11644, "url": "https://patchwork.libcamera.org/api/1.1/patches/11644/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11644/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210322220910.3179457-1-hiroh@chromium.org>", "date": "2021-03-22T22:09:10", "name": "[libcamera-devel] libcamera: device_enumerator: Remove unnecessary rvalue references", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8fbed88f529a10d6da19654565ea4aa003e95f40", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/1.1/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11644/mbox/", "series": [ { "id": 1816, "url": "https://patchwork.libcamera.org/api/1.1/series/1816/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1816", "date": "2021-03-22T22:09:10", "name": "[libcamera-devel] libcamera: device_enumerator: Remove unnecessary rvalue references", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1816/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11644/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11644/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ADBDEC32E1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 22 Mar 2021 22:09:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 18B0468D66;\n\tMon, 22 Mar 2021 23:09:19 +0100 (CET)", "from mail-pg1-x533.google.com (mail-pg1-x533.google.com\n\t[IPv6:2607:f8b0:4864:20::533])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9AD1B68D62\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 22 Mar 2021 23:09:17 +0100 (CET)", "by mail-pg1-x533.google.com with SMTP id k24so9700465pgl.6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 22 Mar 2021 15:09:17 -0700 (PDT)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:8115:e5cc:747b:64de])\n\tby smtp.gmail.com with ESMTPSA id\n\tv26sm14226293pff.195.2021.03.22.15.09.14\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 22 Mar 2021 15:09:15 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"AjtD4S4o\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=gtDt9IQmG5dXc60NE2nDlS6dRsMzi8BpaZkWgC3RoDg=;\n\tb=AjtD4S4oOvFStplAavrDzuNiYKcSwrlFusWrtGyv/3eHWYSnxZaH88CSb+P1n40n7Q\n\tdbEHNCesuTYEZfoLVsXmPFLQm61rESBvp0a6GnBWKFOYVf1lKvDY9fu+TRM9tec4M2TA\n\tGgkx/G5BLaNu0lURvoQtMbMVpR4mabWBTaEXk=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=gtDt9IQmG5dXc60NE2nDlS6dRsMzi8BpaZkWgC3RoDg=;\n\tb=L9oUfZUUwm3tdEe4QZNJ4HU0jemRYqprlpplU/LsG1VW4ZBNt8vR6woat3r6Oogy+U\n\tPaKT62gOGef9aqxQ/zdBD4nwsSQLOr+Gfihs5AZX2LbIsNAPrMAsvo9BNBPnOeFA2Fqd\n\t/p9lDSlsA55fn+uV00HXTxly9Fj6k1tOo5Rpf77TODb9LlMeH/hV4tsBxYWWStcKyu1N\n\tl1IP7K7BWM+y908TNym6c6XYFk+2VdKZt/gOT/U19NDGxGr3sXxbtQmT43KF4591NR+O\n\tmlJJPYXscaZ/vW5xZsL+abIV+XdZzoKZQq9TTWPiUYrjxnwud2vBeuTdeXG0O/mqs69l\n\t3kBg==", "X-Gm-Message-State": "AOAM532wvCMiGHPb3qiU36ie7BC7EHG/wj6Je6LQ6KDO4s2UXnQ7KSkh\n\tKGISMBqGgPSIfvRz4KmWIotCLS7oj2otsA==", "X-Google-Smtp-Source": "ABdhPJz29yGPu0iF6BR4gsTlCFQ5KhWbqgGzHWEuF3SDVlOmWbjSyINz/Cs5dt3ubHH2bQcdj9SfSg==", "X-Received": "by 2002:aa7:9989:0:b029:1f5:aa05:94af with SMTP id\n\tk9-20020aa799890000b02901f5aa0594afmr1914658pfh.34.1616450955648; \n\tMon, 22 Mar 2021 15:09:15 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 23 Mar 2021 07:09:10 +0900", "Message-Id": "<20210322220910.3179457-1-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.31.0.rc2.261.g7f71774620-goog", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: device_enumerator: Remove\n\tunnecessary rvalue references", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "There are std::unique_ptr rvalue reference arguments. They are\nintended to pass the ownership to the functions. In the case,\nit is right to let the argument be std::unique_ptr value and\npass by std::move().\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\n\n---\n include/libcamera/internal/device_enumerator.h | 2 +-\n include/libcamera/internal/device_enumerator_udev.h | 4 ++--\n src/libcamera/device_enumerator.cpp | 2 +-\n 3 files changed, 4 insertions(+), 4 deletions(-)\n\n--\n2.31.0.rc2.261.g7f71774620-goog", "diff": "diff --git a/include/libcamera/internal/device_enumerator.h b/include/libcamera/internal/device_enumerator.h\nindex a9850400..707cfe8f 100644\n--- a/include/libcamera/internal/device_enumerator.h\n+++ b/include/libcamera/internal/device_enumerator.h\n@@ -49,7 +49,7 @@ public:\n\n protected:\n \tstd::unique_ptr<MediaDevice> createDevice(const std::string &deviceNode);\n-\tvoid addDevice(std::unique_ptr<MediaDevice> &&media);\n+\tvoid addDevice(std::unique_ptr<MediaDevice> media);\n \tvoid removeDevice(const std::string &deviceNode);\n\n private:\ndiff --git a/include/libcamera/internal/device_enumerator_udev.h b/include/libcamera/internal/device_enumerator_udev.h\nindex 6f45be0c..58e64a29 100644\n--- a/include/libcamera/internal/device_enumerator_udev.h\n+++ b/include/libcamera/internal/device_enumerator_udev.h\n@@ -39,8 +39,8 @@ private:\n \tusing DependencyMap = std::map<dev_t, std::list<MediaEntity *>>;\n\n \tstruct MediaDeviceDeps {\n-\t\tMediaDeviceDeps(std::unique_ptr<MediaDevice> &&media,\n-\t\t\t\tDependencyMap &&deps)\n+\t\tMediaDeviceDeps(std::unique_ptr<MediaDevice> media,\n+\t\t\t\tDependencyMap deps)\n \t\t\t: media_(std::move(media)), deps_(std::move(deps))\n \t\t{\n \t\t}\ndiff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\nindex 647974b1..e6ecc360 100644\n--- a/src/libcamera/device_enumerator.cpp\n+++ b/src/libcamera/device_enumerator.cpp\n@@ -246,7 +246,7 @@ std::unique_ptr<MediaDevice> DeviceEnumerator::createDevice(const std::string &d\n * This method shall be called after all members of the entities of the\n * media graph have been confirmed to be initialized.\n */\n-void DeviceEnumerator::addDevice(std::unique_ptr<MediaDevice> &&media)\n+void DeviceEnumerator::addDevice(std::unique_ptr<MediaDevice> media)\n {\n \tLOG(DeviceEnumerator, Debug)\n \t\t<< \"Added device \" << media->deviceNode() << \": \" << media->driver();\n", "prefixes": [ "libcamera-devel" ] }