Patch Detail
Show a patch.
GET /api/1.1/patches/11629/?format=api
{ "id": 11629, "url": "https://patchwork.libcamera.org/api/1.1/patches/11629/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11629/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210319160322.13029-1-m.cichy@pengutronix.de>", "date": "2021-03-19T16:03:22", "name": "[libcamera-devel] pipeline: simple: Update documentation on pipeline setup", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "cc770599085cbf2bd1204bd7ecf3d55cfd9f75bd", "submitter": { "id": 80, "url": "https://patchwork.libcamera.org/api/1.1/people/80/?format=api", "name": "Marian Cichy", "email": "m.cichy@pengutronix.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11629/mbox/", "series": [ { "id": 1805, "url": "https://patchwork.libcamera.org/api/1.1/series/1805/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1805", "date": "2021-03-19T16:03:22", "name": "[libcamera-devel] pipeline: simple: Update documentation on pipeline setup", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1805/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11629/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11629/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2696ABD80C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 19 Mar 2021 16:03:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 871FE68D62;\n\tFri, 19 Mar 2021 17:03:29 +0100 (CET)", "from metis.ext.pengutronix.de (metis.ext.pengutronix.de\n\t[IPv6:2001:67c:670:201:290:27ff:fe1d:cc33])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 51EAA6051E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Mar 2021 17:03:28 +0100 (CET)", "from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28])\n\tby metis.ext.pengutronix.de with esmtps\n\t(TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)\n\t(envelope-from <mci@pengutronix.de>)\n\tid 1lNHax-0000Gx-Ey; Fri, 19 Mar 2021 17:03:27 +0100", "from mci by dude02.hi.pengutronix.de with local (Exim 4.92)\n\t(envelope-from <mci@pengutronix.de>)\n\tid 1lNHaw-0003PE-Va; Fri, 19 Mar 2021 17:03:26 +0100" ], "From": "Marian Cichy <m.cichy@pengutronix.de>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 19 Mar 2021 17:03:22 +0100", "Message-Id": "<20210319160322.13029-1-m.cichy@pengutronix.de>", "X-Mailer": "git-send-email 2.29.2", "MIME-Version": "1.0", "X-SA-Exim-Connect-IP": "2001:67c:670:100:1d::28", "X-SA-Exim-Mail-From": "mci@pengutronix.de", "X-SA-Exim-Scanned": "No (on metis.ext.pengutronix.de);\n\tSAEximRunCond expanded to false", "X-PTX-Original-Recipient": "libcamera-devel@lists.libcamera.org", "Subject": "[libcamera-devel] [PATCH] pipeline: simple: Update documentation on\n\tpipeline setup", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "graphics@pengutronix.de, Marian Cichy <m.cichy@pengutronix.de>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "After 4671911df040, the explanation in the SimplePipeline documentation\nhow the handler tries to find a valid path to capture device doest not\nreflect the reality anymore. Update the text to the new situation.\n\nFixes: 4671911df040 (\"pipeline: simple: Use breadth-first search to\nsetup media pipeline\")\n\nSigned-off-by: Marian Cichy <m.cichy@pengutronix.de>\n---\n src/libcamera/pipeline/simple/simple.cpp | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 068fb454..39f3d019 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -69,11 +69,12 @@ LOG_DEFINE_CATEGORY(SimplePipeline)\n *\n * When matching a device, the pipeline handler enumerates all camera sensors\n * and attempts, for each of them, to find a path to a video capture video node.\n- * It does so by traversing the media graph, following the first non permanently\n- * disabled downstream link. If such a path is found, the pipeline handler\n- * creates a corresponding SimpleCameraData instance, and stores the media graph\n- * path in its entities_ list.\n- *\n+ * It does so by using a breadth-first search to find the shortest path from the\n+ * sensor device to a valid capture device. This is guaranteed to produce a\n+ * valid path on devices with one only option and is a good heuristic on more\n+ * complex devices to skip paths that aren't suitable for the simple pipeline\n+ * handler. For instance, on the IPU-based i.MX6, the shortest path will skip\n+ * encoders and image converts, and it will end in a CSI capture device.\n * A more complex graph search algorithm could be implemented if a device that\n * would otherwise be compatible with the pipeline handler isn't correctly\n * handled by this heuristic.\n", "prefixes": [ "libcamera-devel" ] }